From patchwork Mon Jun 24 07:10:41 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?=C5=81ukasz_Spintzyk?= X-Patchwork-Id: 13709102 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D7A35C30653 for ; Mon, 24 Jun 2024 07:23:11 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0ADD610E385; Mon, 24 Jun 2024 07:23:01 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=synaptics.com header.i=@synaptics.com header.b="IYGJF+iM"; dkim-atps=neutral Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2091.outbound.protection.outlook.com [40.107.237.91]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3A02710E370 for ; Mon, 24 Jun 2024 07:11:27 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lgncJYpnUZW57epdWm23x+xLlLVhQlqxMrr3CdrYsWdRgvI8rizNUPcEGlqKAJBWG5A2T+gHCQzSUvXxADMTeqVhHAiOO8GzgBxripRzIHxq+1tYN7xNSTZ7T+4Im0UBH/+75AStg71/B/eOsAdCwgj7fDu4TfsNSZUeebp+Hj/Y8vNPDqgx/m7bxOJAWLOoi4ZtRGifleEKTDQ/52r+xDi9y1D/5EvGRadqP6/L1R9hw2NCyXR2/C3kIZqQ1e9HU1MFf5wWazqFAEKgrfSJRLK8oxJuFdoGUDEaXIZQfYaJRCqJll2nLWRrhNt7RqA7dA3+/WK2Ibu8M1TlseTRHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZzjPdwKz9ljC2BwYLgVlAcJVpgG2p4+yBnna8imPKo4=; b=kmCE1PeOsPnjqUBCkvI4jvzFhRZIM4jw/294xIzz7WW1EFYRerbRrCWDdWy4Rf+Lq4cHqxpM9aJlJOmsDBPnigqkipgpH3jijwbVTMKosP/X0ERn3kNl/TWaYLmi5ZaUByx5Fr2iCvbrGNoIEmHRPsq8exLadGL3d44WlxT719OXkmfvQOdeuUeF4/EU3pWk3w58wJc3lARGp5Zh8ibRzdZU6OyfiarUnVSqWGGCwcNKnhNdWY1n0a20KXCefl0vzFLPYOdjhm5WVbJ9Fkl+Q0fXdRPmt1Xte9Ir1gQDPZfrk/cSj105W98nLOkhdretcaNToF60+XELBU1rvRMoWA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=synaptics.com; dmarc=pass action=none header.from=synaptics.com; dkim=pass header.d=synaptics.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=synaptics.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZzjPdwKz9ljC2BwYLgVlAcJVpgG2p4+yBnna8imPKo4=; b=IYGJF+iMPDCrQGg9eO0Yk7n5h9mOlD2BPiqPxh3Lhjks3ISSPlUCHXjaWK4AQHp7zUI4qTBy0YhLi0+18QR8BM0X9+Vths6aLGq2UTZVA524SVV5hX5Elwt0SdyyeoZRHkbLJgC7RFaADSLhwhgACrhHUZ9djPRR9na2zZoIwuU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=synaptics.com; Received: from BN9PR03MB6188.namprd03.prod.outlook.com (2603:10b6:408:101::18) by BY5PR03MB5063.namprd03.prod.outlook.com (2603:10b6:a03:1e4::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7698.29; Mon, 24 Jun 2024 07:11:25 +0000 Received: from BN9PR03MB6188.namprd03.prod.outlook.com ([fe80::7b19:7f50:4645:3990]) by BN9PR03MB6188.namprd03.prod.outlook.com ([fe80::7b19:7f50:4645:3990%4]) with mapi id 15.20.7698.025; Mon, 24 Jun 2024 07:11:25 +0000 From: lukasz.spintzyk@synaptics.com To: dri-devel@lists.freedesktop.org Cc: Dave Airlie , Sean Paul , Thomas Zimmermann , =?utf-8?q?=C5=81ukasz_Spintzyk?= Subject: [PATCH 4/4] drm/udl: Shutdown all CRTCs on usb disconnect Date: Mon, 24 Jun 2024 09:10:41 +0200 Message-Id: <20240624071041.5087-5-lukasz.spintzyk@synaptics.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240624071041.5087-1-lukasz.spintzyk@synaptics.com> References: <20240624071041.5087-1-lukasz.spintzyk@synaptics.com> X-ClientProxiedBy: LO4P265CA0209.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:33a::16) To BN9PR03MB6188.namprd03.prod.outlook.com (2603:10b6:408:101::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN9PR03MB6188:EE_|BY5PR03MB5063:EE_ X-MS-Office365-Filtering-Correlation-Id: 7e7ae828-3fc1-4218-5342-08dc941cdc09 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230037|376011|1800799021|52116011|366013|38350700011; X-Microsoft-Antispam-Message-Info: =?utf-8?q?g6S85PZNPKT2qJ3s14N6hfu+fKpucxg?= =?utf-8?q?gtoVmdGk6owoH1DrV4QvVq7DiTaUelyYDIoQVbIQ1scVKh6JoXkQwcAq1lGW32vc5?= =?utf-8?q?5YR0MHZAUD+2drijH/o9yAqD8Y0avBx7H6WVTBV5XfwV5di06Kp+B1PlBs7c0uXed?= =?utf-8?q?yZfN0iA95W9SeRWfjZD/awo/jFzg4N5NJ8bj2BuMSWD3QIUIEWIvc9DpClbW0Bs2P?= =?utf-8?q?2pUYkAoI6nU3TvBjLZMhQ4aKTdLT7kvspXrSEk+T44jPKoOALvov97hbFhZ9U8zpE?= =?utf-8?q?M4pJf7la016aGyIi2O9JcyylfNh118iz3diZai6fwl5zYhYE+Lcn3nXEgXF851hkA?= =?utf-8?q?qoTawd85HROmTU4fsukOqa7JSWP+x4x+rbmkpqjFCwBPSWmrcvCohGIFU3EK6vriB?= =?utf-8?q?rzFeIWx3s/6UCbcAmDLSPVw0nHcTeVYvCdnr6ijQJobPX83N20H/gNZTOVQ64OTH4?= =?utf-8?q?+TLiAN07Yb+g/D/o2a1aA/8K/bghauoUizAnK3UrGUND6kxqVjXitmbK9K9qb1rnP?= =?utf-8?q?aPhhdD9eMfomhalJy6EhJv1evi2W5gDYSZ0ccuGJ+c//CbedqUC4XPIwKlZCqzwm9?= =?utf-8?q?TDLLg9x0j4PUD4DcTccLe7um0zCq4CdSj8pMvaQL15a4qkhVkNNkHp7VZX5JAMcWC?= =?utf-8?q?iYRZuxsKRisx2WK8zjAk2bV6sJVTFCEBNdCLRNhyFOzQEwNorwehDcPP/Pvrz5Txp?= =?utf-8?q?xmoHs+nU5y9OVdO+M8IqdeuHOBpB7/PuS8vm3IhlncVJvUzAaXhXKyfVgDgGvXgA7?= =?utf-8?q?AeYO6Tas9beuCj3c7c6JLklQCwycyzMX8A4MyUNPCcSSYGg4+vNGk0CS4oaW36oXt?= =?utf-8?q?IcH7CdBMLktJ2b++5mOHAVTC+RY1kxlHn+a5zed63wYb/IM48/LAtXKLGz8EZcgt9?= =?utf-8?q?kHl3OUZ7GBXnpRLnS66pGdlgcViEdjdUKnbFa/ksAGBl4MPsj4F7WhILnQXlRG8oS?= =?utf-8?q?wFezQXJPACHZ33fsvXAQg8hjuzTAg4xBYuLszG6+YeyfJ6OsRGCTPM7ywHVRpfJSM?= =?utf-8?q?bLhcs1SV1n+TdDZDzdebYL7hxCGaU+whcw9hfR212ETN/DX4xmHcROZBz8YmcWf3U?= =?utf-8?q?YS3TCo8UVvjE/uE+6iFwvQc9F7KwujxXp+Q7pParbbJV+8Yzgey4ktjJSdgKO8vAC?= =?utf-8?q?Z5hMLuc5pJEf/aQjKTFL7U4jJeqO21O2910X7IYMzapcV5jjbw0vfQjEq2yk8WrMk?= =?utf-8?q?+DdMUC0vo51Ab9N9bwMt8283QRPTTg9HDTSo89LYhVZvhNIji8BzeUoG4ulvEsxxD?= =?utf-8?q?YHI43cjq+uyzMWox0kVZsAj2fMsYAvhGbWZ8vxskuLCbhZx/34aTEuVI=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR03MB6188.namprd03.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230037)(376011)(1800799021)(52116011)(366013)(38350700011); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?mnwzbzkR9TBIHgOQXlc/7A/MVcpy?= =?utf-8?q?heNxJkYclknxBzg408zAgVeOEG645kil/4moxtI3FZ6WsvspOe0JpOAubxXignOYC?= =?utf-8?q?a3W0ZsrG0zk96sQcYsLQmWyyNZbxgyhcmhNniL/JfHtvfMc5ZzLIPayI04mLS1IpD?= =?utf-8?q?rZKwQhe1gLswU4V47+qo+opsyrJAkaa07oxfpnRCiwD1PUAomKKmWnYXW1/C84CtK?= =?utf-8?q?3O3clizTwtRmY1aB77rB7nlB/6VpvhrcSK2JUqHJiMZzJuTAf9L7eFusJ7JrPOuu4?= =?utf-8?q?2C0EGpFfObgFa6dda/JXtJeQLIjuNXKyDxeRVIUQHOayczeDyzF1mEz8/2YIK5wZT?= =?utf-8?q?K/VKPZVN1nUh5rYbUJ00gXZ4JbdTh/gfyzLlPfCqJvfsLQXMOU5XGjr06jsvwCsqg?= =?utf-8?q?ro3a0O8spT+sXHIjIxRAItzaN2M7bQXWMxbgZOtfHAURizeuQFVbmy/o28Fli3vUg?= =?utf-8?q?t7a7Q/WZan/S2C8gqd/26p+opRCrawyU894V6cKhH5lFWefmkcwtbEp151i0rPgbj?= =?utf-8?q?picnNi11xEWiR4FjUtpBdAnLfi7vVxsTw1sECc+G/fKHLVYSeMiBDA1bHdBYByJrP?= =?utf-8?q?gUcBwaKNSa6TRyrHQTEq5yETZttG4heZa0AWUkZR6fJN2g7GUNpXWDjIHslry5XyI?= =?utf-8?q?hA6hwsogJvs6jCMJ+xMhk2HM9BzDh8XHxKqb96jCn0Z6cedgri2pGgVTfVY4XmkSU?= =?utf-8?q?zxrqC/949FCVJCs1fabffg8NxZfI21+gx2d+XcLPNx6pAzFyiPp8y2Ex+za8jfqKx?= =?utf-8?q?uuMzdfQPzlFVY7Cn8UCjjdwEnvMVFfxpTuHZd2zS7uIEtQGTOxPsfvsGmhkREGCin?= =?utf-8?q?+aEx0TAoUMULbbcuCJCXjQtbznrJ1bZwyML7YJXHmCsgFDKBwsK1P6cUx1fu51zbU?= =?utf-8?q?86tt6fTKgEVcPT/n83zJK+B0xBi1O9nq/+WAd8YNI/vJbF2PMN7K0cPMBJuZeF7Qo?= =?utf-8?q?UUplDppMU2AGb1aBFlI36/dVVo0SvAawnmKGkSrT/E7ouI+u5uTITNdN9DOdAmLiU?= =?utf-8?q?rn0OaZ9k8nDQpn9LOH9YqSd+kt8aD24vt7brN1NrJZlbftmKdm/pzH/9+w3RnhOpO?= =?utf-8?q?XIEGS7YI1uWo6iNWEmNq1nUFMpHdUYaQs67g/vDPWQ4jAmwLmQMxa0SC3SoRtpSr9?= =?utf-8?q?PkPZjyc9DylTJ67gSKD9NPSwk9x0vlz2wJj1SwUs/2Rz9RwNvUSvRS94cm30RS1A8?= =?utf-8?q?NBu7artmf9G7HsP6eonkh8zhxS/hnapn7fPuPCYxTQqXt4XHCeHg+fs7/fOgUqHH1?= =?utf-8?q?d/02/YbboNfFpj2yNceF42fSTbn901C+HzfqMONsJ61fa19Gat+kXeuS/N+FKAuHv?= =?utf-8?q?Jkig1qpr4eB5TxcDG1fc4GcQc/VAlPYOPET7TRjyqAoKeGlZUo/OdZdE3wAuF14fn?= =?utf-8?q?SWOGP3EWOo2ghhDoj0TnL4E1rEEu7N3SwRZrQB4/xrwwqj0qS4KIvB/N5pykBSO+x?= =?utf-8?q?ugMKJfRVymDs7LCqu7uR18DzovJEBcFqPwbQ9kxLkoeh9cdyH9enEetS6Srax3DlJ?= =?utf-8?q?qt6++pPJuRxB?= X-OriginatorOrg: synaptics.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7e7ae828-3fc1-4218-5342-08dc941cdc09 X-MS-Exchange-CrossTenant-AuthSource: BN9PR03MB6188.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jun 2024 07:11:25.3380 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335d1fbc-2124-4173-9863-17e7051a2a0e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: o060mj9cvK7ENgOHgrxUnC09fRPriNsLdLiwwofIM7OEff7y/2wswmYsWSh9l4G281qaWgowdMjPLB5EsPLeXQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB5063 X-Mailman-Approved-At: Mon, 24 Jun 2024 07:22:58 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: Łukasz Spintzyk This is fixing some kernel panics on device unplug, that started to be more visible after implementing cursor plane support. Signed-off-by: Łukasz Spintzyk --- drivers/gpu/drm/udl/udl_drv.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/udl/udl_drv.c b/drivers/gpu/drm/udl/udl_drv.c index 1506094a8009..adaa7703c118 100644 --- a/drivers/gpu/drm/udl/udl_drv.c +++ b/drivers/gpu/drm/udl/udl_drv.c @@ -1,6 +1,7 @@ // SPDX-License-Identifier: GPL-2.0-only /* * Copyright (C) 2012 Red Hat + * Copyright (c) 2024 Synaptics Incorporated. All Rights Reserved. */ #include @@ -14,6 +15,7 @@ #include #include #include +#include #include "udl_drv.h" @@ -129,6 +131,7 @@ static void udl_usb_disconnect(struct usb_interface *interface) drm_kms_helper_poll_fini(dev); udl_drop_usb(dev); drm_dev_unplug(dev); + drm_atomic_helper_shutdown(dev); } /*