diff mbox series

[v3,1/2] drm: panel-orientation-quirks: Add quirk for Valve Galileo

Message ID 20240627203057.127034-2-mattschwartz@gwu.edu (mailing list archive)
State New, archived
Headers show
Series drm: panel-orientation-quirks: Add quirk for Steam Deck Galileo revision and re-label the Deck panel quirks to specify hardware revision | expand

Commit Message

Matthew Schwartz June 27, 2024, 8:30 p.m. UTC 
From: John Schoenick <johns@valvesoftware.com>

Valve's Steam Deck Galileo revision has a 800x1280 OLED panel

Suggested-by: John Schoenick <johns@valvesoftware.com>
Link: https://gitlab.com/evlaV/linux-integration/-/commit/d2522d8bf88b35a8cf6978afbbd55c80d2d53f4f
Signed-off-by: Matthew Schwartz <mattschwartz@gwu.edu>
---
 drivers/gpu/drm/drm_panel_orientation_quirks.c | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Hamza Mahfooz June 27, 2024, 9:28 p.m. UTC | #1 
On 6/27/24 16:30, Matthew Schwartz wrote:
> From: John Schoenick <johns@valvesoftware.com>

Since this patch is from John, you would need his S-o-b in here as well
(assuming you have his permission to add it).

> 
> Valve's Steam Deck Galileo revision has a 800x1280 OLED panel
> 
> Suggested-by: John Schoenick <johns@valvesoftware.com>
> Link: https://gitlab.com/evlaV/linux-integration/-/commit/d2522d8bf88b35a8cf6978afbbd55c80d2d53f4f
> Signed-off-by: Matthew Schwartz <mattschwartz@gwu.edu>
> ---
>   drivers/gpu/drm/drm_panel_orientation_quirks.c | 7 +++++++
>   1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> index 3d127127e7cb..ac8319d38e37 100644
> --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
> +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> @@ -427,6 +427,13 @@ static const struct dmi_system_id orientation_data[] = {
>   		  DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "1"),
>   		},
>   		.driver_data = (void *)&lcd800x1280_rightside_up,
> +	}, {	/* Valve Steam Deck */
> +		.matches = {
> +		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Valve"),
> +		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Galileo"),
> +		  DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "1"),
> +		},
> +		.driver_data = (void *)&lcd800x1280_rightside_up,
>   	}, {	/* VIOS LTH17 */
>   		.matches = {
>   		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "VIOS"),
Matthew Schwartz June 28, 2024, 12:17 a.m. UTC | #2 
On Thu, Jun 27, 2024 at 2:28 PM Hamza Mahfooz <hamza.mahfooz@amd.com> wrote:
>
> On 6/27/24 16:30, Matthew Schwartz wrote:
> > From: John Schoenick <johns@valvesoftware.com>
>
> Since this patch is from John, you would need his S-o-b in here as well
> (assuming you have his permission to add it).

This patch will be pending approval from them in that case. The panel quirk
follows the same structure as the Steam Deck Jupiter revision, but the quirk
has only been signed during merges by people who were not the original author.
Link: https://gitlab.com/evlaV/linux-integration/-/commit/b90ac393

>
> >
> > Valve's Steam Deck Galileo revision has a 800x1280 OLED panel
> >
> > Suggested-by: John Schoenick <johns@valvesoftware.com>
> > Link: https://gitlab.com/evlaV/linux-integration/-/commit/d2522d8bf88b35a8cf6978afbbd55c80d2d53f4f
> > Signed-off-by: Matthew Schwartz <mattschwartz@gwu.edu>
> > ---
> >   drivers/gpu/drm/drm_panel_orientation_quirks.c | 7 +++++++
> >   1 file changed, 7 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> > index 3d127127e7cb..ac8319d38e37 100644
> > --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
> > +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> > @@ -427,6 +427,13 @@ static const struct dmi_system_id orientation_data[] = {
> >                 DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "1"),
> >               },
> >               .driver_data = (void *)&lcd800x1280_rightside_up,
> > +     }, {    /* Valve Steam Deck */
> > +             .matches = {
> > +               DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Valve"),
> > +               DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Galileo"),
> > +               DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "1"),
> > +             },
> > +             .driver_data = (void *)&lcd800x1280_rightside_up,

Unless I get a S-o-b, is authoring a different DMI check the only solution
to get a functioning panel quirk upstreamed for the Galileo revision?
Not quite sure how I'd maintain conformity with the existing Jupiter
quirk while also writing something original here.

> >       }, {    /* VIOS LTH17 */
> >               .matches = {
> >                 DMI_EXACT_MATCH(DMI_SYS_VENDOR, "VIOS"),
> --
> Hamza
>
--
Matt
John Schoenick June 28, 2024, 5:25 p.m. UTC | #3 
On 6/27/24 5:17 PM, Matthew Schwartz wrote:
> On Thu, Jun 27, 2024 at 2:28 PM Hamza Mahfooz <hamza.mahfooz@amd.com> wrote:
>> On 6/27/24 16:30, Matthew Schwartz wrote:
>>> From: John Schoenick <johns@valvesoftware.com>
>> Since this patch is from John, you would need his S-o-b in here as well
>> (assuming you have his permission to add it).
> This patch will be pending approval from them in that case. The panel quirk
> follows the same structure as the Steam Deck Jupiter revision, but the quirk
> has only been signed during merges by people who were not the original author.
> Link: https://gitlab.com/evlaV/linux-integration/-/commit/b90ac393

Hey, thanks for taking the initiative to upstream this -- feel free to 
add my S-o-b

>>
>>> Valve's Steam Deck Galileo revision has a 800x1280 OLED panel
>>>
>>> Suggested-by: John Schoenick <johns@valvesoftware.com>
>>> Link: https://gitlab.com/evlaV/linux-integration/-/commit/d2522d8bf88b35a8cf6978afbbd55c80d2d53f4f
>>> Signed-off-by: Matthew Schwartz <mattschwartz@gwu.edu>
>>> ---
>>>    drivers/gpu/drm/drm_panel_orientation_quirks.c | 7 +++++++
>>>    1 file changed, 7 insertions(+)
>>>
>>> diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
>>> index 3d127127e7cb..ac8319d38e37 100644
>>> --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
>>> +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
>>> @@ -427,6 +427,13 @@ static const struct dmi_system_id orientation_data[] = {
>>>                  DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "1"),
>>>                },
>>>                .driver_data = (void *)&lcd800x1280_rightside_up,
>>> +     }, {    /* Valve Steam Deck */
>>> +             .matches = {
>>> +               DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Valve"),
>>> +               DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Galileo"),
>>> +               DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "1"),
>>> +             },
>>> +             .driver_data = (void *)&lcd800x1280_rightside_up,
> Unless I get a S-o-b, is authoring a different DMI check the only solution
> to get a functioning panel quirk upstreamed for the Galileo revision?
> Not quite sure how I'd maintain conformity with the existing Jupiter
> quirk while also writing something original here.
>
>>>        }, {    /* VIOS LTH17 */
>>>                .matches = {
>>>                  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "VIOS"),
>> --
>> Hamza
>>
> --
> Matt
>
diff mbox series

Patch

diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
index 3d127127e7cb..ac8319d38e37 100644
--- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
+++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
@@ -427,6 +427,13 @@  static const struct dmi_system_id orientation_data[] = {
 		  DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "1"),
 		},
 		.driver_data = (void *)&lcd800x1280_rightside_up,
+	}, {	/* Valve Steam Deck */
+		.matches = {
+		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Valve"),
+		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Galileo"),
+		  DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "1"),
+		},
+		.driver_data = (void *)&lcd800x1280_rightside_up,
 	}, {	/* VIOS LTH17 */
 		.matches = {
 		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "VIOS"),