| Message ID | 20240706034004.801329-2-mwen@igalia.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/amd/display: switch amdgpu_dm_connector to use struct drm_edid | expand |
Hi Melissa, There are no commit messages in this patch. Also, do you think this can be merged with Patch 5 "drm/amd/display: remove redundant freesync parser for DP"? On 2024-07-05 21:35, Melissa Wen wrote: > Signed-off-by: Melissa Wen <mwen@igalia.com> > --- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > index 98cf523a629e..1dfa7ec9af35 100644 > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > @@ -12108,9 +12108,6 @@ void amdgpu_dm_update_freesync_caps(struct drm_connector *connector, > } else if (edid && sink->sink_signal == SIGNAL_TYPE_HDMI_TYPE_A) { > i = parse_hdmi_amd_vsdb(amdgpu_dm_connector, edid, &vsdb_info); > if (i >= 0 && vsdb_info.freesync_supported) { > - timing = &edid->detailed_timings[i]; > - data = &timing->data.other_data; > - > amdgpu_dm_connector->min_vfreq = vsdb_info.min_refresh_rate_hz; > amdgpu_dm_connector->max_vfreq = vsdb_info.max_refresh_rate_hz; > if (amdgpu_dm_connector->max_vfreq - amdgpu_dm_connector->min_vfreq > 10)
On 07/25, Alex Hung wrote: > Hi Melissa, > > There are no commit messages in this patch. > > Also, do you think this can be merged with Patch 5 "drm/amd/display: remove > redundant freesync parser for DP"? Hi Alex, Thanks for your feedback. I'll add a brief description in the next version. Regarding merging it into patch 5, I'd prefer to keep it detached because here we have a non-functional change. I can send it as a separate, single patch from this series to reduce noise and make validation faster. WDYT? Melissa > > On 2024-07-05 21:35, Melissa Wen wrote: > > Signed-off-by: Melissa Wen <mwen@igalia.com> > > --- > > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 --- > > 1 file changed, 3 deletions(-) > > > > diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > > index 98cf523a629e..1dfa7ec9af35 100644 > > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > > +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > > @@ -12108,9 +12108,6 @@ void amdgpu_dm_update_freesync_caps(struct drm_connector *connector, > > } else if (edid && sink->sink_signal == SIGNAL_TYPE_HDMI_TYPE_A) { > > i = parse_hdmi_amd_vsdb(amdgpu_dm_connector, edid, &vsdb_info); > > if (i >= 0 && vsdb_info.freesync_supported) { > > - timing = &edid->detailed_timings[i]; > > - data = &timing->data.other_data; > > - > > amdgpu_dm_connector->min_vfreq = vsdb_info.min_refresh_rate_hz; > > amdgpu_dm_connector->max_vfreq = vsdb_info.max_refresh_rate_hz; > > if (amdgpu_dm_connector->max_vfreq - amdgpu_dm_connector->min_vfreq > 10)
On 2024-07-28 19:32, Melissa Wen wrote: > On 07/25, Alex Hung wrote: >> Hi Melissa, >> >> There are no commit messages in this patch. >> >> Also, do you think this can be merged with Patch 5 "drm/amd/display: remove >> redundant freesync parser for DP"? > > Hi Alex, > > Thanks for your feedback. > I'll add a brief description in the next version. > Regarding merging it into patch 5, I'd prefer to keep it detached > because here we have a non-functional change. I can send it as a > separate, single patch from this series to reduce noise and make > validation faster. WDYT? Make thanks. Thanks for clarification. > > Melissa > >> >> On 2024-07-05 21:35, Melissa Wen wrote: >>> Signed-off-by: Melissa Wen <mwen@igalia.com> >>> --- >>> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 --- >>> 1 file changed, 3 deletions(-) >>> >>> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c >>> index 98cf523a629e..1dfa7ec9af35 100644 >>> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c >>> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c >>> @@ -12108,9 +12108,6 @@ void amdgpu_dm_update_freesync_caps(struct drm_connector *connector, >>> } else if (edid && sink->sink_signal == SIGNAL_TYPE_HDMI_TYPE_A) { >>> i = parse_hdmi_amd_vsdb(amdgpu_dm_connector, edid, &vsdb_info); >>> if (i >= 0 && vsdb_info.freesync_supported) { >>> - timing = &edid->detailed_timings[i]; >>> - data = &timing->data.other_data; >>> - >>> amdgpu_dm_connector->min_vfreq = vsdb_info.min_refresh_rate_hz; >>> amdgpu_dm_connector->max_vfreq = vsdb_info.max_refresh_rate_hz; >>> if (amdgpu_dm_connector->max_vfreq - amdgpu_dm_connector->min_vfreq > 10)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c index 98cf523a629e..1dfa7ec9af35 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c @@ -12108,9 +12108,6 @@ void amdgpu_dm_update_freesync_caps(struct drm_connector *connector, } else if (edid && sink->sink_signal == SIGNAL_TYPE_HDMI_TYPE_A) { i = parse_hdmi_amd_vsdb(amdgpu_dm_connector, edid, &vsdb_info); if (i >= 0 && vsdb_info.freesync_supported) { - timing = &edid->detailed_timings[i]; - data = &timing->data.other_data; - amdgpu_dm_connector->min_vfreq = vsdb_info.min_refresh_rate_hz; amdgpu_dm_connector->max_vfreq = vsdb_info.max_refresh_rate_hz; if (amdgpu_dm_connector->max_vfreq - amdgpu_dm_connector->min_vfreq > 10)
Signed-off-by: Melissa Wen <mwen@igalia.com> --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 --- 1 file changed, 3 deletions(-)