diff mbox series

drm/omap: add CONFIG_MMU dependency

Message ID 20240719095942.3841009-1-arnd@kernel.org (mailing list archive)
State New, archived
Headers show
Series drm/omap: add CONFIG_MMU dependency | expand

Commit Message

Arnd Bergmann July 19, 2024, 9:59 a.m. UTC 
From: Arnd Bergmann <arnd@arndb.de>

Compile-testing with CONFIG_MMU disabled causes a link error in omapdrm:

arm-linux-gnueabi-ld: drivers/gpu/drm/omapdrm/omap_gem.o: in function `omap_gem_fault_2d':
omap_gem.c:(.text+0x36e): undefined reference to `vmf_insert_mixed'
arm-linux-gnueabi-ld: drivers/gpu/drm/omapdrm/omap_gem.o: in function `omap_gem_fault':
omap_gem.c:(.text+0x74a): undefined reference to `vmf_insert_mixed'

Avoid this by adding a Kconfig dependency.

Fixes: dc6fcaaba5a5 ("drm/omap: Allow build with COMPILE_TEST=y")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/gpu/drm/omapdrm/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Tomi Valkeinen Aug. 5, 2024, 12:54 p.m. UTC | #1 
Hi,

On 19/07/2024 12:59, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> Compile-testing with CONFIG_MMU disabled causes a link error in omapdrm:
> 
> arm-linux-gnueabi-ld: drivers/gpu/drm/omapdrm/omap_gem.o: in function `omap_gem_fault_2d':
> omap_gem.c:(.text+0x36e): undefined reference to `vmf_insert_mixed'
> arm-linux-gnueabi-ld: drivers/gpu/drm/omapdrm/omap_gem.o: in function `omap_gem_fault':
> omap_gem.c:(.text+0x74a): undefined reference to `vmf_insert_mixed'
> 
> Avoid this by adding a Kconfig dependency.
> 
> Fixes: dc6fcaaba5a5 ("drm/omap: Allow build with COMPILE_TEST=y")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Thanks, applying to drm-misc-fixes.

  Tomi

> ---
>   drivers/gpu/drm/omapdrm/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/omapdrm/Kconfig b/drivers/gpu/drm/omapdrm/Kconfig
> index 3f7139e211d2..64e440a2649b 100644
> --- a/drivers/gpu/drm/omapdrm/Kconfig
> +++ b/drivers/gpu/drm/omapdrm/Kconfig
> @@ -1,6 +1,7 @@
>   # SPDX-License-Identifier: GPL-2.0-only
>   config DRM_OMAP
>   	tristate "OMAP DRM"
> +	depends on MMU
>   	depends on DRM && OF
>   	depends on ARCH_OMAP2PLUS || (COMPILE_TEST && PAGE_SIZE_LESS_THAN_64KB)
>   	select DRM_KMS_HELPER
diff mbox series

Patch

diff --git a/drivers/gpu/drm/omapdrm/Kconfig b/drivers/gpu/drm/omapdrm/Kconfig
index 3f7139e211d2..64e440a2649b 100644
--- a/drivers/gpu/drm/omapdrm/Kconfig
+++ b/drivers/gpu/drm/omapdrm/Kconfig
@@ -1,6 +1,7 @@ 
 # SPDX-License-Identifier: GPL-2.0-only
 config DRM_OMAP
 	tristate "OMAP DRM"
+	depends on MMU
 	depends on DRM && OF
 	depends on ARCH_OMAP2PLUS || (COMPILE_TEST && PAGE_SIZE_LESS_THAN_64KB)
 	select DRM_KMS_HELPER