diff mbox series

drm/edid: add non-desktop quirk to Pimax VR Headsets

Message ID 20240720110437.251252-2-contact@scrumplex.net (mailing list archive)
State New, archived
Headers show
Series drm/edid: add non-desktop quirk to Pimax VR Headsets | expand

Commit Message

Sefa Eyeoglu July 20, 2024, 11:03 a.m. UTC
See https://gitlab.freedesktop.org/drm/misc/kernel/-/issues/40

Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
---
 drivers/gpu/drm/drm_edid.c | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Jani Nikula July 24, 2024, 7:22 a.m. UTC | #1
On Sat, 20 Jul 2024, Sefa Eyeoglu <contact@scrumplex.net> wrote:
> See https://gitlab.freedesktop.org/drm/misc/kernel/-/issues/40

Please attach the relevant EDID blobs to the bug.

BR,
Jani.

>
> Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
> ---
>  drivers/gpu/drm/drm_edid.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
> index f68a41eeb1fa..41879d67599d 100644
> --- a/drivers/gpu/drm/drm_edid.c
> +++ b/drivers/gpu/drm/drm_edid.c
> @@ -237,6 +237,11 @@ static const struct edid_quirk {
>  	EDID_QUIRK('S', 'E', 'C', 0x144a, EDID_QUIRK_NON_DESKTOP),
>  	EDID_QUIRK('A', 'U', 'S', 0xc102, EDID_QUIRK_NON_DESKTOP),
>  
> +	/* Pimax VR Headsets */
> +	EDID_QUIRK('P', 'V', 'R', 0x1019, EDID_QUIRK_NON_DESKTOP),
> +	EDID_QUIRK('P', 'V', 'R', 0x101a, EDID_QUIRK_NON_DESKTOP),
> +	EDID_QUIRK('P', 'V', 'R', 0x101b, EDID_QUIRK_NON_DESKTOP),
> +
>  	/* Sony PlayStation VR Headset */
>  	EDID_QUIRK('S', 'N', 'Y', 0x0704, EDID_QUIRK_NON_DESKTOP),
Sefa Eyeoglu July 25, 2024, 7:20 a.m. UTC | #2
Hi Jani,

I have asked someone with the actual hardware to attach their EDID blob
to the issue.

Kind regards,
Sefa

On Wed, 2024-07-24 at 10:22 +0300, Jani Nikula wrote:
> On Sat, 20 Jul 2024, Sefa Eyeoglu <contact@scrumplex.net> wrote:
> > See https://gitlab.freedesktop.org/drm/misc/kernel/-/issues/40
> 
> Please attach the relevant EDID blobs to the bug.
> 
> BR,
> Jani.
> 
> > 
> > Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
> > ---
> >  drivers/gpu/drm/drm_edid.c | 5 +++++
> >  1 file changed, 5 insertions(+)
> > 
> > diff --git a/drivers/gpu/drm/drm_edid.c
> > b/drivers/gpu/drm/drm_edid.c
> > index f68a41eeb1fa..41879d67599d 100644
> > --- a/drivers/gpu/drm/drm_edid.c
> > +++ b/drivers/gpu/drm/drm_edid.c
> > @@ -237,6 +237,11 @@ static const struct edid_quirk {
> >  	EDID_QUIRK('S', 'E', 'C', 0x144a, EDID_QUIRK_NON_DESKTOP),
> >  	EDID_QUIRK('A', 'U', 'S', 0xc102, EDID_QUIRK_NON_DESKTOP),
> >  
> > +	/* Pimax VR Headsets */
> > +	EDID_QUIRK('P', 'V', 'R', 0x1019, EDID_QUIRK_NON_DESKTOP),
> > +	EDID_QUIRK('P', 'V', 'R', 0x101a, EDID_QUIRK_NON_DESKTOP),
> > +	EDID_QUIRK('P', 'V', 'R', 0x101b, EDID_QUIRK_NON_DESKTOP),
> > +
> >  	/* Sony PlayStation VR Headset */
> >  	EDID_QUIRK('S', 'N', 'Y', 0x0704, EDID_QUIRK_NON_DESKTOP),
>
Jani Nikula Aug. 13, 2024, 3:08 p.m. UTC | #3
On Thu, 25 Jul 2024, Sefa Eyeoglu <contact@scrumplex.net> wrote:
> Hi Jani,
>
> I have asked someone with the actual hardware to attach their EDID blob
> to the issue.

There's only one so far, but that one does require the quirk.

Acked-by: Jani Nikula <jani.nikula@intel.com>



>
> Kind regards,
> Sefa
>
> On Wed, 2024-07-24 at 10:22 +0300, Jani Nikula wrote:
>> On Sat, 20 Jul 2024, Sefa Eyeoglu <contact@scrumplex.net> wrote:
>> > See https://gitlab.freedesktop.org/drm/misc/kernel/-/issues/40
>> 
>> Please attach the relevant EDID blobs to the bug.
>> 
>> BR,
>> Jani.
>> 
>> > 
>> > Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
>> > ---
>> >  drivers/gpu/drm/drm_edid.c | 5 +++++
>> >  1 file changed, 5 insertions(+)
>> > 
>> > diff --git a/drivers/gpu/drm/drm_edid.c
>> > b/drivers/gpu/drm/drm_edid.c
>> > index f68a41eeb1fa..41879d67599d 100644
>> > --- a/drivers/gpu/drm/drm_edid.c
>> > +++ b/drivers/gpu/drm/drm_edid.c
>> > @@ -237,6 +237,11 @@ static const struct edid_quirk {
>> >  	EDID_QUIRK('S', 'E', 'C', 0x144a, EDID_QUIRK_NON_DESKTOP),
>> >  	EDID_QUIRK('A', 'U', 'S', 0xc102, EDID_QUIRK_NON_DESKTOP),
>> >  
>> > +	/* Pimax VR Headsets */
>> > +	EDID_QUIRK('P', 'V', 'R', 0x1019, EDID_QUIRK_NON_DESKTOP),
>> > +	EDID_QUIRK('P', 'V', 'R', 0x101a, EDID_QUIRK_NON_DESKTOP),
>> > +	EDID_QUIRK('P', 'V', 'R', 0x101b, EDID_QUIRK_NON_DESKTOP),
>> > +
>> >  	/* Sony PlayStation VR Headset */
>> >  	EDID_QUIRK('S', 'N', 'Y', 0x0704, EDID_QUIRK_NON_DESKTOP),
>> 
>
diff mbox series

Patch

diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
index f68a41eeb1fa..41879d67599d 100644
--- a/drivers/gpu/drm/drm_edid.c
+++ b/drivers/gpu/drm/drm_edid.c
@@ -237,6 +237,11 @@  static const struct edid_quirk {
 	EDID_QUIRK('S', 'E', 'C', 0x144a, EDID_QUIRK_NON_DESKTOP),
 	EDID_QUIRK('A', 'U', 'S', 0xc102, EDID_QUIRK_NON_DESKTOP),
 
+	/* Pimax VR Headsets */
+	EDID_QUIRK('P', 'V', 'R', 0x1019, EDID_QUIRK_NON_DESKTOP),
+	EDID_QUIRK('P', 'V', 'R', 0x101a, EDID_QUIRK_NON_DESKTOP),
+	EDID_QUIRK('P', 'V', 'R', 0x101b, EDID_QUIRK_NON_DESKTOP),
+
 	/* Sony PlayStation VR Headset */
 	EDID_QUIRK('S', 'N', 'Y', 0x0704, EDID_QUIRK_NON_DESKTOP),