diff mbox series

drm: panel: boe-bf060y8m-aj0: Enable prepare_prev_first

Message ID 20240722-bf060y8m-aj0-prepare-prev-v1-1-0e51c0f59d22@riseup.net (mailing list archive)
State New, archived
Headers show
Series drm: panel: boe-bf060y8m-aj0: Enable prepare_prev_first | expand

Commit Message

Dang Huynh July 22, 2024, 7:07 a.m. UTC
Enable prepare_prev_first flag for BF060Y8M-AJ0 panel so that the
previous controller should be prepared first before the prepare for
the panel is called.

This makes sure that the previous controller, likely to be a DSI host
controller should be initialized to LP-11 before the panel is powered up.

Suggested-by: Marijn Suijten <marijn.suijten@somainline.org>
Signed-off-by: Dang Huynh <danct12@riseup.net>
---
This fixes display initialization on some platform/devices such as the
Fxtec Pro1X.
---
 drivers/gpu/drm/panel/panel-boe-bf060y8m-aj0.c | 2 ++
 1 file changed, 2 insertions(+)


---
base-commit: 41c196e567fb1ea97f68a2ffb7faab451cd90854
change-id: 20240722-bf060y8m-aj0-prepare-prev-2db87e7dd996

Best regards,

Comments

Neil Armstrong July 24, 2024, 7:53 a.m. UTC | #1
On 22/07/2024 09:07, Dang Huynh wrote:
> Enable prepare_prev_first flag for BF060Y8M-AJ0 panel so that the
> previous controller should be prepared first before the prepare for
> the panel is called.
> 
> This makes sure that the previous controller, likely to be a DSI host
> controller should be initialized to LP-11 before the panel is powered up.
> 
> Suggested-by: Marijn Suijten <marijn.suijten@somainline.org>
> Signed-off-by: Dang Huynh <danct12@riseup.net>
> ---
> This fixes display initialization on some platform/devices such as the
> Fxtec Pro1X.
> ---
>   drivers/gpu/drm/panel/panel-boe-bf060y8m-aj0.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/panel/panel-boe-bf060y8m-aj0.c b/drivers/gpu/drm/panel/panel-boe-bf060y8m-aj0.c
> index e77db8597eb7..7e66db4a88bb 100644
> --- a/drivers/gpu/drm/panel/panel-boe-bf060y8m-aj0.c
> +++ b/drivers/gpu/drm/panel/panel-boe-bf060y8m-aj0.c
> @@ -377,6 +377,8 @@ static int boe_bf060y8m_aj0_probe(struct mipi_dsi_device *dsi)
>   	drm_panel_init(&boe->panel, dev, &boe_bf060y8m_aj0_panel_funcs,
>   		       DRM_MODE_CONNECTOR_DSI);
>   
> +	boe->panel.prepare_prev_first = true;
> +
>   	boe->panel.backlight = boe_bf060y8m_aj0_create_backlight(dsi);
>   	if (IS_ERR(boe->panel.backlight))
>   		return dev_err_probe(dev, PTR_ERR(boe->panel.backlight),
> 
> ---
> base-commit: 41c196e567fb1ea97f68a2ffb7faab451cd90854
> change-id: 20240722-bf060y8m-aj0-prepare-prev-2db87e7dd996
> 
> Best regards,

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Neil Armstrong July 24, 2024, 8 a.m. UTC | #2
Hi,

On Mon, 22 Jul 2024 14:07:15 +0700, Dang Huynh wrote:
> Enable prepare_prev_first flag for BF060Y8M-AJ0 panel so that the
> previous controller should be prepared first before the prepare for
> the panel is called.
> 
> This makes sure that the previous controller, likely to be a DSI host
> controller should be initialized to LP-11 before the panel is powered up.
> 
> [...]

Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-next)

[1/1] drm: panel: boe-bf060y8m-aj0: Enable prepare_prev_first
      https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/61eec998c9399d1cce91c7a2f51a4d0cfbab97bb
diff mbox series

Patch

diff --git a/drivers/gpu/drm/panel/panel-boe-bf060y8m-aj0.c b/drivers/gpu/drm/panel/panel-boe-bf060y8m-aj0.c
index e77db8597eb7..7e66db4a88bb 100644
--- a/drivers/gpu/drm/panel/panel-boe-bf060y8m-aj0.c
+++ b/drivers/gpu/drm/panel/panel-boe-bf060y8m-aj0.c
@@ -377,6 +377,8 @@  static int boe_bf060y8m_aj0_probe(struct mipi_dsi_device *dsi)
 	drm_panel_init(&boe->panel, dev, &boe_bf060y8m_aj0_panel_funcs,
 		       DRM_MODE_CONNECTOR_DSI);
 
+	boe->panel.prepare_prev_first = true;
+
 	boe->panel.backlight = boe_bf060y8m_aj0_create_backlight(dsi);
 	if (IS_ERR(boe->panel.backlight))
 		return dev_err_probe(dev, PTR_ERR(boe->panel.backlight),