diff mbox series

backlight: pwm_bl: print errno for probe errors

Message ID 20240801091255.1410027-1-martin.kepplinger-novakovic@ginzinger.com (mailing list archive)
State New, archived
Headers show
Series backlight: pwm_bl: print errno for probe errors | expand

Commit Message

Martin Kepplinger-Novaković Aug. 1, 2024, 9:12 a.m. UTC 
This makes debugging often easier.

Signed-off-by: Martin Kepplinger-Novaković <martin.kepplinger-novakovic@ginzinger.com>
---
 drivers/video/backlight/pwm_bl.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

Comments

Lee Jones Aug. 1, 2024, 12:31 p.m. UTC | #1 
On Thu, 01 Aug 2024, Martin Kepplinger-Novaković wrote:

> This makes debugging often easier.
> 
> Signed-off-by: Martin Kepplinger-Novaković <martin.kepplinger-novakovic@ginzinger.com>
> ---
>  drivers/video/backlight/pwm_bl.c | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)

Please refrain from signing your mails like this.  It means that some of
us have to physically click a pop-up box as we are parsing our inboxes.

I'm deleting all mails in this thread.
diff mbox series

Patch

diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c
index f1005bd0c41e3..cc7e7af71891f 100644
--- a/drivers/video/backlight/pwm_bl.c
+++ b/drivers/video/backlight/pwm_bl.c
@@ -502,7 +502,8 @@  static int pwm_backlight_probe(struct platform_device *pdev)
 						  GPIOD_ASIS);
 	if (IS_ERR(pb->enable_gpio)) {
 		ret = dev_err_probe(&pdev->dev, PTR_ERR(pb->enable_gpio),
-				    "failed to acquire enable GPIO\n");
+				    "failed to acquire enable GPIO: %ld\n",
+				    PTR_ERR(pb->enable_gpio));
 		goto err_alloc;
 	}
 
@@ -513,7 +514,8 @@  static int pwm_backlight_probe(struct platform_device *pdev)
 			pb->power_supply = NULL;
 		} else {
 			dev_err_probe(&pdev->dev, ret,
-				      "failed to acquire power regulator\n");
+				      "failed to acquire power regulator: %d\n",
+				      ret);
 			goto err_alloc;
 		}
 	}
@@ -521,7 +523,8 @@  static int pwm_backlight_probe(struct platform_device *pdev)
 	pb->pwm = devm_pwm_get(&pdev->dev, NULL);
 	if (IS_ERR(pb->pwm)) {
 		ret = dev_err_probe(&pdev->dev, PTR_ERR(pb->pwm),
-				    "unable to request PWM\n");
+				    "unable to request PWM: %ld\n",
+				    PTR_ERR(pb->pwm));
 		goto err_alloc;
 	}