From patchwork Fri Aug 9 00:06:46 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Harrison X-Patchwork-Id: 13758256 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2486EC52D7B for ; Fri, 9 Aug 2024 00:06:50 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A34AA10E835; Fri, 9 Aug 2024 00:06:48 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="YzDFCsel"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by gabe.freedesktop.org (Postfix) with ESMTPS id 182C210E82E; Fri, 9 Aug 2024 00:06:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1723162008; x=1754698008; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=sgWT0C1e6mNVgtU6hTXyIuwBguenbIfIqlvhnDxPODU=; b=YzDFCseliMmj77rypobv2GFgZCKdlDWD0yGzf61IPITa8AqCCcJX0Bin lHavnidoXeJPfOkpBIHkbq/+uyZ1/u5ywUqXcss+ejPqq/h8BkUCvkkhl ZgyGTaYBT/hw9K25L66UyZdEKp3ENTuJTgptVAHpG2I384fG41NMz37cL xqokDJv1+OB0vxvrIrdL8DjqFhdzXx95+70OXPPxf5eJM9fY+eUaBBhjK xPxpCeTIoC0hrIfeXwNEZ2ZMQzgUGjQV4Xg7iOvUf1oyPh+0UE6TLmtNw YKNsrzR9DPnoG6anMFd8w7q/kjL1dXmGBsT5CHXI2lxju7OagVvxiOKda g==; X-CSE-ConnectionGUID: /S1cB+e0SN6j1voR2HoBDQ== X-CSE-MsgGUID: NVjhk1N+Rt2ekdK9JZ/Rfg== X-IronPort-AV: E=McAfee;i="6700,10204,11158"; a="43835806" X-IronPort-AV: E=Sophos;i="6.09,274,1716274800"; d="scan'208";a="43835806" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Aug 2024 17:06:47 -0700 X-CSE-ConnectionGUID: goIRT5viSOm7yW+dfRsxzg== X-CSE-MsgGUID: i7l/YfPDSPKGrGW06rebTQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,274,1716274800"; d="scan'208";a="57348475" Received: from relo-linux-5.jf.intel.com ([10.165.21.152]) by fmviesa008.fm.intel.com with ESMTP; 08 Aug 2024 17:06:47 -0700 From: John.C.Harrison@Intel.com To: Intel-GFX@Lists.FreeDesktop.Org Cc: DRI-Devel@Lists.FreeDesktop.Org, John Harrison , Vinay Belgaumkar , Daniele Ceraolo Spurio , Andi Shyti , Lucas De Marchi , Rodrigo Vivi , Matt Roper , Jonathan Cavitt , Nirmoy Das , Shuicheng Lin Subject: [PATCH] drm/i915/guc: Fix missing enable of Wa_14019159160 on ARL Date: Thu, 8 Aug 2024 17:06:46 -0700 Message-ID: <20240809000646.1747507-1-John.C.Harrison@Intel.com> X-Mailer: git-send-email 2.46.0 MIME-Version: 1.0 Organization: Intel Corporation (UK) Ltd. - Co. Reg. #1134945 - Pipers Way, Swindon SN3 1RJ X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: John Harrison The previous update to enable the workaround on ARL only changed two out of three places where the w/a needs to be enabled. That meant the GuC side was operational but not the KMD side. And as the KMD side is the trigger, it meant the w/a was not actually active. So fix that. Fixes: 104bcfae57d8 ("drm/i915/arl: Enable Wa_14019159160 for ARL") Cc: John Harrison Cc: Vinay Belgaumkar Cc: Daniele Ceraolo Spurio Cc: Andi Shyti Cc: Lucas De Marchi Cc: Rodrigo Vivi Cc: Matt Roper Cc: Jonathan Cavitt Cc: Nirmoy Das Cc: Shuicheng Lin Signed-off-by: John Harrison Reviewed-by: Nirmoy Das Reviewed-by: Andi Shyti --- drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c index 9400d0eb682b2..3e1c3bc56daf2 100644 --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c @@ -4506,7 +4506,7 @@ static void guc_default_vfuncs(struct intel_engine_cs *engine) /* Wa_16019325821 */ /* Wa_14019159160 */ if ((engine->class == COMPUTE_CLASS || engine->class == RENDER_CLASS) && - IS_GFX_GT_IP_RANGE(engine->gt, IP_VER(12, 70), IP_VER(12, 71))) + IS_GFX_GT_IP_RANGE(engine->gt, IP_VER(12, 70), IP_VER(12, 74))) engine->flags |= I915_ENGINE_USES_WA_HOLD_SWITCHOUT; /*