| Message ID | 20240823023612.3027849-1-liyuesong@vivo.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v1] drm/i915/dp: Remove double assignment in intel_dp_compute_as_sdp() | expand |
On Fri, 23 Aug 2024, Yuesong Li <liyuesong@vivo.com> wrote: > cocci report a double assignment warning. 'as_sdp->duration_incr_ms' > was assigned twice in intel_dp_compute_as_sdp(). > > Signed-off-by: Yuesong Li <liyuesong@vivo.com> Reviewed-by: Jani Nikula <jani.nikula@intel.com> > --- > drivers/gpu/drm/i915/display/intel_dp.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c > index 6a0c7ae654f4..229c87be4402 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp.c > +++ b/drivers/gpu/drm/i915/display/intel_dp.c > @@ -2730,7 +2730,6 @@ static void intel_dp_compute_as_sdp(struct intel_dp *intel_dp, > as_sdp->sdp_type = DP_SDP_ADAPTIVE_SYNC; > as_sdp->length = 0x9; > as_sdp->duration_incr_ms = 0; > - as_sdp->duration_incr_ms = 0; > > if (crtc_state->cmrr.enable) { > as_sdp->mode = DP_AS_SDP_FAVT_TRR_REACHED;
Hi Yuesong, On Fri, Aug 23, 2024 at 10:36:12AM GMT, Yuesong Li wrote: > cocci report a double assignment warning. 'as_sdp->duration_incr_ms' > was assigned twice in intel_dp_compute_as_sdp(). > > Signed-off-by: Yuesong Li <liyuesong@vivo.com> reviewed and merged to drm-intel-next. Thanks, Andi
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c index 6a0c7ae654f4..229c87be4402 100644 --- a/drivers/gpu/drm/i915/display/intel_dp.c +++ b/drivers/gpu/drm/i915/display/intel_dp.c @@ -2730,7 +2730,6 @@ static void intel_dp_compute_as_sdp(struct intel_dp *intel_dp, as_sdp->sdp_type = DP_SDP_ADAPTIVE_SYNC; as_sdp->length = 0x9; as_sdp->duration_incr_ms = 0; - as_sdp->duration_incr_ms = 0; if (crtc_state->cmrr.enable) { as_sdp->mode = DP_AS_SDP_FAVT_TRR_REACHED;
cocci report a double assignment warning. 'as_sdp->duration_incr_ms' was assigned twice in intel_dp_compute_as_sdp(). Signed-off-by: Yuesong Li <liyuesong@vivo.com> --- drivers/gpu/drm/i915/display/intel_dp.c | 1 - 1 file changed, 1 deletion(-)