| Message ID | 20240823093925.9599-1-chenyufan@vivo.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v3] drm/imagination: Convert to use time_before macro | expand |
On 23/08/2024 10:39, Chen Yufan wrote: > Use time_*() macros instead of using > jiffies directly to handle overflow issues. > > Fixes: cc1aeedb98ad ("drm/imagination: Implement firmware infrastructure and META FW support") > Signed-off-by: Chen Yufan <chenyufan@vivo.com> Hi Chen, Apologies for the slow reply – it's been a busy week for me. I've added my R-b and applied your patch to drm-misc-next as: 7a5115ba1d69 ("drm/imagination: Convert to use time_before macro") Thanks again! Matt > --- > The modifications made compared to the previous version are as follows: > 1. Change the prefix of subject. > 2. Correct fixes. > 3. Drop the cast of RESERVE_SLOT_TIMEOUT. > --- > drivers/gpu/drm/imagination/pvr_ccb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/imagination/pvr_ccb.c b/drivers/gpu/drm/imagination/pvr_ccb.c > index 4deeac7ed40a..b7d5f9ca3ca6 100644 > --- a/drivers/gpu/drm/imagination/pvr_ccb.c > +++ b/drivers/gpu/drm/imagination/pvr_ccb.c > @@ -321,7 +321,7 @@ static int pvr_kccb_reserve_slot_sync(struct pvr_device *pvr_dev) > bool reserved = false; > u32 retries = 0; > > - while ((jiffies - start_timestamp) < (u32)RESERVE_SLOT_TIMEOUT || > + while (time_before(jiffies, start_timestamp + RESERVE_SLOT_TIMEOUT) || > retries < RESERVE_SLOT_MIN_RETRIES) { > reserved = pvr_kccb_try_reserve_slot(pvr_dev); > if (reserved)
diff --git a/drivers/gpu/drm/imagination/pvr_ccb.c b/drivers/gpu/drm/imagination/pvr_ccb.c index 4deeac7ed40a..b7d5f9ca3ca6 100644 --- a/drivers/gpu/drm/imagination/pvr_ccb.c +++ b/drivers/gpu/drm/imagination/pvr_ccb.c @@ -321,7 +321,7 @@ static int pvr_kccb_reserve_slot_sync(struct pvr_device *pvr_dev) bool reserved = false; u32 retries = 0; - while ((jiffies - start_timestamp) < (u32)RESERVE_SLOT_TIMEOUT || + while (time_before(jiffies, start_timestamp + RESERVE_SLOT_TIMEOUT) || retries < RESERVE_SLOT_MIN_RETRIES) { reserved = pvr_kccb_try_reserve_slot(pvr_dev); if (reserved)
Use time_*() macros instead of using jiffies directly to handle overflow issues. Fixes: cc1aeedb98ad ("drm/imagination: Implement firmware infrastructure and META FW support") Signed-off-by: Chen Yufan <chenyufan@vivo.com> --- The modifications made compared to the previous version are as follows: 1. Change the prefix of subject. 2. Correct fixes. 3. Drop the cast of RESERVE_SLOT_TIMEOUT. --- drivers/gpu/drm/imagination/pvr_ccb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)