| Message ID | 20240823140308.384988-1-derek.foreman@collabora.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/connector: hdmi: Increase HDMI_MAX_INFOFRAME_SIZE to 30 | expand |
On Fri, 23 Aug 2024, Derek Foreman <derek.foreman@collabora.com> wrote: > The DRM infoframe is 26 bytes, with a 4 byte header this gives us 30. The > current limit of 29 prevents us from writing DRM infoframes. Some more details would be useful. Which infoframe, etc. BR, Jani. > > Signed-off-by: Derek Foreman <derek.foreman@collabora.com> > --- > drivers/gpu/drm/display/drm_hdmi_state_helper.c | 2 +- > drivers/gpu/drm/drm_debugfs.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/display/drm_hdmi_state_helper.c b/drivers/gpu/drm/display/drm_hdmi_state_helper.c > index 7854820089ec..cc7747d33fdf 100644 > --- a/drivers/gpu/drm/display/drm_hdmi_state_helper.c > +++ b/drivers/gpu/drm/display/drm_hdmi_state_helper.c > @@ -521,7 +521,7 @@ int drm_atomic_helper_connector_hdmi_check(struct drm_connector *connector, > } > EXPORT_SYMBOL(drm_atomic_helper_connector_hdmi_check); > > -#define HDMI_MAX_INFOFRAME_SIZE 29 > +#define HDMI_MAX_INFOFRAME_SIZE 30 > > static int clear_device_infoframe(struct drm_connector *connector, > enum hdmi_infoframe_type type) > diff --git a/drivers/gpu/drm/drm_debugfs.c b/drivers/gpu/drm/drm_debugfs.c > index 6b239a24f1df..3439fd65275a 100644 > --- a/drivers/gpu/drm/drm_debugfs.c > +++ b/drivers/gpu/drm/drm_debugfs.c > @@ -520,7 +520,7 @@ static const struct file_operations drm_connector_fops = { > .write = connector_write > }; > > -#define HDMI_MAX_INFOFRAME_SIZE 29 > +#define HDMI_MAX_INFOFRAME_SIZE 30 > > static ssize_t > audio_infoframe_read(struct file *filp, char __user *ubuf, size_t count, loff_t *ppos)
diff --git a/drivers/gpu/drm/display/drm_hdmi_state_helper.c b/drivers/gpu/drm/display/drm_hdmi_state_helper.c index 7854820089ec..cc7747d33fdf 100644 --- a/drivers/gpu/drm/display/drm_hdmi_state_helper.c +++ b/drivers/gpu/drm/display/drm_hdmi_state_helper.c @@ -521,7 +521,7 @@ int drm_atomic_helper_connector_hdmi_check(struct drm_connector *connector, } EXPORT_SYMBOL(drm_atomic_helper_connector_hdmi_check); -#define HDMI_MAX_INFOFRAME_SIZE 29 +#define HDMI_MAX_INFOFRAME_SIZE 30 static int clear_device_infoframe(struct drm_connector *connector, enum hdmi_infoframe_type type) diff --git a/drivers/gpu/drm/drm_debugfs.c b/drivers/gpu/drm/drm_debugfs.c index 6b239a24f1df..3439fd65275a 100644 --- a/drivers/gpu/drm/drm_debugfs.c +++ b/drivers/gpu/drm/drm_debugfs.c @@ -520,7 +520,7 @@ static const struct file_operations drm_connector_fops = { .write = connector_write }; -#define HDMI_MAX_INFOFRAME_SIZE 29 +#define HDMI_MAX_INFOFRAME_SIZE 30 static ssize_t audio_infoframe_read(struct file *filp, char __user *ubuf, size_t count, loff_t *ppos)
The DRM infoframe is 26 bytes, with a 4 byte header this gives us 30. The current limit of 29 prevents us from writing DRM infoframes. Signed-off-by: Derek Foreman <derek.foreman@collabora.com> --- drivers/gpu/drm/display/drm_hdmi_state_helper.c | 2 +- drivers/gpu/drm/drm_debugfs.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)