| Message ID | 20240823150057.56141-8-detlev.casanova@collabora.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add device tree for ArmSoM Sige 5 board | expand |
On Fri, Aug 23, 2024 at 10:52:34AM -0400, Detlev Casanova wrote: > The device is compatible with rk3588, so add an entry for the 2 > compatibles together. > > The rk3576 device has a power-domain that needs to be on for the eMMC to > be used. Add it as a requirement. > > Signed-off-by: Detlev Casanova <detlev.casanova@collabora.com> > --- > .../bindings/mmc/snps,dwcmshc-sdhci.yaml | 32 +++++++++++++------ > 1 file changed, 23 insertions(+), 9 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml b/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml > index 4d3031d9965f3..7d5e388587027 100644 > --- a/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml > +++ b/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml > @@ -12,16 +12,29 @@ maintainers: > > allOf: > - $ref: mmc-controller.yaml# > + - if: > + properties: > + compatible: > + contains: > + const: rockchip,rk3576-dwcmshc > + then: > + properties: > + power-domains: > + minItems: 1 Plaese move the allOf: after the required: block. It grows too much with such if:then: and that's not the most important part of binding we need to see first. With above change: Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml b/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml index 4d3031d9965f3..7d5e388587027 100644 --- a/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml +++ b/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml @@ -12,16 +12,29 @@ maintainers: allOf: - $ref: mmc-controller.yaml# + - if: + properties: + compatible: + contains: + const: rockchip,rk3576-dwcmshc + then: + properties: + power-domains: + minItems: 1 properties: compatible: - enum: - - rockchip,rk3568-dwcmshc - - rockchip,rk3588-dwcmshc - - snps,dwcmshc-sdhci - - sophgo,cv1800b-dwcmshc - - sophgo,sg2002-dwcmshc - - thead,th1520-dwcmshc + oneOf: + - items: + - const: rockchip,rk3576-dwcmshc + - const: rockchip,rk3588-dwcmshc + - enum: + - rockchip,rk3568-dwcmshc + - rockchip,rk3588-dwcmshc + - snps,dwcmshc-sdhci + - sophgo,cv1800b-dwcmshc + - sophgo,sg2002-dwcmshc + - thead,th1520-dwcmshc reg: maxItems: 1 @@ -38,7 +51,6 @@ properties: - description: block clock for rockchip specified - description: timer clock for rockchip specified - clock-names: minItems: 1 items: @@ -48,6 +60,9 @@ properties: - const: block - const: timer + power-domains: + maxItems: 1 + resets: maxItems: 5 @@ -63,7 +78,6 @@ properties: description: Specify the number of delay for tx sampling. $ref: /schemas/types.yaml#/definitions/uint8 - required: - compatible - reg
The device is compatible with rk3588, so add an entry for the 2 compatibles together. The rk3576 device has a power-domain that needs to be on for the eMMC to be used. Add it as a requirement. Signed-off-by: Detlev Casanova <detlev.casanova@collabora.com> --- .../bindings/mmc/snps,dwcmshc-sdhci.yaml | 32 +++++++++++++------ 1 file changed, 23 insertions(+), 9 deletions(-)