| Message ID | 20240825162300.417306-1-sui.jingfeng@linux.dev (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/etnaviv: Use unsigned type to count the number of pages | expand |
> > The drm_prime_pages_to_sg() function takes unsigned int argument to store > length of the page vector, and the type of struct drm_gem_object::size is > a size_t. The size of the object in CPU pages can not be negative, hence, > use unsigned variable to store the number of pages, instead of the signed > type. > > Signed-off-by: Sui Jingfeng <sui.jingfeng@linux.dev> Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com> > --- > drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c b/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c > index 3524b5811682..6b98200068e4 100644 > --- a/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c > +++ b/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c > @@ -17,7 +17,7 @@ static struct lock_class_key etnaviv_prime_lock_class; > struct sg_table *etnaviv_gem_prime_get_sg_table(struct drm_gem_object *obj) > { > struct etnaviv_gem_object *etnaviv_obj = to_etnaviv_bo(obj); > - int npages = obj->size >> PAGE_SHIFT; > + unsigned int npages = obj->size >> PAGE_SHIFT; > > if (WARN_ON(!etnaviv_obj->pages)) /* should have already pinned! */ > return ERR_PTR(-EINVAL); > -- > 2.34.1 >
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c b/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c index 3524b5811682..6b98200068e4 100644 --- a/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c +++ b/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c @@ -17,7 +17,7 @@ static struct lock_class_key etnaviv_prime_lock_class; struct sg_table *etnaviv_gem_prime_get_sg_table(struct drm_gem_object *obj) { struct etnaviv_gem_object *etnaviv_obj = to_etnaviv_bo(obj); - int npages = obj->size >> PAGE_SHIFT; + unsigned int npages = obj->size >> PAGE_SHIFT; if (WARN_ON(!etnaviv_obj->pages)) /* should have already pinned! */ return ERR_PTR(-EINVAL);
The drm_prime_pages_to_sg() function takes unsigned int argument to store length of the page vector, and the type of struct drm_gem_object::size is a size_t. The size of the object in CPU pages can not be negative, hence, use unsigned variable to store the number of pages, instead of the signed type. Signed-off-by: Sui Jingfeng <sui.jingfeng@linux.dev> --- drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)