| Message ID | 20240828084849.2527115-1-ruanjinjie@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [-next] drm/msm: Use devm_platform_ioremap_resource_byname() | expand |
On 8/28/2024 1:48 AM, Jinjie Ruan wrote: > platform_get_resource_byname() and devm_ioremap_resource() can be > replaced by devm_platform_ioremap_resource_byname(), which can > simplify the code logic a bit, No functional change here. > > Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com> > --- > drivers/gpu/drm/msm/msm_io_utils.c | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) > Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
On Wed, Aug 28, 2024 at 04:48:49PM GMT, Jinjie Ruan wrote: > platform_get_resource_byname() and devm_ioremap_resource() can be > replaced by devm_platform_ioremap_resource_byname(), which can > simplify the code logic a bit, No functional change here. NAK. platform_get_resource_byname gets mdss_pdev, while devm_ function uses pdev->dev. Passing mdss_pdev to devm_platform_ioremap_resource_byname() means that the resource will get lifetime management attached to the lifecycle of the other driver. > > Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com> > --- > drivers/gpu/drm/msm/msm_io_utils.c | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/msm/msm_io_utils.c b/drivers/gpu/drm/msm/msm_io_utils.c > index afedd61c3e28..6f7933f01ae6 100644 > --- a/drivers/gpu/drm/msm/msm_io_utils.c > +++ b/drivers/gpu/drm/msm/msm_io_utils.c > @@ -54,13 +54,7 @@ void __iomem *msm_ioremap_mdss(struct platform_device *mdss_pdev, > struct platform_device *pdev, > const char *name) > { > - struct resource *res; > - > - res = platform_get_resource_byname(mdss_pdev, IORESOURCE_MEM, name); > - if (!res) > - return ERR_PTR(-EINVAL); > - > - return devm_ioremap_resource(&pdev->dev, res); > + return devm_platform_ioremap_resource_byname(mdss_pdev, name); > } > > static void __iomem *_msm_ioremap(struct platform_device *pdev, const char *name, > -- > 2.34.1 >
diff --git a/drivers/gpu/drm/msm/msm_io_utils.c b/drivers/gpu/drm/msm/msm_io_utils.c index afedd61c3e28..6f7933f01ae6 100644 --- a/drivers/gpu/drm/msm/msm_io_utils.c +++ b/drivers/gpu/drm/msm/msm_io_utils.c @@ -54,13 +54,7 @@ void __iomem *msm_ioremap_mdss(struct platform_device *mdss_pdev, struct platform_device *pdev, const char *name) { - struct resource *res; - - res = platform_get_resource_byname(mdss_pdev, IORESOURCE_MEM, name); - if (!res) - return ERR_PTR(-EINVAL); - - return devm_ioremap_resource(&pdev->dev, res); + return devm_platform_ioremap_resource_byname(mdss_pdev, name); } static void __iomem *_msm_ioremap(struct platform_device *pdev, const char *name,
platform_get_resource_byname() and devm_ioremap_resource() can be replaced by devm_platform_ioremap_resource_byname(), which can simplify the code logic a bit, No functional change here. Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com> --- drivers/gpu/drm/msm/msm_io_utils.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-)