| Message ID | 20240830084456.77630-41-tzimmermann@suse.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm: Provide client setup helper and convert drivers | expand |
On Fri, 30 Aug 2024, Thomas Zimmermann wrote: > Call drm_client_setup_with-fourcc() to run the kernel's default client > setup for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > v2: > - use drm_client_setup_with_fourcc() > > Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> > Cc: Yannick Fertre <yannick.fertre@foss.st.com> > Cc: Raphael Gallais-Pou <raphael.gallais-pou@foss.st.com> > Cc: Philippe Cornu <philippe.cornu@foss.st.com> > Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com> > Cc: Alexandre Torgue <alexandre.torgue@foss.st.com> > Acked-by: Raphael Gallais-Pou <raphael.gallais-pou@foss.st.com> > Acked-by: Raphael Gallais-Pou <raphael.gallais-pou@foss.st.com> WARNING: Duplicate signature Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hi Am 30.08.24 um 11:22 schrieb Geert Uytterhoeven: > On Fri, 30 Aug 2024, Thomas Zimmermann wrote: >> Call drm_client_setup_with-fourcc() to run the kernel's default client >> setup for DRM. Set fbdev_probe in struct drm_driver, so that the client >> setup can start the common fbdev client. >> >> v2: >> - use drm_client_setup_with_fourcc() >> >> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> >> Cc: Yannick Fertre <yannick.fertre@foss.st.com> >> Cc: Raphael Gallais-Pou <raphael.gallais-pou@foss.st.com> >> Cc: Philippe Cornu <philippe.cornu@foss.st.com> >> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com> >> Cc: Alexandre Torgue <alexandre.torgue@foss.st.com> >> Acked-by: Raphael Gallais-Pou <raphael.gallais-pou@foss.st.com> >> Acked-by: Raphael Gallais-Pou <raphael.gallais-pou@foss.st.com> > > WARNING: Duplicate signature Interesting. Raphael gave a ack on v1 and v2 each. I re-imported v2 of the series from patchwork and it seems that it counted each ack independently. Best regards Thomas > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- > geert@linux-m68k.org > > In personal conversations with technical people, I call myself a > hacker. But > when I'm talking to journalists I just say "programmer" or something > like that. > -- Linus Torvalds
diff --git a/drivers/gpu/drm/stm/drv.c b/drivers/gpu/drm/stm/drv.c index e1232f74dfa5..fee274a60623 100644 --- a/drivers/gpu/drm/stm/drv.c +++ b/drivers/gpu/drm/stm/drv.c @@ -18,8 +18,10 @@ #include <drm/drm_aperture.h> #include <drm/drm_atomic.h> #include <drm/drm_atomic_helper.h> +#include <drm/drm_client_setup.h> #include <drm/drm_drv.h> #include <drm/drm_fbdev_dma.h> +#include <drm/drm_fourcc.h> #include <drm/drm_gem_dma_helper.h> #include <drm/drm_gem_framebuffer_helper.h> #include <drm/drm_module.h> @@ -66,6 +68,7 @@ static const struct drm_driver drv_driver = { .patchlevel = 0, .fops = &drv_driver_fops, DRM_GEM_DMA_DRIVER_OPS_WITH_DUMB_CREATE(stm_gem_dma_dumb_create), + DRM_FBDEV_DMA_DRIVER_OPS, }; static int drv_load(struct drm_device *ddev) @@ -206,7 +209,7 @@ static int stm_drm_platform_probe(struct platform_device *pdev) if (ret) goto err_unload; - drm_fbdev_dma_setup(ddev, 16); + drm_client_setup_with_fourcc(ddev, DRM_FORMAT_RGB565); return 0;