| Message ID | 20240831012803.3950100-4-lizetao1@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm: use clamp() instead of min(max()) | expand |
Pushed to drm-misc-next, thanks! On Sat, 2024-08-31 at 09:28 +0800, Li Zetao wrote: > When it needs to get a value within a certain interval, using clamp() > makes the code easier to understand than min(max()). > > Reviewed-by: Lyude Paul <lyude@redhat.com> > Signed-off-by: Li Zetao <lizetao1@huawei.com> > --- > v1 -> v2: Change the patch title prefix to drm/nouveau/volt > v1: https://lore.kernel.org/all/20240830012216.603623-4-lizetao1@huawei.com/ > > drivers/gpu/drm/nouveau/nvkm/subdev/volt/base.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/volt/base.c b/drivers/gpu/drm/nouveau/nvkm/subdev/volt/base.c > index a17a6dd8d3de..803b98df4858 100644 > --- a/drivers/gpu/drm/nouveau/nvkm/subdev/volt/base.c > +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/volt/base.c > @@ -142,7 +142,7 @@ nvkm_volt_map(struct nvkm_volt *volt, u8 id, u8 temp) > return -ENODEV; > } > > - result = min(max(result, (s64)info.min), (s64)info.max); > + result = clamp(result, (s64)info.min, (s64)info.max); > > if (info.link != 0xff) { > int ret = nvkm_volt_map(volt, info.link, temp);
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/volt/base.c b/drivers/gpu/drm/nouveau/nvkm/subdev/volt/base.c index a17a6dd8d3de..803b98df4858 100644 --- a/drivers/gpu/drm/nouveau/nvkm/subdev/volt/base.c +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/volt/base.c @@ -142,7 +142,7 @@ nvkm_volt_map(struct nvkm_volt *volt, u8 id, u8 temp) return -ENODEV; } - result = min(max(result, (s64)info.min), (s64)info.max); + result = clamp(result, (s64)info.min, (s64)info.max); if (info.link != 0xff) { int ret = nvkm_volt_map(volt, info.link, temp);