| Message ID | 20240903162729.1151134-1-festevam@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | dt-bindings: lcdif: Document the dmas/dma-names properties | expand |
On 9/3/24 6:27 PM, Fabio Estevam wrote: > From: Fabio Estevam <festevam@denx.de> > > i.MX28 has an RX DMA channel associated with the LCDIF controller. > > Document the 'dmas' and 'dma-names' properties to fix the following > dt-schema warnings: > > lcdif@80030000: 'dma-names', 'dmas' do not match any of the regexes: 'pinctrl-[0-9]+' > > Signed-off-by: Fabio Estevam <festevam@denx.de> > --- > .../bindings/display/fsl,lcdif.yaml | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > index 0681fc49aa1b..dd462abd61f8 100644 > --- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > +++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > @@ -50,6 +50,14 @@ properties: > - const: disp_axi > minItems: 1 > > + dmas: > + items: > + - description: DMA specifier for the RX DMA channel. > + > + dma-names: > + items: > + - const: rx > + > interrupts: > items: > - description: LCDIF DMA interrupt > @@ -156,6 +164,17 @@ allOf: > interrupts: > maxItems: 1 > > + - if: > + not: > + properties: > + compatible: > + contains: > + enum: > + - fsl,imx28-lcdif This also applies to MX23 , that one also has the support for command-mode LCDs which are then driven by pumping commands via DMA. I don't think Linux actually supports this mode of operation, but I do recall using it some long time ago on MX23.
Hi Marek, On Tue, Sep 3, 2024 at 1:51 PM Marek Vasut <marex@denx.de> wrote: > This also applies to MX23 , that one also has the support for > command-mode LCDs which are then driven by pumping commands via DMA. I > don't think Linux actually supports this mode of operation, but I do > recall using it some long time ago on MX23. I checked the i.MX23 Reference Manual and no LCDIF DMA entry is listed in either Table 10-1. APBH DMA Channel Assignments or Table 11-1. APBX DMA Channel Assignments.
On Tue, Sep 03, 2024 at 01:27:29PM -0300, Fabio Estevam wrote: > From: Fabio Estevam <festevam@denx.de> > > i.MX28 has an RX DMA channel associated with the LCDIF controller. > > Document the 'dmas' and 'dma-names' properties to fix the following > dt-schema warnings: > > lcdif@80030000: 'dma-names', 'dmas' do not match any of the regexes: 'pinctrl-[0-9]+' > > Signed-off-by: Fabio Estevam <festevam@denx.de> > --- > .../bindings/display/fsl,lcdif.yaml | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > index 0681fc49aa1b..dd462abd61f8 100644 > --- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > +++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > @@ -50,6 +50,14 @@ properties: > - const: disp_axi > minItems: 1 > > + dmas: > + items: > + - description: DMA specifier for the RX DMA channel. > + > + dma-names: > + items: > + - const: rx > + > interrupts: > items: > - description: LCDIF DMA interrupt > @@ -156,6 +164,17 @@ allOf: > interrupts: > maxItems: 1 > > + - if: > + not: > + properties: > + compatible: > + contains: > + enum: > + - fsl,imx28-lcdif > + then: > + properties: > + dmas: false > + dma-names: false Missing blank line. Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml index 0681fc49aa1b..dd462abd61f8 100644 --- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml +++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml @@ -50,6 +50,14 @@ properties: - const: disp_axi minItems: 1 + dmas: + items: + - description: DMA specifier for the RX DMA channel. + + dma-names: + items: + - const: rx + interrupts: items: - description: LCDIF DMA interrupt @@ -156,6 +164,17 @@ allOf: interrupts: maxItems: 1 + - if: + not: + properties: + compatible: + contains: + enum: + - fsl,imx28-lcdif + then: + properties: + dmas: false + dma-names: false examples: - | #include <dt-bindings/clock/imx6sx-clock.h>