| Message ID | 20240908133533.112894-1-minhuadotchen@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/panel: khadas-ts050: make ts050[v2]_panel_data static | expand |
On 08/09/2024 15:35, Min-Hua Chen wrote: > make ts050_panel_data and ts050v2_panel_data static because they > are only used in drivers/gpu/drm/panel/panel-khadas-ts050.c, > and fix the following sparse warnings: > > drivers/gpu/drm/panel/panel-khadas-ts050.c:620:32: > sparse: warning: symbol 'ts050_panel_data' was not declared. Should it be static? > drivers/gpu/drm/panel/panel-khadas-ts050.c:625:32: > sparse: warning: symbol 'ts050v2_panel_data' was not declared. Should it be static? > > No functional changes intended. > > Signed-off-by: Min-Hua Chen <minhuadotchen@gmail.com> > --- > drivers/gpu/drm/panel/panel-khadas-ts050.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-khadas-ts050.c b/drivers/gpu/drm/panel/panel-khadas-ts050.c > index 14932cb3defc..0e5e8e57bd1e 100644 > --- a/drivers/gpu/drm/panel/panel-khadas-ts050.c > +++ b/drivers/gpu/drm/panel/panel-khadas-ts050.c > @@ -617,12 +617,12 @@ static const struct khadas_ts050_panel_cmd ts050_init_code[] = { > {0xd4, {0x04}, 0x01}, /* RGBMIPICTRL: VSYNC front porch = 4 */ > }; > > -struct khadas_ts050_panel_data ts050_panel_data = { > +static struct khadas_ts050_panel_data ts050_panel_data = { > .init_code = (struct khadas_ts050_panel_cmd *)ts050_init_code, > .len = ARRAY_SIZE(ts050_init_code) > }; > > -struct khadas_ts050_panel_data ts050v2_panel_data = { > +static struct khadas_ts050_panel_data ts050v2_panel_data = { > .init_code = (struct khadas_ts050_panel_cmd *)ts050v2_init_code, > .len = ARRAY_SIZE(ts050v2_init_code) > }; Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Hi, On Sun, 08 Sep 2024 21:35:30 +0800, Min-Hua Chen wrote: > make ts050_panel_data and ts050v2_panel_data static because they > are only used in drivers/gpu/drm/panel/panel-khadas-ts050.c, > and fix the following sparse warnings: > > drivers/gpu/drm/panel/panel-khadas-ts050.c:620:32: > sparse: warning: symbol 'ts050_panel_data' was not declared. Should it be static? > drivers/gpu/drm/panel/panel-khadas-ts050.c:625:32: > sparse: warning: symbol 'ts050v2_panel_data' was not declared. Should it be static? > > [...] Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-next) [1/1] drm/panel: khadas-ts050: make ts050[v2]_panel_data static https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/d5acba46ebf5a4fd9ea9ae5121dd381ce85e94ff
diff --git a/drivers/gpu/drm/panel/panel-khadas-ts050.c b/drivers/gpu/drm/panel/panel-khadas-ts050.c index 14932cb3defc..0e5e8e57bd1e 100644 --- a/drivers/gpu/drm/panel/panel-khadas-ts050.c +++ b/drivers/gpu/drm/panel/panel-khadas-ts050.c @@ -617,12 +617,12 @@ static const struct khadas_ts050_panel_cmd ts050_init_code[] = { {0xd4, {0x04}, 0x01}, /* RGBMIPICTRL: VSYNC front porch = 4 */ }; -struct khadas_ts050_panel_data ts050_panel_data = { +static struct khadas_ts050_panel_data ts050_panel_data = { .init_code = (struct khadas_ts050_panel_cmd *)ts050_init_code, .len = ARRAY_SIZE(ts050_init_code) }; -struct khadas_ts050_panel_data ts050v2_panel_data = { +static struct khadas_ts050_panel_data ts050v2_panel_data = { .init_code = (struct khadas_ts050_panel_cmd *)ts050v2_init_code, .len = ARRAY_SIZE(ts050v2_init_code) };
make ts050_panel_data and ts050v2_panel_data static because they are only used in drivers/gpu/drm/panel/panel-khadas-ts050.c, and fix the following sparse warnings: drivers/gpu/drm/panel/panel-khadas-ts050.c:620:32: sparse: warning: symbol 'ts050_panel_data' was not declared. Should it be static? drivers/gpu/drm/panel/panel-khadas-ts050.c:625:32: sparse: warning: symbol 'ts050v2_panel_data' was not declared. Should it be static? No functional changes intended. Signed-off-by: Min-Hua Chen <minhuadotchen@gmail.com> --- drivers/gpu/drm/panel/panel-khadas-ts050.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)