Message ID | 20240909113633.595465-72-tzimmermann@suse.de (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | drm: Provide client setup helper and convert drivers | expand |
On Mon, Sep 9, 2024 at 7:37 AM Thomas Zimmermann <tzimmermann@suse.de> wrote: > > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> > Cc: Zack Rusin <zack.rusin@broadcom.com> > Cc: Broadcom internal kernel review list <bcm-kernel-feedback-list@broadcom.com> > Acked-by: Javier Martinez Canillas <javierm@redhat.com> Quick note: I love what you did with drm client and drm fbdev. Thanks a lot for that work! Reviewed-by: Zack Rusin <zack.rusin@broadcom.com> z
Hi Am 09.09.24 um 19:52 schrieb Zack Rusin: > On Mon, Sep 9, 2024 at 7:37 AM Thomas Zimmermann <tzimmermann@suse.de> wrote: >> Call drm_client_setup() to run the kernel's default client setup >> for DRM. Set fbdev_probe in struct drm_driver, so that the client >> setup can start the common fbdev client. >> >> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> >> Cc: Zack Rusin <zack.rusin@broadcom.com> >> Cc: Broadcom internal kernel review list <bcm-kernel-feedback-list@broadcom.com> >> Acked-by: Javier Martinez Canillas <javierm@redhat.com> > Quick note: I love what you did with drm client and drm fbdev. Thanks > a lot for that work! Thanks for the kind words. Noralf deserves his share of praise here, as he first implemented the client code. And Javier went through *a lot* of patches reviewing them. Once drm_client_setup() has been merged, I hope that there won't be any such large patch series. The rest of the work should be internal rework that doesn't touch the whole subsystem. Best regards Thomas > > Reviewed-by: Zack Rusin <zack.rusin@broadcom.com> > > z
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c index 50ad3105c16e..f9009f5a5aef 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c @@ -36,6 +36,7 @@ #include "ttm_object.h" #include <drm/drm_aperture.h> +#include <drm/drm_client_setup.h> #include <drm/drm_drv.h> #include <drm/drm_fbdev_ttm.h> #include <drm/drm_gem_ttm_helper.h> @@ -1628,6 +1629,8 @@ static const struct drm_driver driver = { .prime_handle_to_fd = vmw_prime_handle_to_fd, .gem_prime_import_sg_table = vmw_prime_import_sg_table, + DRM_FBDEV_TTM_DRIVER_OPS, + .fops = &vmwgfx_driver_fops, .name = VMWGFX_DRIVER_NAME, .desc = VMWGFX_DRIVER_DESC, @@ -1679,7 +1682,7 @@ static int vmw_probe(struct pci_dev *pdev, const struct pci_device_id *ent) vmw_fifo_resource_inc(vmw); vmw_svga_enable(vmw); - drm_fbdev_ttm_setup(&vmw->drm, 0); + drm_client_setup(&vmw->drm, NULL); vmw_debugfs_gem_init(vmw); vmw_debugfs_resource_managers_init(vmw);