| Message ID | 20240909171937.51550-6-tursulin@igalia.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | DRM scheduler fixes, or not, or incorrect kind | expand |
Am 09.09.24 um 19:19 schrieb Tvrtko Ursulin: > From: Tvrtko Ursulin <tvrtko.ursulin@igalia.com> > > It does not seem there is a need to set the current entity in FIFO mode > since ot only serves as being a "cursor" in round-robin mode. Even if > scheduling mode is changed at runtime the change in behaviour is simply > to restart from the first entity, instead of continuing in RR mode from > where FIFO left it, and that sounds completely fine. > > Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@igalia.com> > Cc: Christian König <christian.koenig@amd.com> > Cc: Alex Deucher <alexander.deucher@amd.com> > Cc: Luben Tuikov <ltuikov89@gmail.com> > Cc: Matthew Brost <matthew.brost@intel.com> > Cc: Philipp Stanner <pstanner@redhat.com> Acked-by: Christian König <christian.koenig@amd.com> > --- > drivers/gpu/drm/scheduler/sched_main.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_main.c > index 10abbcefe9d8..54c5fe7a7d1d 100644 > --- a/drivers/gpu/drm/scheduler/sched_main.c > +++ b/drivers/gpu/drm/scheduler/sched_main.c > @@ -356,7 +356,6 @@ drm_sched_rq_select_entity_fifo(struct drm_gpu_scheduler *sched, > return ERR_PTR(-ENOSPC); > } > > - rq->current_entity = entity; > reinit_completion(&entity->entity_idle); > break; > }
On Mon, 2024-09-09 at 18:19 +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin <tvrtko.ursulin@igalia.com> > > It does not seem there is a need to set the current entity in FIFO > mode > since ot only serves as being a "cursor" in round-robin mode. Even if > scheduling mode is changed at runtime the change in behaviour is > simply > to restart from the first entity, instead of continuing in RR mode > from > where FIFO left it, and that sounds completely fine. > > Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@igalia.com> I went through the code and agree that this looks good. Reviewed-by: Philipp Stanner <pstanner@redhat.com> > Cc: Christian König <christian.koenig@amd.com> > Cc: Alex Deucher <alexander.deucher@amd.com> > Cc: Luben Tuikov <ltuikov89@gmail.com> > Cc: Matthew Brost <matthew.brost@intel.com> > Cc: Philipp Stanner <pstanner@redhat.com> > --- > drivers/gpu/drm/scheduler/sched_main.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/scheduler/sched_main.c > b/drivers/gpu/drm/scheduler/sched_main.c > index 10abbcefe9d8..54c5fe7a7d1d 100644 > --- a/drivers/gpu/drm/scheduler/sched_main.c > +++ b/drivers/gpu/drm/scheduler/sched_main.c > @@ -356,7 +356,6 @@ drm_sched_rq_select_entity_fifo(struct > drm_gpu_scheduler *sched, > return ERR_PTR(-ENOSPC); > } > > - rq->current_entity = entity; > reinit_completion(&entity->entity_idle); > break; > }
diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_main.c index 10abbcefe9d8..54c5fe7a7d1d 100644 --- a/drivers/gpu/drm/scheduler/sched_main.c +++ b/drivers/gpu/drm/scheduler/sched_main.c @@ -356,7 +356,6 @@ drm_sched_rq_select_entity_fifo(struct drm_gpu_scheduler *sched, return ERR_PTR(-ENOSPC); } - rq->current_entity = entity; reinit_completion(&entity->entity_idle); break; }