| Message ID | 20240913060254.26678-1-jiapeng.chong@linux.alibaba.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [v3,-next] drm/xe/irq: Remove unneeded semicolon | expand |
On 13-09-2024 11:32, Jiapeng Chong wrote: > Remove unnecessary semicolon in pick_engine_gt(). > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8757 LGTM Reviewed-by: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com> > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> > --- > Changes in v3: > -Amend the submission information to "Remove unnecessary semicolon in pick_engine_gt()". > > drivers/gpu/drm/xe/xe_irq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/xe/xe_irq.c b/drivers/gpu/drm/xe/xe_irq.c > index 07577b418205..e501002e8a04 100644 > --- a/drivers/gpu/drm/xe/xe_irq.c > +++ b/drivers/gpu/drm/xe/xe_irq.c > @@ -280,7 +280,7 @@ static struct xe_gt *pick_engine_gt(struct xe_tile *tile, > return tile->media_gt; > default: > break; > - }; > + } > fallthrough; > default: > return tile->primary_gt;
On Fri, Sep 13, 2024 at 11:53:05AM +0530, Ghimiray, Himal Prasad wrote: > > > On 13-09-2024 11:32, Jiapeng Chong wrote: > > Remove unnecessary semicolon in pick_engine_gt(). > > > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8757 > > LGTM > Reviewed-by: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com> pushed to drm-xe-next Thanks, Rodrigo. > > > > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> > > --- > > Changes in v3: > > -Amend the submission information to "Remove unnecessary semicolon in pick_engine_gt()". > > > > drivers/gpu/drm/xe/xe_irq.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/xe/xe_irq.c b/drivers/gpu/drm/xe/xe_irq.c > > index 07577b418205..e501002e8a04 100644 > > --- a/drivers/gpu/drm/xe/xe_irq.c > > +++ b/drivers/gpu/drm/xe/xe_irq.c > > @@ -280,7 +280,7 @@ static struct xe_gt *pick_engine_gt(struct xe_tile *tile, > > return tile->media_gt; > > default: > > break; > > - }; > > + } > > fallthrough; > > default: > > return tile->primary_gt;
diff --git a/drivers/gpu/drm/xe/xe_irq.c b/drivers/gpu/drm/xe/xe_irq.c index 07577b418205..e501002e8a04 100644 --- a/drivers/gpu/drm/xe/xe_irq.c +++ b/drivers/gpu/drm/xe/xe_irq.c @@ -280,7 +280,7 @@ static struct xe_gt *pick_engine_gt(struct xe_tile *tile, return tile->media_gt; default: break; - }; + } fallthrough; default: return tile->primary_gt;
Remove unnecessary semicolon in pick_engine_gt(). Reported-by: Abaci Robot <abaci@linux.alibaba.com> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8757 Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> --- Changes in v3: -Amend the submission information to "Remove unnecessary semicolon in pick_engine_gt()". drivers/gpu/drm/xe/xe_irq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)