diff mbox series

[2/2] drm/i915/gt: Fixed an typo

Message ID 20240914013146.65757-1-zhanghe9702@163.com (mailing list archive)
State New, archived
Headers show
Series drm/i915/gt: Fixed an typo | expand

Commit Message

Zhang He Sept. 14, 2024, 1:31 a.m. UTC
column header should be GPU, not CPU

---
ChangeLog:
    v1: use correct name as Author and Signer
    v2: change one line in drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c,
        LLC's information header from "Effective CPU freq" to "Effective GPU freq"

Signed-off-by: Zhang He <zhanghe9702@163.com>
---
 drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Andi Shyti Sept. 16, 2024, 8:57 a.m. UTC | #1
Hi Zhang He,

I merged your previous patch so that you don't need to resend it
anymore.

I already asked you not to resend it in the past version. Please,
read carefully the comments you receive.

I repeat: add the versioning. When you do:

   git format patch ...

you get:

   [PATCH 1/1] drm/....

if you do

   git format patch -v 2 ...

you get:

   [PATCH v2 1/1] drm/....

This is what I asked you to do.

The 1/1 or 2/2 is the patch counter for multi patch series, not
the version. The version is given by "-v 2" from the git
format-patch command.

Please read the SubmittingPatches document, it's essential for
sending patches.

On Sat, Sep 14, 2024 at 09:31:46AM GMT, Zhang He wrote:
> column header should be GPU, not CPU
> 
> ---
> ChangeLog:
>     v1: use correct name as Author and Signer
>     v2: change one line in drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c,
>         LLC's information header from "Effective CPU freq" to "Effective GPU freq"

Good that the changelog is here. The v2, though, is not a
changelog, but a description.

> Signed-off-by: Zhang He <zhanghe9702@163.com>

The signature goes above the "---" section, otherwise it doesn't
show up when I apply the patch.

Thanks for your patch,
Andi
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c b/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c
index 8d08b38874ef..b635aa2820d9 100644
--- a/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c
+++ b/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c
@@ -431,7 +431,7 @@  static int llc_show(struct seq_file *m, void *data)
 		max_gpu_freq /= GEN9_FREQ_SCALER;
 	}
 
-	seq_puts(m, "GPU freq (MHz)\tEffective CPU freq (MHz)\tEffective Ring freq (MHz)\n");
+	seq_puts(m, "GPU freq (MHz)\tEffective GPU freq (MHz)\tEffective Ring freq (MHz)\n");
 
 	wakeref = intel_runtime_pm_get(gt->uncore->rpm);
 	for (gpu_freq = min_gpu_freq; gpu_freq <= max_gpu_freq; gpu_freq++) {