| Message ID | 20240919091548.430285-2-manikandan.m@microchip.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2,1/2] dt-bindings: display: panel-simple: Document support for Microchip AC69T88A | expand |
On Thu, Sep 19, 2024 at 02:45:48PM GMT, Manikandan Muralidharan wrote: > Add support for Microchip AC69T88A 5 inch TFT LCD 800x480 > Display module with LVDS interface.The panel uses the Sitronix > ST7262 800x480 Display driver AC69T88A seems to be a module name, rather than a panel name. What is the actual panel name present on this module? > > Signed-off-by: Manikandan Muralidharan <manikandan.m@microchip.com> > Signed-off-by: Dharma Balasubiramani <dharma.b@microchip.com> > --- > changes in v2: > - replace microchip,ac69t88a-lvds-panel with > microchip,ac69t88a > --- > drivers/gpu/drm/panel/panel-simple.c | 28 ++++++++++++++++++++++++++++ > 1 file changed, 28 insertions(+) >
On 20/09/24 9:13 pm, Dmitry Baryshkov wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On Thu, Sep 19, 2024 at 02:45:48PM GMT, Manikandan Muralidharan wrote: >> Add support for Microchip AC69T88A 5 inch TFT LCD 800x480 >> Display module with LVDS interface.The panel uses the Sitronix >> ST7262 800x480 Display driver > > AC69T88A seems to be a module name, rather than a panel name. What is > the actual panel name present on this module? Both names, "Microchip AC69T88A" and "MPU32-LVDS-DISPLAY-WVGA" are present on the display module > >> >> Signed-off-by: Manikandan Muralidharan <manikandan.m@microchip.com> >> Signed-off-by: Dharma Balasubiramani <dharma.b@microchip.com> >> --- >> changes in v2: >> - replace microchip,ac69t88a-lvds-panel with >> microchip,ac69t88a >> --- >> drivers/gpu/drm/panel/panel-simple.c | 28 ++++++++++++++++++++++++++++ >> 1 file changed, 28 insertions(+) >> > > -- > With best wishes > Dmitry
On Mon, Sep 23, 2024 at 05:50:22AM GMT, Manikandan.M@microchip.com wrote: > On 20/09/24 9:13 pm, Dmitry Baryshkov wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > > > On Thu, Sep 19, 2024 at 02:45:48PM GMT, Manikandan Muralidharan wrote: > >> Add support for Microchip AC69T88A 5 inch TFT LCD 800x480 > >> Display module with LVDS interface.The panel uses the Sitronix > >> ST7262 800x480 Display driver > > > > AC69T88A seems to be a module name, rather than a panel name. What is > > the actual panel name present on this module? > Both names, "Microchip AC69T88A" and "MPU32-LVDS-DISPLAY-WVGA" are > present on the display module Which panel was used for the module? I don't think that Microchip produces LVDS panels. > > > >> > >> Signed-off-by: Manikandan Muralidharan <manikandan.m@microchip.com> > >> Signed-off-by: Dharma Balasubiramani <dharma.b@microchip.com> > >> --- > >> changes in v2: > >> - replace microchip,ac69t88a-lvds-panel with > >> microchip,ac69t88a > >> --- > >> drivers/gpu/drm/panel/panel-simple.c | 28 ++++++++++++++++++++++++++++ > >> 1 file changed, 28 insertions(+) > >> > > > > -- > > With best wishes > > Dmitry > > -- > Thanks and Regards, > Manikandan M. >
On 23/09/24 11:37 am, Dmitry Baryshkov wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On Mon, Sep 23, 2024 at 05:50:22AM GMT, Manikandan.M@microchip.com wrote: >> On 20/09/24 9:13 pm, Dmitry Baryshkov wrote: >>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe >>> >>> On Thu, Sep 19, 2024 at 02:45:48PM GMT, Manikandan Muralidharan wrote: >>>> Add support for Microchip AC69T88A 5 inch TFT LCD 800x480 >>>> Display module with LVDS interface.The panel uses the Sitronix >>>> ST7262 800x480 Display driver >>> >>> AC69T88A seems to be a module name, rather than a panel name. What is >>> the actual panel name present on this module? >> Both names, "Microchip AC69T88A" and "MPU32-LVDS-DISPLAY-WVGA" are >> present on the display module > > Which panel was used for the module? I don't think that Microchip > produces LVDS panels. Its a new LVDS display from Microchip that uses Sitronix ST7262 TFT LCD driver https://www.crystalfontz.com/controllers/datasheet-viewer.php?id=486 > >>> >>>> >>>> Signed-off-by: Manikandan Muralidharan <manikandan.m@microchip.com> >>>> Signed-off-by: Dharma Balasubiramani <dharma.b@microchip.com> >>>> --- >>>> changes in v2: >>>> - replace microchip,ac69t88a-lvds-panel with >>>> microchip,ac69t88a >>>> --- >>>> drivers/gpu/drm/panel/panel-simple.c | 28 ++++++++++++++++++++++++++++ >>>> 1 file changed, 28 insertions(+) >>>> >>> >>> -- >>> With best wishes >>> Dmitry >> >> -- >> Thanks and Regards, >> Manikandan M. >> > > -- > With best wishes > Dmitry
On Thu, Sep 26, 2024 at 08:17:09AM GMT, Manikandan.M@microchip.com wrote: > On 23/09/24 11:37 am, Dmitry Baryshkov wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > > > On Mon, Sep 23, 2024 at 05:50:22AM GMT, Manikandan.M@microchip.com wrote: > >> On 20/09/24 9:13 pm, Dmitry Baryshkov wrote: > >>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > >>> > >>> On Thu, Sep 19, 2024 at 02:45:48PM GMT, Manikandan Muralidharan wrote: > >>>> Add support for Microchip AC69T88A 5 inch TFT LCD 800x480 > >>>> Display module with LVDS interface.The panel uses the Sitronix > >>>> ST7262 800x480 Display driver > >>> > >>> AC69T88A seems to be a module name, rather than a panel name. What is > >>> the actual panel name present on this module? > >> Both names, "Microchip AC69T88A" and "MPU32-LVDS-DISPLAY-WVGA" are > >> present on the display module > > > > Which panel was used for the module? I don't think that Microchip > > produces LVDS panels. > Its a new LVDS display from Microchip that uses Sitronix ST7262 TFT LCD > driver > > https://www.crystalfontz.com/controllers/datasheet-viewer.php?id=486 Ok. Anyway if somebody ends up looking for the panel, they'll probably find the module and vice versa. Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
On Thu, Sep 26, 2024 at 04:32:59PM GMT, Dmitry Baryshkov wrote: > On Thu, Sep 26, 2024 at 08:17:09AM GMT, Manikandan.M@microchip.com wrote: > > On 23/09/24 11:37 am, Dmitry Baryshkov wrote: > > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > > > > > On Mon, Sep 23, 2024 at 05:50:22AM GMT, Manikandan.M@microchip.com wrote: > > >> On 20/09/24 9:13 pm, Dmitry Baryshkov wrote: > > >>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > >>> > > >>> On Thu, Sep 19, 2024 at 02:45:48PM GMT, Manikandan Muralidharan wrote: > > >>>> Add support for Microchip AC69T88A 5 inch TFT LCD 800x480 > > >>>> Display module with LVDS interface.The panel uses the Sitronix > > >>>> ST7262 800x480 Display driver > > >>> > > >>> AC69T88A seems to be a module name, rather than a panel name. What is > > >>> the actual panel name present on this module? > > >> Both names, "Microchip AC69T88A" and "MPU32-LVDS-DISPLAY-WVGA" are > > >> present on the display module > > > > > > Which panel was used for the module? I don't think that Microchip > > > produces LVDS panels. > > Its a new LVDS display from Microchip that uses Sitronix ST7262 TFT LCD > > driver > > > > https://www.crystalfontz.com/controllers/datasheet-viewer.php?id=486 > > Ok. Anyway if somebody ends up looking for the panel, they'll probably > find the module and vice versa. > > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Given that aside from that mail, the module name isn't mentionned anywhere, I'm not sure they would. The way we usually deal with controllers is to have a separate driver for panels based on that controller, even more so since that controller seems to be able to affect the display. Maxime
On Thu, Sep 26, 2024 at 03:58:11PM GMT, Maxime Ripard wrote: > On Thu, Sep 26, 2024 at 04:32:59PM GMT, Dmitry Baryshkov wrote: > > On Thu, Sep 26, 2024 at 08:17:09AM GMT, Manikandan.M@microchip.com wrote: > > > On 23/09/24 11:37 am, Dmitry Baryshkov wrote: > > > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > > > > > > > On Mon, Sep 23, 2024 at 05:50:22AM GMT, Manikandan.M@microchip.com wrote: > > > >> On 20/09/24 9:13 pm, Dmitry Baryshkov wrote: > > > >>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > > >>> > > > >>> On Thu, Sep 19, 2024 at 02:45:48PM GMT, Manikandan Muralidharan wrote: > > > >>>> Add support for Microchip AC69T88A 5 inch TFT LCD 800x480 > > > >>>> Display module with LVDS interface.The panel uses the Sitronix > > > >>>> ST7262 800x480 Display driver > > > >>> > > > >>> AC69T88A seems to be a module name, rather than a panel name. What is > > > >>> the actual panel name present on this module? > > > >> Both names, "Microchip AC69T88A" and "MPU32-LVDS-DISPLAY-WVGA" are > > > >> present on the display module > > > > > > > > Which panel was used for the module? I don't think that Microchip > > > > produces LVDS panels. > > > Its a new LVDS display from Microchip that uses Sitronix ST7262 TFT LCD > > > driver > > > > > > https://www.crystalfontz.com/controllers/datasheet-viewer.php?id=486 > > > > Ok. Anyway if somebody ends up looking for the panel, they'll probably > > find the module and vice versa. > > > > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > Given that aside from that mail, the module name isn't mentionned > anywhere, I'm not sure they would. > > The way we usually deal with controllers is to have a separate driver > for panels based on that controller, even more so since that controller > seems to be able to affect the display. But in this case it's panel-simple, no special driver for the controller. From my understanding the AC69T88A is the module name (at least the datasheet uses that name). The on-board EEPROM also carries that name and the name of the controller.
On 27/09/24 4:51 am, Dmitry Baryshkov wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On Thu, Sep 26, 2024 at 03:58:11PM GMT, Maxime Ripard wrote: >> On Thu, Sep 26, 2024 at 04:32:59PM GMT, Dmitry Baryshkov wrote: >>> On Thu, Sep 26, 2024 at 08:17:09AM GMT, Manikandan.M@microchip.com wrote: >>>> On 23/09/24 11:37 am, Dmitry Baryshkov wrote: >>>>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe >>>>> >>>>> On Mon, Sep 23, 2024 at 05:50:22AM GMT, Manikandan.M@microchip.com wrote: >>>>>> On 20/09/24 9:13 pm, Dmitry Baryshkov wrote: >>>>>>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe >>>>>>> >>>>>>> On Thu, Sep 19, 2024 at 02:45:48PM GMT, Manikandan Muralidharan wrote: >>>>>>>> Add support for Microchip AC69T88A 5 inch TFT LCD 800x480 >>>>>>>> Display module with LVDS interface.The panel uses the Sitronix >>>>>>>> ST7262 800x480 Display driver >>>>>>> >>>>>>> AC69T88A seems to be a module name, rather than a panel name. What is >>>>>>> the actual panel name present on this module? >>>>>> Both names, "Microchip AC69T88A" and "MPU32-LVDS-DISPLAY-WVGA" are >>>>>> present on the display module >>>>> >>>>> Which panel was used for the module? I don't think that Microchip >>>>> produces LVDS panels. >>>> Its a new LVDS display from Microchip that uses Sitronix ST7262 TFT LCD >>>> driver >>>> >>>> https://www.crystalfontz.com/controllers/datasheet-viewer.php?id=486 >>> >>> Ok. Anyway if somebody ends up looking for the panel, they'll probably >>> find the module and vice versa. >>> >>> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> >> >> Given that aside from that mail, the module name isn't mentionned >> anywhere, I'm not sure they would. >> >> The way we usually deal with controllers is to have a separate driver >> for panels based on that controller, even more so since that controller >> seems to be able to affect the display. > > But in this case it's panel-simple, no special driver for the > controller. From my understanding the AC69T88A is the module name (at > least the datasheet uses that name). The on-board EEPROM also carries > that name and the name of the controller. Yes, as per the proposed on-board EEPROM spec, it holds the module name and the LCD driver used. > > -- > With best wishes > Dmitry
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 86735430462f..06381c628209 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -4565,6 +4565,31 @@ static const struct panel_desc yes_optoelectronics_ytc700tlag_05_201c = { .connector_type = DRM_MODE_CONNECTOR_LVDS, }; +static const struct drm_display_mode mchp_ac69t88a_mode = { + .clock = 25000, + .hdisplay = 800, + .hsync_start = 800 + 88, + .hsync_end = 800 + 88 + 5, + .htotal = 800 + 88 + 5 + 40, + .vdisplay = 480, + .vsync_start = 480 + 23, + .vsync_end = 480 + 23 + 5, + .vtotal = 480 + 23 + 5 + 1, +}; + +static const struct panel_desc mchp_ac69t88a = { + .modes = &mchp_ac69t88a_mode, + .num_modes = 1, + .bpc = 8, + .size = { + .width = 108, + .height = 65, + }, + .bus_flags = DRM_BUS_FLAG_DE_HIGH, + .bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_JEIDA, + .connector_type = DRM_MODE_CONNECTOR_LVDS, +}; + static const struct drm_display_mode arm_rtsm_mode[] = { { .clock = 65000, @@ -5048,6 +5073,9 @@ static const struct of_device_id platform_of_match[] = { }, { .compatible = "yes-optoelectronics,ytc700tlag-05-201c", .data = &yes_optoelectronics_ytc700tlag_05_201c, + }, { + .compatible = "microchip,ac69t88a", + .data = &mchp_ac69t88a, }, { /* Must be the last entry */ .compatible = "panel-dpi",