From patchwork Fri Sep 20 03:19:56 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Harrison X-Patchwork-Id: 13808089 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 97D0CCF58C3 for ; Fri, 20 Sep 2024 03:20:18 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 22E5210E786; Fri, 20 Sep 2024 03:20:10 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="hrDsqoSN"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) by gabe.freedesktop.org (Postfix) with ESMTPS id 05C1010E77B; Fri, 20 Sep 2024 03:20:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1726802408; x=1758338408; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=HZeQs53wm6ed54JkpA6N1W85jW5iKCuP6XPXOUbb8nw=; b=hrDsqoSNtGS/nPfe70fsSSmAfZ3+VhTZvoINL6TYLgBcL1WLgsmIFJ33 08mmIOSFBIcdUipeuG0ob0GRMP2JWXlAGRqeBuMXiRs0Wuzbq5+HXwD2T LKMKv4X5uxOg1jNC/Sm6q0/3csJKnqtyJUuhmN6mE2MGpDS13p9KXJJ3s spFFdqTN3uTtMqmJQwG+PaYzGNGkgURNGZHRDUSyFRncvERj64dy3tzUK DqAY14w5Z1mi9+xIUfcGCRHMti2GQCDJLOiz2xSx44E1nJEZ0rCXLSo+2 WJOxdKz5DSuv4ivG8uKOtleWu64fE/+oqD6m2GWNHu8pzw6IqiIlPQ0gH A==; X-CSE-ConnectionGUID: EGB1lWYVREyzzYL/k8zv7Q== X-CSE-MsgGUID: ypQamg57QLG7zKqwYVkL2w== X-IronPort-AV: E=McAfee;i="6700,10204,11200"; a="25269797" X-IronPort-AV: E=Sophos;i="6.10,243,1719903600"; d="scan'208";a="25269797" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Sep 2024 20:20:07 -0700 X-CSE-ConnectionGUID: 2OtUVmhJRTm8SXq58GXczg== X-CSE-MsgGUID: yzS07JVOSsmUhjbD2MRlUA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,243,1719903600"; d="scan'208";a="69746170" Received: from relo-linux-5.jf.intel.com ([10.165.21.152]) by fmviesa007.fm.intel.com with ESMTP; 19 Sep 2024 20:20:07 -0700 From: John.C.Harrison@Intel.com To: Intel-GFX@Lists.FreeDesktop.Org Cc: DRI-Devel@Lists.FreeDesktop.Org, John Harrison , Michal Wajdeczko , Julia Filipchuk Subject: [PATCH v8 01/11] drm/xe/guc: Remove spurious line feed in debug print Date: Thu, 19 Sep 2024 20:19:56 -0700 Message-ID: <20240920032007.629624-2-John.C.Harrison@Intel.com> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20240920032007.629624-1-John.C.Harrison@Intel.com> References: <20240920032007.629624-1-John.C.Harrison@Intel.com> MIME-Version: 1.0 Organization: Intel Corporation (UK) Ltd. - Co. Reg. #1134945 - Pipers Way, Swindon SN3 1RJ X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: John Harrison Including line feeds at the start of a debug print messes up the output when sent to dmesg. The break appears between all the useful prefix information and the actual string being printed. In this case, each block of data has a very clear start line and an extra delimeter is really not necessary. So don't do it. v2: Fix typo in commit message (review feedback from Michal W.) Signed-off-by: John Harrison Reviewed-by: Michal Wajdeczko Reviewed-by: Julia Filipchuk --- drivers/gpu/drm/xe/xe_guc_ct.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/xe/xe_guc_ct.c b/drivers/gpu/drm/xe/xe_guc_ct.c index 4b95f75b1546..a63fe0a9077a 100644 --- a/drivers/gpu/drm/xe/xe_guc_ct.c +++ b/drivers/gpu/drm/xe/xe_guc_ct.c @@ -1523,7 +1523,7 @@ void xe_guc_ct_snapshot_print(struct xe_guc_ct_snapshot *snapshot, drm_puts(p, "H2G CTB (all sizes in DW):\n"); guc_ctb_snapshot_print(&snapshot->h2g, p); - drm_puts(p, "\nG2H CTB (all sizes in DW):\n"); + drm_puts(p, "G2H CTB (all sizes in DW):\n"); guc_ctb_snapshot_print(&snapshot->g2h, p); drm_printf(p, "\tg2h outstanding: %d\n",