| Message ID | 20240920102802.2483367-1-liviu.dudau@arm.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | drm/panthor: Add FOP_UNSIGNED_OFFSET to fop_flags | expand |
On Fri, 20 Sep 2024 11:28:02 +0100 Liviu Dudau <liviu.dudau@arm.com> wrote: > Since 641bb4394f40 ("fs: move FMODE_UNSIGNED_OFFSET to fop_flags") > the FMODE_UNSIGNED_OFFSET flag has been moved to fop_flags and renamed, > but the patch failed to make the changes for the panthor driver. > When user space opens the render node the WARN() added by the patch > gets triggered. > > Fixes: 641bb4394f40 ("fs: move FMODE_UNSIGNED_OFFSET to fop_flags") > Cc: Christian Brauner <brauner@kernel.org> > Signed-off-by: Liviu Dudau <liviu.dudau@arm.com> Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com> > --- > drivers/gpu/drm/panthor/panthor_drv.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/panthor/panthor_drv.c b/drivers/gpu/drm/panthor/panthor_drv.c > index 34182f67136c1..c520f156e2d73 100644 > --- a/drivers/gpu/drm/panthor/panthor_drv.c > +++ b/drivers/gpu/drm/panthor/panthor_drv.c > @@ -1383,6 +1383,7 @@ static const struct file_operations panthor_drm_driver_fops = { > .read = drm_read, > .llseek = noop_llseek, > .mmap = panthor_mmap, > + .fop_flags = FOP_UNSIGNED_OFFSET, > }; > > #ifdef CONFIG_DEBUG_FS
On 20/09/2024 11:28, Liviu Dudau wrote: > Since 641bb4394f40 ("fs: move FMODE_UNSIGNED_OFFSET to fop_flags") > the FMODE_UNSIGNED_OFFSET flag has been moved to fop_flags and renamed, > but the patch failed to make the changes for the panthor driver. > When user space opens the render node the WARN() added by the patch > gets triggered. > > Fixes: 641bb4394f40 ("fs: move FMODE_UNSIGNED_OFFSET to fop_flags") > Cc: Christian Brauner <brauner@kernel.org> > Signed-off-by: Liviu Dudau <liviu.dudau@arm.com> Reviewed-by: Steven Price <steven.price@arm.com> > --- > drivers/gpu/drm/panthor/panthor_drv.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/panthor/panthor_drv.c b/drivers/gpu/drm/panthor/panthor_drv.c > index 34182f67136c1..c520f156e2d73 100644 > --- a/drivers/gpu/drm/panthor/panthor_drv.c > +++ b/drivers/gpu/drm/panthor/panthor_drv.c > @@ -1383,6 +1383,7 @@ static const struct file_operations panthor_drm_driver_fops = { > .read = drm_read, > .llseek = noop_llseek, > .mmap = panthor_mmap, > + .fop_flags = FOP_UNSIGNED_OFFSET, > }; > > #ifdef CONFIG_DEBUG_FS
diff --git a/drivers/gpu/drm/panthor/panthor_drv.c b/drivers/gpu/drm/panthor/panthor_drv.c index 34182f67136c1..c520f156e2d73 100644 --- a/drivers/gpu/drm/panthor/panthor_drv.c +++ b/drivers/gpu/drm/panthor/panthor_drv.c @@ -1383,6 +1383,7 @@ static const struct file_operations panthor_drm_driver_fops = { .read = drm_read, .llseek = noop_llseek, .mmap = panthor_mmap, + .fop_flags = FOP_UNSIGNED_OFFSET, }; #ifdef CONFIG_DEBUG_FS
Since 641bb4394f40 ("fs: move FMODE_UNSIGNED_OFFSET to fop_flags") the FMODE_UNSIGNED_OFFSET flag has been moved to fop_flags and renamed, but the patch failed to make the changes for the panthor driver. When user space opens the render node the WARN() added by the patch gets triggered. Fixes: 641bb4394f40 ("fs: move FMODE_UNSIGNED_OFFSET to fop_flags") Cc: Christian Brauner <brauner@kernel.org> Signed-off-by: Liviu Dudau <liviu.dudau@arm.com> --- drivers/gpu/drm/panthor/panthor_drv.c | 1 + 1 file changed, 1 insertion(+)