| Message ID | 20240922-msm-drop-unused-func-v1-1-c5dc083415b8@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/msm/hdmi: drop pll_cmp_to_fdata from hdmi_phy_8998 | expand |
On Sun, 22 Sep 2024, Dmitry Baryshkov <dmitry.baryshkov@linaro.org> wrote: > The pll_cmp_to_fdata() was never used by the working code. Drop it to > prevent warnings with W=1 and clang. > > Reported-by: Jani Nikula <jani.nikula@intel.com> > Closes: https://lore.kernel.org/dri-devel/3553b1db35665e6ff08592e35eb438a574d1ad65.1725962479.git.jani.nikula@intel.com > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Reviewed-by: Jani Nikula <jani.nikula@intel.com> > --- > drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c | 9 --------- > 1 file changed, 9 deletions(-) > > diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c b/drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c > index 0e3a2b16a2ce..e6ffaf92d26d 100644 > --- a/drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c > +++ b/drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c > @@ -153,15 +153,6 @@ static inline u32 pll_get_pll_cmp(u64 fdata, unsigned long ref_clk) > return dividend - 1; > } > > -static inline u64 pll_cmp_to_fdata(u32 pll_cmp, unsigned long ref_clk) > -{ > - u64 fdata = ((u64)pll_cmp) * ref_clk * 10; > - > - do_div(fdata, HDMI_PLL_CMP_CNT); > - > - return fdata; > -} > - > #define HDMI_REF_CLOCK_HZ ((u64)19200000) > #define HDMI_MHZ_TO_HZ ((u64)1000000) > static int pll_get_post_div(struct hdmi_8998_post_divider *pd, u64 bclk) > > --- > base-commit: 32ffa5373540a8d1c06619f52d019c6cdc948bb4 > change-id: 20240922-msm-drop-unused-func-b9e76ad8e0ea > > Best regards,
On Sun, Sep 22, 2024 at 12:14:48AM GMT, Dmitry Baryshkov wrote: > The pll_cmp_to_fdata() was never used by the working code. Drop it to > prevent warnings with W=1 and clang. > > Reported-by: Jani Nikula <jani.nikula@intel.com> > Closes: https://lore.kernel.org/dri-devel/3553b1db35665e6ff08592e35eb438a574d1ad65.1725962479.git.jani.nikula@intel.com > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c | 9 --------- > 1 file changed, 9 deletions(-) > And of course Fixes: caedbf17c48d ("drm/msm: add msm8998 hdmi phy/pll support")
On 9/21/2024 2:14 PM, Dmitry Baryshkov wrote: > The pll_cmp_to_fdata() was never used by the working code. Drop it to > prevent warnings with W=1 and clang. > > Reported-by: Jani Nikula <jani.nikula@intel.com> > Closes: https://lore.kernel.org/dri-devel/3553b1db35665e6ff08592e35eb438a574d1ad65.1725962479.git.jani.nikula@intel.com > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c | 9 --------- > 1 file changed, 9 deletions(-) > > diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c b/drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c > index 0e3a2b16a2ce..e6ffaf92d26d 100644 > --- a/drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c > +++ b/drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c > @@ -153,15 +153,6 @@ static inline u32 pll_get_pll_cmp(u64 fdata, unsigned long ref_clk) > return dividend - 1; > } > Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c b/drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c index 0e3a2b16a2ce..e6ffaf92d26d 100644 --- a/drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c +++ b/drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c @@ -153,15 +153,6 @@ static inline u32 pll_get_pll_cmp(u64 fdata, unsigned long ref_clk) return dividend - 1; } -static inline u64 pll_cmp_to_fdata(u32 pll_cmp, unsigned long ref_clk) -{ - u64 fdata = ((u64)pll_cmp) * ref_clk * 10; - - do_div(fdata, HDMI_PLL_CMP_CNT); - - return fdata; -} - #define HDMI_REF_CLOCK_HZ ((u64)19200000) #define HDMI_MHZ_TO_HZ ((u64)1000000) static int pll_get_post_div(struct hdmi_8998_post_divider *pd, u64 bclk)
The pll_cmp_to_fdata() was never used by the working code. Drop it to prevent warnings with W=1 and clang. Reported-by: Jani Nikula <jani.nikula@intel.com> Closes: https://lore.kernel.org/dri-devel/3553b1db35665e6ff08592e35eb438a574d1ad65.1725962479.git.jani.nikula@intel.com Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c | 9 --------- 1 file changed, 9 deletions(-) --- base-commit: 32ffa5373540a8d1c06619f52d019c6cdc948bb4 change-id: 20240922-msm-drop-unused-func-b9e76ad8e0ea Best regards,