| Message ID | 20240923075841.16231-1-tzimmermann@suse.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm: Consistently use struct drm_mode_rect for FB_DAMAGE_CLIPS | expand |
On Mon, Sep 23, 2024 at 09:58:14AM GMT, Thomas Zimmermann wrote: > FB_DAMAGE_CLIPS is a plane property for damage handling. Its UAPI > should only use UAPI types. Hence replace struct drm_rect with > struct drm_mode_rect in drm_atomic_plane_set_property(). Both types > are identical in practice, so there's no change in behavior. > > Reported-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > Closes: https://lore.kernel.org/dri-devel/Zu1Ke1TuThbtz15E@intel.com/ > Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> > Fixes: d3b21767821e ("drm: Add a new plane property to send damage during plane update") > Cc: Lukasz Spintzyk <lukasz.spintzyk@displaylink.com> > Cc: Deepak Rawat <drawat@vmware.com> > Cc: Daniel Vetter <daniel.vetter@ffwll.ch> > Cc: Thomas Hellstrom <thellstrom@vmware.com> > Cc: David Airlie <airlied@gmail.com> > Cc: Simona Vetter <simona@ffwll.ch> > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > Cc: Maxime Ripard <mripard@kernel.org> > Cc: Thomas Zimmermann <tzimmermann@suse.de> > Cc: dri-devel@lists.freedesktop.org > Cc: <stable@vger.kernel.org> # v5.0+ > --- > drivers/gpu/drm/drm_atomic_uapi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
diff --git a/drivers/gpu/drm/drm_atomic_uapi.c b/drivers/gpu/drm/drm_atomic_uapi.c index 7936c2023955..370dc676e3aa 100644 --- a/drivers/gpu/drm/drm_atomic_uapi.c +++ b/drivers/gpu/drm/drm_atomic_uapi.c @@ -543,7 +543,7 @@ static int drm_atomic_plane_set_property(struct drm_plane *plane, &state->fb_damage_clips, val, -1, - sizeof(struct drm_rect), + sizeof(struct drm_mode_rect), &replaced); return ret; } else if (property == plane->scaling_filter_property) {
FB_DAMAGE_CLIPS is a plane property for damage handling. Its UAPI should only use UAPI types. Hence replace struct drm_rect with struct drm_mode_rect in drm_atomic_plane_set_property(). Both types are identical in practice, so there's no change in behavior. Reported-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Closes: https://lore.kernel.org/dri-devel/Zu1Ke1TuThbtz15E@intel.com/ Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> Fixes: d3b21767821e ("drm: Add a new plane property to send damage during plane update") Cc: Lukasz Spintzyk <lukasz.spintzyk@displaylink.com> Cc: Deepak Rawat <drawat@vmware.com> Cc: Daniel Vetter <daniel.vetter@ffwll.ch> Cc: Thomas Hellstrom <thellstrom@vmware.com> Cc: David Airlie <airlied@gmail.com> Cc: Simona Vetter <simona@ffwll.ch> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Cc: Maxime Ripard <mripard@kernel.org> Cc: Thomas Zimmermann <tzimmermann@suse.de> Cc: dri-devel@lists.freedesktop.org Cc: <stable@vger.kernel.org> # v5.0+ --- drivers/gpu/drm/drm_atomic_uapi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)