| Message ID | 20240930120602.1720218-1-aradhya.bhatia@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/xe/xe2lpg: Add WA 15016589081 | expand |
* Aradhya Bhatia (aradhya.bhatia@intel.com) wrote: > Add workaround (wa) 15016589081 which applies to Xe2_v3_LPG_MD. It would be great in this type of patch if you could briefly say what symptom it fixes; Some people might not know what WA 15016589081 does. Dave > Xe2_v3_LPG_MD is a Lunar Lake platform with GFX version: 20.04. > This wa is type: permanent, and hence is applicable on all steppings. > > Signed-off-by: Aradhya Bhatia <aradhya.bhatia@intel.com> > --- > drivers/gpu/drm/xe/xe_wa.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/xe/xe_wa.c b/drivers/gpu/drm/xe/xe_wa.c > index 22c148b1e996..2f9cde4b7d45 100644 > --- a/drivers/gpu/drm/xe/xe_wa.c > +++ b/drivers/gpu/drm/xe/xe_wa.c > @@ -710,6 +710,10 @@ static const struct xe_rtp_entry_sr lrc_was[] = { > DIS_PARTIAL_AUTOSTRIP | > DIS_AUTOSTRIP)) > }, > + { XE_RTP_NAME("15016589081"), > + XE_RTP_RULES(GRAPHICS_VERSION(2004), ENGINE_CLASS(RENDER)), > + XE_RTP_ACTIONS(SET(CHICKEN_RASTER_1, DIS_CLIP_NEGATIVE_BOUNDING_BOX)) > + }, > > /* Xe2_HPG */ > { XE_RTP_NAME("15010599737"), > > base-commit: 0c8650b09a365f4a31fca1d1d1e9d99c56071128 > -- > 2.34.1 > >
> -----Original Message----- > From: Bhatia, Aradhya <aradhya.bhatia@intel.com> > Sent: Monday, September 30, 2024 5:36 PM > To: Vivi, Rodrigo <rodrigo.vivi@intel.com>; Maarten Lankhorst > <maarten.lankhorst@linux.intel.com>; Maxime Ripard > <mripard@kernel.org>; Thomas Zimmermann <tzimmermann@suse.de>; > David Airlie <airlied@gmail.com>; Simona Vetter <simona@ffwll.ch> > Cc: Intel XE List <intel-xe@lists.freedesktop.org>; DRI Devel List <dri- > devel@lists.freedesktop.org>; Linux Kernel List <linux- > kernel@vger.kernel.org>; Jani Nikula <jani.nikula@linux.intel.com>; Roper, > Matthew D <matthew.d.roper@intel.com>; Upadhyay, Tejas > <tejas.upadhyay@intel.com>; Ghimiray, Himal Prasad > <himal.prasad.ghimiray@intel.com>; Sousa, Gustavo > <gustavo.sousa@intel.com>; Bhatia, Aradhya <aradhya.bhatia@intel.com> > Subject: [PATCH] drm/xe/xe2lpg: Add WA 15016589081 We can say, extend WA 15016589081 to xe2_lpg > > Add workaround (wa) 15016589081 which applies to Xe2_v3_LPG_MD. > > Xe2_v3_LPG_MD is a Lunar Lake platform with GFX version: 20.04. > This wa is type: permanent, and hence is applicable on all steppings. > > Signed-off-by: Aradhya Bhatia <aradhya.bhatia@intel.com> > --- > drivers/gpu/drm/xe/xe_wa.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/xe/xe_wa.c b/drivers/gpu/drm/xe/xe_wa.c index > 22c148b1e996..2f9cde4b7d45 100644 > --- a/drivers/gpu/drm/xe/xe_wa.c > +++ b/drivers/gpu/drm/xe/xe_wa.c > @@ -710,6 +710,10 @@ static const struct xe_rtp_entry_sr lrc_was[] = { > DIS_PARTIAL_AUTOSTRIP | > DIS_AUTOSTRIP)) > }, > + { XE_RTP_NAME("15016589081"), > + XE_RTP_RULES(GRAPHICS_VERSION(2004), > ENGINE_CLASS(RENDER)), > + XE_RTP_ACTIONS(SET(CHICKEN_RASTER_1, > DIS_CLIP_NEGATIVE_BOUNDING_BOX)) > + }, Change LGTM, If CI results are ok, you can add, Reviewed-by: Tejas Upadhyay <tejas.upadhyay@intel.com> > > /* Xe2_HPG */ > { XE_RTP_NAME("15010599737"), > > base-commit: 0c8650b09a365f4a31fca1d1d1e9d99c56071128 > -- > 2.34.1
> -----Original Message----- > From: Bhatia, Aradhya <aradhya.bhatia@intel.com> > Sent: Monday, September 30, 2024 5:36 PM > To: Vivi, Rodrigo <rodrigo.vivi@intel.com>; Maarten Lankhorst > <maarten.lankhorst@linux.intel.com>; Maxime Ripard > <mripard@kernel.org>; Thomas Zimmermann <tzimmermann@suse.de>; > David Airlie <airlied@gmail.com>; Simona Vetter <simona@ffwll.ch> > Cc: Intel XE List <intel-xe@lists.freedesktop.org>; DRI Devel List <dri- > devel@lists.freedesktop.org>; Linux Kernel List <linux- > kernel@vger.kernel.org>; Jani Nikula <jani.nikula@linux.intel.com>; Roper, > Matthew D <matthew.d.roper@intel.com>; Upadhyay, Tejas > <tejas.upadhyay@intel.com>; Ghimiray, Himal Prasad > <himal.prasad.ghimiray@intel.com>; Sousa, Gustavo > <gustavo.sousa@intel.com>; Bhatia, Aradhya <aradhya.bhatia@intel.com> > Subject: [PATCH] drm/xe/xe2lpg: Add WA 15016589081 Also please mention "drm/xe/xe2lpg: Extend Wa_15016589081 for xe2lpg" Wa_15016589081 is for making uniform subject across WAs. Tejas > > Add workaround (wa) 15016589081 which applies to Xe2_v3_LPG_MD. > > Xe2_v3_LPG_MD is a Lunar Lake platform with GFX version: 20.04. > This wa is type: permanent, and hence is applicable on all steppings. > > Signed-off-by: Aradhya Bhatia <aradhya.bhatia@intel.com> > --- > drivers/gpu/drm/xe/xe_wa.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/xe/xe_wa.c b/drivers/gpu/drm/xe/xe_wa.c index > 22c148b1e996..2f9cde4b7d45 100644 > --- a/drivers/gpu/drm/xe/xe_wa.c > +++ b/drivers/gpu/drm/xe/xe_wa.c > @@ -710,6 +710,10 @@ static const struct xe_rtp_entry_sr lrc_was[] = { > DIS_PARTIAL_AUTOSTRIP | > DIS_AUTOSTRIP)) > }, > + { XE_RTP_NAME("15016589081"), > + XE_RTP_RULES(GRAPHICS_VERSION(2004), > ENGINE_CLASS(RENDER)), > + XE_RTP_ACTIONS(SET(CHICKEN_RASTER_1, > DIS_CLIP_NEGATIVE_BOUNDING_BOX)) > + }, > > /* Xe2_HPG */ > { XE_RTP_NAME("15010599737"), > > base-commit: 0c8650b09a365f4a31fca1d1d1e9d99c56071128 > -- > 2.34.1
diff --git a/drivers/gpu/drm/xe/xe_wa.c b/drivers/gpu/drm/xe/xe_wa.c index 22c148b1e996..2f9cde4b7d45 100644 --- a/drivers/gpu/drm/xe/xe_wa.c +++ b/drivers/gpu/drm/xe/xe_wa.c @@ -710,6 +710,10 @@ static const struct xe_rtp_entry_sr lrc_was[] = { DIS_PARTIAL_AUTOSTRIP | DIS_AUTOSTRIP)) }, + { XE_RTP_NAME("15016589081"), + XE_RTP_RULES(GRAPHICS_VERSION(2004), ENGINE_CLASS(RENDER)), + XE_RTP_ACTIONS(SET(CHICKEN_RASTER_1, DIS_CLIP_NEGATIVE_BOUNDING_BOX)) + }, /* Xe2_HPG */ { XE_RTP_NAME("15010599737"),
Add workaround (wa) 15016589081 which applies to Xe2_v3_LPG_MD. Xe2_v3_LPG_MD is a Lunar Lake platform with GFX version: 20.04. This wa is type: permanent, and hence is applicable on all steppings. Signed-off-by: Aradhya Bhatia <aradhya.bhatia@intel.com> --- drivers/gpu/drm/xe/xe_wa.c | 4 ++++ 1 file changed, 4 insertions(+) base-commit: 0c8650b09a365f4a31fca1d1d1e9d99c56071128