| Message ID | 20241001062555.1908090-1-harshit.m.mogalapalli@oracle.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | drm/i915: Rename functions in the docs to match code changes | expand |
On 2024-09-30 at 23:25:54 -0700, Harshit Mogalapalli wrote: > make htmldocs is reporting: > > drivers/gpu/drm/i915/i915_irq.c:1: warning: 'intel_runtime_pm_disable_interrupts' not found > drivers/gpu/drm/i915/i915_irq.c:1: warning: 'intel_runtime_pm_enable_interrupts' not found > Hi Harshit Mogalapalli, I confirmed that the patch fixes these warnings. Reviewed-by: Krzysztof Karas <krzysztof.karas@intel.com> Krzysztof Karas > intel_runtime_pm_disable_interrupts() is renamed to intel_irq_suspend(), > make documentation changes accordingly. > > Fixes: 3de5774cb8c0 ("drm/i915/irq: Rename suspend/resume functions") > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> > Closes: https://lore.kernel.org/all/20241001134331.7b4d4ca5@canb.auug.org.au/ > Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com> > --- > Noticed that Stephen also reported this so added a Closes URL. > --- > Documentation/gpu/i915.rst | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/gpu/i915.rst b/Documentation/gpu/i915.rst > index ad59ae579237..7a469df675d8 100644 > --- a/Documentation/gpu/i915.rst > +++ b/Documentation/gpu/i915.rst > @@ -35,10 +35,10 @@ Interrupt Handling > :functions: intel_irq_init intel_irq_init_hw intel_hpd_init > > .. kernel-doc:: drivers/gpu/drm/i915/i915_irq.c > - :functions: intel_runtime_pm_disable_interrupts > + :functions: intel_irq_suspend > > .. kernel-doc:: drivers/gpu/drm/i915/i915_irq.c > - :functions: intel_runtime_pm_enable_interrupts > + :functions: intel_irq_resume > > Intel GVT-g Guest Support(vGPU) > ------------------------------- > -- > 2.46.0 >
Hi Harshit, On Mon, Sep 30, 2024 at 11:25:54PM -0700, Harshit Mogalapalli wrote: > make htmldocs is reporting: > > drivers/gpu/drm/i915/i915_irq.c:1: warning: 'intel_runtime_pm_disable_interrupts' not found > drivers/gpu/drm/i915/i915_irq.c:1: warning: 'intel_runtime_pm_enable_interrupts' not found > > intel_runtime_pm_disable_interrupts() is renamed to intel_irq_suspend(), > make documentation changes accordingly. > > Fixes: 3de5774cb8c0 ("drm/i915/irq: Rename suspend/resume functions") > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> > Closes: https://lore.kernel.org/all/20241001134331.7b4d4ca5@canb.auug.org.au/ > Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com> Thanks for your patch. The functions were indeed renamed here(*) by Rodrigo. I'm going to remove the "Fixes:" tag as I don't think documentation fixes are part of it. Unless someone wants it strongly. Without the Fixes tag: Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com> Andi (*) 3de5774cb8c0 ("drm/i915/irq: Rename suspend/resume functions") > --- > Noticed that Stephen also reported this so added a Closes URL. > --- > Documentation/gpu/i915.rst | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/gpu/i915.rst b/Documentation/gpu/i915.rst > index ad59ae579237..7a469df675d8 100644 > --- a/Documentation/gpu/i915.rst > +++ b/Documentation/gpu/i915.rst > @@ -35,10 +35,10 @@ Interrupt Handling > :functions: intel_irq_init intel_irq_init_hw intel_hpd_init > > .. kernel-doc:: drivers/gpu/drm/i915/i915_irq.c > - :functions: intel_runtime_pm_disable_interrupts > + :functions: intel_irq_suspend > > .. kernel-doc:: drivers/gpu/drm/i915/i915_irq.c > - :functions: intel_runtime_pm_enable_interrupts > + :functions: intel_irq_resume > > Intel GVT-g Guest Support(vGPU) > ------------------------------- > -- > 2.46.0
diff --git a/Documentation/gpu/i915.rst b/Documentation/gpu/i915.rst index ad59ae579237..7a469df675d8 100644 --- a/Documentation/gpu/i915.rst +++ b/Documentation/gpu/i915.rst @@ -35,10 +35,10 @@ Interrupt Handling :functions: intel_irq_init intel_irq_init_hw intel_hpd_init .. kernel-doc:: drivers/gpu/drm/i915/i915_irq.c - :functions: intel_runtime_pm_disable_interrupts + :functions: intel_irq_suspend .. kernel-doc:: drivers/gpu/drm/i915/i915_irq.c - :functions: intel_runtime_pm_enable_interrupts + :functions: intel_irq_resume Intel GVT-g Guest Support(vGPU) -------------------------------
make htmldocs is reporting: drivers/gpu/drm/i915/i915_irq.c:1: warning: 'intel_runtime_pm_disable_interrupts' not found drivers/gpu/drm/i915/i915_irq.c:1: warning: 'intel_runtime_pm_enable_interrupts' not found intel_runtime_pm_disable_interrupts() is renamed to intel_irq_suspend(), make documentation changes accordingly. Fixes: 3de5774cb8c0 ("drm/i915/irq: Rename suspend/resume functions") Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> Closes: https://lore.kernel.org/all/20241001134331.7b4d4ca5@canb.auug.org.au/ Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com> --- Noticed that Stephen also reported this so added a Closes URL. --- Documentation/gpu/i915.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)