| Message ID | 20241009140300.1980746-1-jani.nikula@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/file: fix client_name_lock kernel-doc warning | expand |
On 10/9/24 17:03, Jani Nikula wrote: > It's client_name_lock, not name_lock. Also unify style while at it. > > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> > Closes: https://lore.kernel.org/r/20241009172650.29169e6f@canb.auug.org.au > Fixes: 56c594d8df64 ("drm: add DRM_SET_CLIENT_NAME ioctl") > Cc: Tvrtko Ursulin <tvrtko.ursulin@igalia.com> > Cc: Dmitry Osipenko <dmitry.osipenko@collabora.com> > Cc: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> > Cc: Christian König <christian.koenig@amd.com> > Signed-off-by: Jani Nikula <jani.nikula@intel.com> > --- > include/drm/drm_file.h | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/include/drm/drm_file.h b/include/drm/drm_file.h > index d4f1c115ea0f..f0ef32e9fa5e 100644 > --- a/include/drm/drm_file.h > +++ b/include/drm/drm_file.h > @@ -395,7 +395,10 @@ struct drm_file { > * Userspace-provided name; useful for accounting and debugging. > */ > const char *client_name; > - /** @name_lock: Protects @client_name. */ > + > + /** > + * @client_name_lock: Protects @client_name. > + */ > struct mutex client_name_lock; > }; Thanks for the quick fix! Please apply to misc-next Reviewed-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
Am 09.10.24 um 16:23 schrieb Dmitry Osipenko: > On 10/9/24 17:03, Jani Nikula wrote: >> It's client_name_lock, not name_lock. Also unify style while at it. >> >> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> >> Closes: https://lore.kernel.org/r/20241009172650.29169e6f@canb.auug.org.au >> Fixes: 56c594d8df64 ("drm: add DRM_SET_CLIENT_NAME ioctl") >> Cc: Tvrtko Ursulin <tvrtko.ursulin@igalia.com> >> Cc: Dmitry Osipenko <dmitry.osipenko@collabora.com> >> Cc: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> >> Cc: Christian König <christian.koenig@amd.com> >> Signed-off-by: Jani Nikula <jani.nikula@intel.com> >> --- >> include/drm/drm_file.h | 5 ++++- >> 1 file changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/include/drm/drm_file.h b/include/drm/drm_file.h >> index d4f1c115ea0f..f0ef32e9fa5e 100644 >> --- a/include/drm/drm_file.h >> +++ b/include/drm/drm_file.h >> @@ -395,7 +395,10 @@ struct drm_file { >> * Userspace-provided name; useful for accounting and debugging. >> */ >> const char *client_name; >> - /** @name_lock: Protects @client_name. */ >> + >> + /** >> + * @client_name_lock: Protects @client_name. >> + */ >> struct mutex client_name_lock; >> }; > Thanks for the quick fix! Please apply to misc-next Done. Christian. > > Reviewed-by: Dmitry Osipenko <dmitry.osipenko@collabora.com> >
diff --git a/include/drm/drm_file.h b/include/drm/drm_file.h index d4f1c115ea0f..f0ef32e9fa5e 100644 --- a/include/drm/drm_file.h +++ b/include/drm/drm_file.h @@ -395,7 +395,10 @@ struct drm_file { * Userspace-provided name; useful for accounting and debugging. */ const char *client_name; - /** @name_lock: Protects @client_name. */ + + /** + * @client_name_lock: Protects @client_name. + */ struct mutex client_name_lock; };
It's client_name_lock, not name_lock. Also unify style while at it. Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> Closes: https://lore.kernel.org/r/20241009172650.29169e6f@canb.auug.org.au Fixes: 56c594d8df64 ("drm: add DRM_SET_CLIENT_NAME ioctl") Cc: Tvrtko Ursulin <tvrtko.ursulin@igalia.com> Cc: Dmitry Osipenko <dmitry.osipenko@collabora.com> Cc: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Cc: Christian König <christian.koenig@amd.com> Signed-off-by: Jani Nikula <jani.nikula@intel.com> --- include/drm/drm_file.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)