| Message ID | 20241012075312.16342-7-witcher@wiredspace.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/7] drm/panic: avoid reimplementing Iterator::find | expand |
On 12/10/2024 09:52, Thomas Böhler wrote: > Clippy warns about a reimplementation of `RangeInclusive::contains`: > > error: manual `!RangeInclusive::contains` implementation > --> drivers/gpu/drm/drm_panic_qr.rs:986:8 > | > 986 | if version < 1 || version > 40 { > | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `!(1..=40).contains(&version)` > | > = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains > = note: `-D clippy::manual-range-contains` implied by `-D warnings` > = help: to override `-D warnings` add `#[allow(clippy::manual_range_contains)]` > > Ignore this and keep the current implementation as that makes it easier > to read. Thanks, it looks good to me. Reviewed-by: Jocelyn Falempe <jfalempe@redhat.com> > > Reported-by: Miguel Ojeda <ojeda@kernel.org> > Closes: https://github.com/Rust-for-Linux/linux/issues/1123 > Signed-off-by: Thomas Böhler <witcher@wiredspace.de> > --- > drivers/gpu/drm/drm_panic_qr.rs | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/drm_panic_qr.rs b/drivers/gpu/drm/drm_panic_qr.rs > index 226107c02679..fe842466d8d6 100644 > --- a/drivers/gpu/drm/drm_panic_qr.rs > +++ b/drivers/gpu/drm/drm_panic_qr.rs > @@ -981,6 +981,7 @@ fn draw_all(&mut self, data: impl Iterator<Item = u8>) { > /// * If `url_len` = 0, only removes 3 bytes for 1 binary segment. > #[no_mangle] > pub extern "C" fn drm_panic_qr_max_data_size(version: u8, url_len: usize) -> usize { > + #[allow(clippy::manual_range_contains)] > if version < 1 || version > 40 { > return 0; > }
diff --git a/drivers/gpu/drm/drm_panic_qr.rs b/drivers/gpu/drm/drm_panic_qr.rs index 226107c02679..fe842466d8d6 100644 --- a/drivers/gpu/drm/drm_panic_qr.rs +++ b/drivers/gpu/drm/drm_panic_qr.rs @@ -981,6 +981,7 @@ fn draw_all(&mut self, data: impl Iterator<Item = u8>) { /// * If `url_len` = 0, only removes 3 bytes for 1 binary segment. #[no_mangle] pub extern "C" fn drm_panic_qr_max_data_size(version: u8, url_len: usize) -> usize { + #[allow(clippy::manual_range_contains)] if version < 1 || version > 40 { return 0; }
Clippy warns about a reimplementation of `RangeInclusive::contains`: error: manual `!RangeInclusive::contains` implementation --> drivers/gpu/drm/drm_panic_qr.rs:986:8 | 986 | if version < 1 || version > 40 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `!(1..=40).contains(&version)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains = note: `-D clippy::manual-range-contains` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::manual_range_contains)]` Ignore this and keep the current implementation as that makes it easier to read. Reported-by: Miguel Ojeda <ojeda@kernel.org> Closes: https://github.com/Rust-for-Linux/linux/issues/1123 Signed-off-by: Thomas Böhler <witcher@wiredspace.de> --- drivers/gpu/drm/drm_panic_qr.rs | 1 + 1 file changed, 1 insertion(+)