| Message ID | 20241018151258.3574617-1-arnd@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | fbdev/wm8505fb: select CONFIG_FB_IOMEM_FOPS | expand |
On 10/18/24 17:12, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > The fb_io_mmap() function is used in the file operations but > not enabled in all configurations unless FB_IOMEM_FOPS gets > selected: > > ld.lld-20: error: undefined symbol: fb_io_mmap >>>> referenced by wm8505fb.c >>>> drivers/video/fbdev/wm8505fb.o:(wm8505fb_ops) in archive vmlinux.a > > Fixes: 11754a504608 ("fbdev/wm8505fb: Initialize fb_ops to fbdev I/O-memory helpers") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> applied. Thanks! Helge
Am 18.10.24 um 17:12 schrieb Arnd Bergmann: > From: Arnd Bergmann <arnd@arndb.de> > > The fb_io_mmap() function is used in the file operations but > not enabled in all configurations unless FB_IOMEM_FOPS gets > selected: > > ld.lld-20: error: undefined symbol: fb_io_mmap >>>> referenced by wm8505fb.c >>>> drivers/video/fbdev/wm8505fb.o:(wm8505fb_ops) in archive vmlinux.a > Fixes: 11754a504608 ("fbdev/wm8505fb: Initialize fb_ops to fbdev I/O-memory helpers") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de> > --- > drivers/video/fbdev/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig > index 9957dde4a3f6..961d7f5bbbc2 100644 > --- a/drivers/video/fbdev/Kconfig > +++ b/drivers/video/fbdev/Kconfig > @@ -1388,6 +1388,7 @@ config FB_VT8500 > config FB_WM8505 > bool "Wondermedia WM8xxx-series frame buffer support" > depends on (FB = y) && HAS_IOMEM && (ARCH_VT8500 || COMPILE_TEST) > + select FB_IOMEM_FOPS > select FB_SYS_FILLRECT if (!FB_WMT_GE_ROPS) > select FB_SYS_COPYAREA if (!FB_WMT_GE_ROPS) > select FB_SYS_IMAGEBLIT
diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig index 9957dde4a3f6..961d7f5bbbc2 100644 --- a/drivers/video/fbdev/Kconfig +++ b/drivers/video/fbdev/Kconfig @@ -1388,6 +1388,7 @@ config FB_VT8500 config FB_WM8505 bool "Wondermedia WM8xxx-series frame buffer support" depends on (FB = y) && HAS_IOMEM && (ARCH_VT8500 || COMPILE_TEST) + select FB_IOMEM_FOPS select FB_SYS_FILLRECT if (!FB_WMT_GE_ROPS) select FB_SYS_COPYAREA if (!FB_WMT_GE_ROPS) select FB_SYS_IMAGEBLIT