| Message ID | 20241019052935.553886-1-fshao@chromium.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | dt-bindings: display: mediatek: dpi: Update device list with power-domains | expand |
On Sat, Oct 19, 2024 at 01:26:56PM +0800, Fei Shao wrote: > There are two kinds of MediaTek DPI devices in the tree: the ones with a > power domain and those without (or missing). The former are the majority > and are more common in newer DTs. Only three older DTs fall into the > latter category: MT2701, MT7623 and MT8192. > > However, the current binding only allows particular DPI devices to have > power domains, which results in spurious binding check errors against > existing and new DTs. > > Instead of diligently maintaining the allowed list, let's do it the > other way around - create an exception list for devices that are fine > not specifying a power domain. This list is expected to be fixed, and it > encourages new MTK DPI devices to describe their power domain whenever > possible; if not, those should be listed with proper rationale. > > Signed-off-by: Fei Shao <fshao@chromium.org> Acked-by: Conor Dooley <conor.dooley@microchip.com>
Hi, Fei: Fei Shao <fshao@chromium.org> 於 2024年10月19日 週六 下午1:30寫道： > > There are two kinds of MediaTek DPI devices in the tree: the ones with a > power domain and those without (or missing). The former are the majority > and are more common in newer DTs. Only three older DTs fall into the > latter category: MT2701, MT7623 and MT8192. > > However, the current binding only allows particular DPI devices to have > power domains, which results in spurious binding check errors against > existing and new DTs. > > Instead of diligently maintaining the allowed list, let's do it the > other way around - create an exception list for devices that are fine > not specifying a power domain. This list is expected to be fixed, and it > encourages new MTK DPI devices to describe their power domain whenever > possible; if not, those should be listed with proper rationale. I've applied patch [1]. I think that patch fix the same problem with this patch. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/commit/?h=mediatek-drm-fixes&id=af6ab107ce2c338790c6629fe0edc0333e708be8 Regards, Chun-Kuang. > > Signed-off-by: Fei Shao <fshao@chromium.org> > --- > > .../bindings/display/mediatek/mediatek,dpi.yaml | 15 +++++++-------- > 1 file changed, 7 insertions(+), 8 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml > index 3a82aec9021c..c464642bbfb6 100644 > --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml > +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml > @@ -81,14 +81,13 @@ required: > > allOf: > - if: > - not: > - properties: > - compatible: > - contains: > - enum: > - - mediatek,mt6795-dpi > - - mediatek,mt8173-dpi > - - mediatek,mt8186-dpi > + properties: > + compatible: > + contains: > + enum: > + - mediatek,mt2701-dpi > + - mediatek,mt7623-dpi > + - mediatek,mt8192-dpi > then: > properties: > power-domains: false > -- > 2.47.0.rc1.288.g06298d1525-goog >
diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml index 3a82aec9021c..c464642bbfb6 100644 --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml @@ -81,14 +81,13 @@ required: allOf: - if: - not: - properties: - compatible: - contains: - enum: - - mediatek,mt6795-dpi - - mediatek,mt8173-dpi - - mediatek,mt8186-dpi + properties: + compatible: + contains: + enum: + - mediatek,mt2701-dpi + - mediatek,mt7623-dpi + - mediatek,mt8192-dpi then: properties: power-domains: false
There are two kinds of MediaTek DPI devices in the tree: the ones with a power domain and those without (or missing). The former are the majority and are more common in newer DTs. Only three older DTs fall into the latter category: MT2701, MT7623 and MT8192. However, the current binding only allows particular DPI devices to have power domains, which results in spurious binding check errors against existing and new DTs. Instead of diligently maintaining the allowed list, let's do it the other way around - create an exception list for devices that are fine not specifying a power domain. This list is expected to be fixed, and it encourages new MTK DPI devices to describe their power domain whenever possible; if not, those should be listed with proper rationale. Signed-off-by: Fei Shao <fshao@chromium.org> --- .../bindings/display/mediatek/mediatek,dpi.yaml | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-)