| Message ID | 20241024061347.1771063-2-saravanak@google.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | A few minor fw_devlink fixes | expand |
On Wed, Oct 23, 2024 at 11:13:42PM -0700, Saravana Kannan wrote: > fwnode needs to be set for a device for fw_devlink to be able to > track/enforce its dependencies correctly. Without this, you'll see error > messages like this when the supplier has probed and tries to make sure > all its fwnode consumers are linked to it using device links: > > mediatek-drm-dp 1c500000.edp-tx: Failed to create device link (0x180) with backlight-lcd0 > > Reported-by: "Nícolas F. R. A. Prado" <nfraprado@collabora.com> > Closes: https://lore.kernel.org/all/7b995947-4540-4b17-872e-e107adca4598@notapiano/ > Tested-by: "Nícolas F. R. A. Prado" <nfraprado@collabora.com> > Signed-off-by: Saravana Kannan <saravanak@google.com> > --- > drivers/gpu/drm/display/drm_dp_aux_bus.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Thierry Reding <treding@nvidia.com>
On Wed, Oct 23, 2024 at 11:13:42PM -0700, Saravana Kannan wrote: > fwnode needs to be set for a device for fw_devlink to be able to > track/enforce its dependencies correctly. Without this, you'll see error > messages like this when the supplier has probed and tries to make sure > all its fwnode consumers are linked to it using device links: > > mediatek-drm-dp 1c500000.edp-tx: Failed to create device link (0x180) with backlight-lcd0 > > Reported-by: "Nícolas F. R. A. Prado" <nfraprado@collabora.com> > Closes: https://lore.kernel.org/all/7b995947-4540-4b17-872e-e107adca4598@notapiano/ > Tested-by: "Nícolas F. R. A. Prado" <nfraprado@collabora.com> > Signed-off-by: Saravana Kannan <saravanak@google.com> > --- > drivers/gpu/drm/display/drm_dp_aux_bus.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
diff --git a/drivers/gpu/drm/display/drm_dp_aux_bus.c b/drivers/gpu/drm/display/drm_dp_aux_bus.c index d810529ebfb6..ec7eac6b595f 100644 --- a/drivers/gpu/drm/display/drm_dp_aux_bus.c +++ b/drivers/gpu/drm/display/drm_dp_aux_bus.c @@ -292,7 +292,7 @@ int of_dp_aux_populate_bus(struct drm_dp_aux *aux, aux_ep->dev.parent = aux->dev; aux_ep->dev.bus = &dp_aux_bus_type; aux_ep->dev.type = &dp_aux_device_type_type; - aux_ep->dev.of_node = of_node_get(np); + device_set_node(&aux_ep->dev, of_fwnode_handle(of_node_get(np))); dev_set_name(&aux_ep->dev, "aux-%s", dev_name(aux->dev)); ret = device_register(&aux_ep->dev);