From patchwork Thu Oct 24 06:13:42 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Saravana Kannan X-Patchwork-Id: 13848339 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 188F9D0BB61 for ; Thu, 24 Oct 2024 06:13:59 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8DB9210E1F1; Thu, 24 Oct 2024 06:13:58 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.b="nAmPt8U9"; dkim-atps=neutral Received: from mail-yw1-f202.google.com (mail-yw1-f202.google.com [209.85.128.202]) by gabe.freedesktop.org (Postfix) with ESMTPS id DB18110E1F1 for ; Thu, 24 Oct 2024 06:13:56 +0000 (UTC) Received: by mail-yw1-f202.google.com with SMTP id 00721157ae682-6e3705b2883so11402417b3.3 for ; Wed, 23 Oct 2024 23:13:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1729750436; x=1730355236; darn=lists.freedesktop.org; h=content-transfer-encoding:cc:to:from:subject:references :mime-version:message-id:in-reply-to:date:from:to:cc:subject:date :message-id:reply-to; bh=ULy+zyN1BivKyLwzuPRCl/8UJCnpTGDPYrNtb9eDcL4=; b=nAmPt8U9d8sCyHWUN3yxfD4Sy94ki7EFFsrEzrB4+WmNTlJuPWYgIkuPB2vzyN8PUJ fBgmeKSQX8MCSTmwUt9FqB6NkQONjQShm8giskDzjW8Ww8vq5zyddSct0MrRFvj0z8iY +Q82VHcoVkDavhhlB87g6KyFR5ooOppJlG/PguxbUvCV/oJ85a04XyM115rv7h80QUwh 9bB68uWnAcPzm/wacRCSBWQTqGGfR0g9oRlBbQhz5qIN1JeGS9ORaksAEVrYKd1rdWlA Tj0oABXT2qJbyDSoAOPo/5or8XAikoMm431kNsKpPzrGnQL8siIaSN7bcUN1L1ftkjnB /w+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729750436; x=1730355236; h=content-transfer-encoding:cc:to:from:subject:references :mime-version:message-id:in-reply-to:date:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=ULy+zyN1BivKyLwzuPRCl/8UJCnpTGDPYrNtb9eDcL4=; b=vNPuI+QeCMaGAHw8OU5zEHGL5yRjz7p7p7YocIAhS2wY3UsPjhpchDjN8onUuvQQoI ZH2AB+zN/+xE2VUvTOSnhLNr8fQG9OIgEt6u7kYLtt2adM1ifW0rMIY7JZC5LFXP8HXI qNS9z2gHB1BA5Pqyfy5AB9Hzpev01AjjlhwTXV2kkWYa98zmivbikkPXA5tdPdfB7jkU RDfG3+GcBE3S/JDitq0UMJRXKZr42CX7B1PAZGLW0Qec19XCgrhX1fBNmwnwbNlrvl8P c0BUQ/PmiQBs18DWDtMkyEayS0GJIM5hWmyHxR2WgFeisWRNliLNgjmsO79btXwJhVOx IoVg== X-Forwarded-Encrypted: i=1; AJvYcCVV9eePuAimKz3t7+iQnjQqwoSpk/BZ1auF5wFVxifvXS3Rqtj71u99hSFVmYuL0sTaQeRa2t78b1A=@lists.freedesktop.org X-Gm-Message-State: AOJu0Yzna8IuY+GYCViTxnZGs7p0MohXC84HmtwHik4hKA+onTs3Rqnj 3T5z5lUXeqVQ/8ji1Rw8FFDIQzQs+6SDTgYsQ9b3Hy8tQqBsEPIO5ITMws8jayyBqMEr8nrQpgT Seg2aj/E+VLeCoQ== X-Google-Smtp-Source: AGHT+IHCEMkQ2RfyYdNtjaLmn7Q1IV6vv3d2IoDuURVXiH0KtdFNDJTv0BNk9TxANKxuJUTxCoodn7NIA1qQz7g= X-Received: from saravanak.san.corp.google.com ([2620:15c:2d:3:965e:f81d:c9fb:b352]) (user=saravanak job=sendgmr) by 2002:a05:690c:6811:b0:6e3:19d7:382a with SMTP id 00721157ae682-6e85813d7f5mr589267b3.1.1729750435897; Wed, 23 Oct 2024 23:13:55 -0700 (PDT) Date: Wed, 23 Oct 2024 23:13:42 -0700 In-Reply-To: <20241024061347.1771063-1-saravanak@google.com> Message-Id: <20241024061347.1771063-2-saravanak@google.com> Mime-Version: 1.0 References: <20241024061347.1771063-1-saravanak@google.com> X-Mailer: git-send-email 2.47.0.105.g07ac214952-goog Subject: [PATCH 1/3] drm: display: Set fwnode for aux bus devices From: Saravana Kannan To: Greg Kroah-Hartman , "Rafael J. Wysocki" , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , JC Kuo , Vinod Koul , Kishon Vijay Abraham I , Thierry Reding , Jonathan Hunter , Matthias Brugger , AngeloGioacchino Del Regno Cc: Saravana Kannan , " =?utf-8?b?TsOtY29sYXMgRi4g?= =?utf-8?b?Ui4gQS4gUHJhZG8=?= " , kernel-team@android.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-phy@lists.infradead.org, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" fwnode needs to be set for a device for fw_devlink to be able to track/enforce its dependencies correctly. Without this, you'll see error messages like this when the supplier has probed and tries to make sure all its fwnode consumers are linked to it using device links: mediatek-drm-dp 1c500000.edp-tx: Failed to create device link (0x180) with backlight-lcd0 Reported-by: "Nícolas F. R. A. Prado" Closes: https://lore.kernel.org/all/7b995947-4540-4b17-872e-e107adca4598@notapiano/ Tested-by: "Nícolas F. R. A. Prado" Signed-off-by: Saravana Kannan Reviewed-by: Thierry Reding Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/display/drm_dp_aux_bus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/display/drm_dp_aux_bus.c b/drivers/gpu/drm/display/drm_dp_aux_bus.c index d810529ebfb6..ec7eac6b595f 100644 --- a/drivers/gpu/drm/display/drm_dp_aux_bus.c +++ b/drivers/gpu/drm/display/drm_dp_aux_bus.c @@ -292,7 +292,7 @@ int of_dp_aux_populate_bus(struct drm_dp_aux *aux, aux_ep->dev.parent = aux->dev; aux_ep->dev.bus = &dp_aux_bus_type; aux_ep->dev.type = &dp_aux_device_type_type; - aux_ep->dev.of_node = of_node_get(np); + device_set_node(&aux_ep->dev, of_fwnode_handle(of_node_get(np))); dev_set_name(&aux_ep->dev, "aux-%s", dev_name(aux->dev)); ret = device_register(&aux_ep->dev);