From patchwork Thu Oct 24 06:13:43 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Saravana Kannan X-Patchwork-Id: 13848340 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 83A05D0BB61 for ; Thu, 24 Oct 2024 06:14:03 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D037310E8AD; Thu, 24 Oct 2024 06:14:02 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.b="Bq2PjO9c"; dkim-atps=neutral Received: from mail-yw1-f201.google.com (mail-yw1-f201.google.com [209.85.128.201]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8F20610E8AD for ; Thu, 24 Oct 2024 06:14:01 +0000 (UTC) Received: by mail-yw1-f201.google.com with SMTP id 00721157ae682-6e59dc7df64so7436197b3.1 for ; Wed, 23 Oct 2024 23:14:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1729750441; x=1730355241; darn=lists.freedesktop.org; h=content-transfer-encoding:cc:to:from:subject:references :mime-version:message-id:in-reply-to:date:from:to:cc:subject:date :message-id:reply-to; bh=pXMUNc/LORv2j86/u57jzQlk6FOM7Zoz5+8UmtPcmgU=; b=Bq2PjO9cjUx5A6dfWyYLUf3VZN+iMJ59VMcwegEKR7LGUwAfRGNRxC+gx5kQf9o90n PLXJUAWNAdO966A9j1IN2E19FYQchoLXTKKHtnTn9zI9kqKBl6/Y864wB+JLQISYZ9hS RK9YYohq/f0e7Vs0nSUKR927n7mDR6cueRG7aXkzZotBg2VAplpi0zIf15WQI8o4mV/L 9YaJPXW7tSJcNR3VnMyEHS/x17NB3ZGb96FZJd4ZpXGhL5e72X2J5hVEvBc/U4oig7T0 dp7812a8Xp73ovJna7JxcX8+06+gojstwCXNy/E3wv7YEGYH06Jp9BlZO8aymtjXKWSx aI9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729750441; x=1730355241; h=content-transfer-encoding:cc:to:from:subject:references :mime-version:message-id:in-reply-to:date:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=pXMUNc/LORv2j86/u57jzQlk6FOM7Zoz5+8UmtPcmgU=; b=e2oinT+v4qwtliUbPxXP6fed9rG4yZx0q4O+2E+oDsUpHR5PeHsY3rJyFm6lCXFCVl jxRnvK7XWLERSSWLXYHADU003vABiPm/bf0tf9OZ5InlB1fcyzpiYjaTbTPKz3EWy80m 6FDyC1j2SlYgVJFb9ZARwdiCVOjpNeu0AptVd9rZETMNIoIe2HMc7G4fdOxyBbQRpPDn zvBXGc4sM6BGrlG4/KH2xGyoO7fgHW8NeP4+ZaTE6/c+er49KQWtLlMf9z60hZUawpeD /Wj7iY4DQO5G0a5DU11GakpPVy1tubays8haF5jmuLIrzJtDHSTIio8OYGVQG4q0Yq2z RETA== X-Forwarded-Encrypted: i=1; AJvYcCWfvB+Ri5cJoirurMbiRMWMddCd5m2C1J6O6SMoG7z2Jqc0Jf7VDHVJwzWMU24dvhQeDVp6tSYcDDs=@lists.freedesktop.org X-Gm-Message-State: AOJu0YxLhI80XvRQvjpWaJ1v0JcL/FpMrQ+XxW6Sp6irbofduXrnGR4A y9xGpdXaeBj2g5kkhFVHKOr9DTYIob3UHiapI+wWuWcwlOT7+z3guWWWKjRPjO4rpsAI/WQ495X 76pfrQ4VJZlOiaw== X-Google-Smtp-Source: AGHT+IEvWKI797qzaVIyJQytUKUTuDrxqDTilc69F1bH77+J3k5wYMBvLRY6cYuzVgsPwwCo2eftygSjpmQuXoI= X-Received: from saravanak.san.corp.google.com ([2620:15c:2d:3:965e:f81d:c9fb:b352]) (user=saravanak job=sendgmr) by 2002:a05:690c:9c06:b0:6e3:c4cb:689b with SMTP id 00721157ae682-6e866350bbfmr483267b3.4.1729750440665; Wed, 23 Oct 2024 23:14:00 -0700 (PDT) Date: Wed, 23 Oct 2024 23:13:43 -0700 In-Reply-To: <20241024061347.1771063-1-saravanak@google.com> Message-Id: <20241024061347.1771063-3-saravanak@google.com> Mime-Version: 1.0 References: <20241024061347.1771063-1-saravanak@google.com> X-Mailer: git-send-email 2.47.0.105.g07ac214952-goog Subject: [PATCH 2/3] phy: tegra: xusb: Set fwnode for xusb port devices From: Saravana Kannan To: Greg Kroah-Hartman , "Rafael J. Wysocki" , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , JC Kuo , Vinod Koul , Kishon Vijay Abraham I , Thierry Reding , Jonathan Hunter , Matthias Brugger , AngeloGioacchino Del Regno Cc: Saravana Kannan , " =?utf-8?b?TsOtY29sYXMgRi4g?= =?utf-8?b?Ui4gQS4gUHJhZG8=?= " , kernel-team@android.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-phy@lists.infradead.org, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" fwnode needs to be set for a device for fw_devlink to be able to track/enforce its dependencies correctly. Without this, you'll see error messages like this when the supplier has probed and tries to make sure all its fwnode consumers are linked to it using device links: tegra-xusb-padctl 3520000.padctl: Failed to create device link (0x180) with 1-0008 Reported-by: Jon Hunter Closes: https://lore.kernel.org/all/20240910130019.35081-1-jonathanh@nvidia.com/ Tested-by: Jon Hunter Suggested-by: "Nícolas F. R. A. Prado" Signed-off-by: Saravana Kannan Acked-by: Thierry Reding --- drivers/phy/tegra/xusb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/phy/tegra/xusb.c b/drivers/phy/tegra/xusb.c index cfdb54b6070a..0a2096085971 100644 --- a/drivers/phy/tegra/xusb.c +++ b/drivers/phy/tegra/xusb.c @@ -543,7 +543,7 @@ static int tegra_xusb_port_init(struct tegra_xusb_port *port, device_initialize(&port->dev); port->dev.type = &tegra_xusb_port_type; - port->dev.of_node = of_node_get(np); + device_set_node(&port->dev, of_fwnode_handle(of_node_get(np))); port->dev.parent = padctl->dev; err = dev_set_name(&port->dev, "%s-%u", name, index);