diff mbox series

[etnaviv-next,v3] drm/etnaviv: Print an error message if inserting IOVA range fails

Message ID 20241031155616.2451084-1-sui.jingfeng@linux.dev (mailing list archive)
State New
Headers show
Series [etnaviv-next,v3] drm/etnaviv: Print an error message if inserting IOVA range fails | expand

Commit Message

Sui Jingfeng Oct. 31, 2024, 3:56 p.m. UTC 
Print an error message to help debug when such an error happens,
since there meight have other CPU page size & GPU page size combinations.

Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
Signed-off-by: Sui Jingfeng <sui.jingfeng@linux.dev>
---
v3:
 - Pick up tags and resend.
 - Slightly improve commit message.
---
 drivers/gpu/drm/etnaviv/etnaviv_mmu.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/drivers/gpu/drm/etnaviv/etnaviv_mmu.c b/drivers/gpu/drm/etnaviv/etnaviv_mmu.c
index 7e065b3723cf..47b6242e24a0 100644
--- a/drivers/gpu/drm/etnaviv/etnaviv_mmu.c
+++ b/drivers/gpu/drm/etnaviv/etnaviv_mmu.c
@@ -298,8 +298,12 @@  int etnaviv_iommu_map_gem(struct etnaviv_iommu_context *context,
 		ret = etnaviv_iommu_insert_exact(context, node, etnaviv_obj->size, va);
 	else
 		ret = etnaviv_iommu_find_iova(context, node, etnaviv_obj->size);
-	if (ret < 0)
+	if (ret) {
+		dev_err_ratelimited(context->global->dev,
+				    "Insert iova failed: 0x%llx(0x%x)\n",
+				    va, etnaviv_obj->size);
 		goto unlock;
+	}
 
 	mapping->iova = node->start;
 	ret = etnaviv_iommu_map(context, node->start, etnaviv_obj->size, sgt,