| Message ID | 20241108154600.126162-4-tzimmermann@suse.de (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | drm: Move client code into subdirectories | expand |
On 08/11/2024 16:42, Thomas Zimmermann wrote: > DRM drivers invoke drm_client_setup() to set up in-kernel clients. > No driver should call drm_fbdev_client_setup() directly. Therefore, > unexport the symbol and move the declaration to the internal header > drm_client_internal.h. Thanks, it looks good to me. Reviewed-by: Jocelyn Falempe <jfalempe@redhat.com> > > Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> > --- > .../gpu/drm/clients/drm_client_internal.h | 4 ++-- > drivers/gpu/drm/clients/drm_client_setup.c | 3 ++- > drivers/gpu/drm/clients/drm_fbdev_client.c | 4 ++-- > 3 files changed, 6 insertions(+), 5 deletions(-) > rename include/drm/drm_fbdev_client.h => drivers/gpu/drm/clients/drm_client_internal.h (85%) > > diff --git a/include/drm/drm_fbdev_client.h b/drivers/gpu/drm/clients/drm_client_internal.h > similarity index 85% > rename from include/drm/drm_fbdev_client.h > rename to drivers/gpu/drm/clients/drm_client_internal.h > index e11a5614f127..23258934956a 100644 > --- a/include/drm/drm_fbdev_client.h > +++ b/drivers/gpu/drm/clients/drm_client_internal.h > @@ -1,7 +1,7 @@ > /* SPDX-License-Identifier: MIT */ > > -#ifndef DRM_FBDEV_CLIENT_H > -#define DRM_FBDEV_CLIENT_H > +#ifndef DRM_CLIENT_INTERNAL_H > +#define DRM_CLIENT_INTERNAL_H > > struct drm_device; > struct drm_format_info; > diff --git a/drivers/gpu/drm/clients/drm_client_setup.c b/drivers/gpu/drm/clients/drm_client_setup.c > index c6a295d5de50..4b211a4812b5 100644 > --- a/drivers/gpu/drm/clients/drm_client_setup.c > +++ b/drivers/gpu/drm/clients/drm_client_setup.c > @@ -2,10 +2,11 @@ > > #include <drm/clients/drm_client_setup.h> > #include <drm/drm_device.h> > -#include <drm/drm_fbdev_client.h> > #include <drm/drm_fourcc.h> > #include <drm/drm_print.h> > > +#include "drm_client_internal.h" > + > /** > * drm_client_setup() - Setup in-kernel DRM clients > * @dev: DRM device > diff --git a/drivers/gpu/drm/clients/drm_fbdev_client.c b/drivers/gpu/drm/clients/drm_fbdev_client.c > index 246fb63ab250..f894ba52bdb5 100644 > --- a/drivers/gpu/drm/clients/drm_fbdev_client.c > +++ b/drivers/gpu/drm/clients/drm_fbdev_client.c > @@ -3,11 +3,12 @@ > #include <drm/drm_client.h> > #include <drm/drm_crtc_helper.h> > #include <drm/drm_drv.h> > -#include <drm/drm_fbdev_client.h> > #include <drm/drm_fb_helper.h> > #include <drm/drm_fourcc.h> > #include <drm/drm_print.h> > > +#include "drm_client_internal.h" > + > /* > * struct drm_client_funcs > */ > @@ -164,4 +165,3 @@ int drm_fbdev_client_setup(struct drm_device *dev, const struct drm_format_info > kfree(fb_helper); > return ret; > } > -EXPORT_SYMBOL(drm_fbdev_client_setup);
diff --git a/include/drm/drm_fbdev_client.h b/drivers/gpu/drm/clients/drm_client_internal.h similarity index 85% rename from include/drm/drm_fbdev_client.h rename to drivers/gpu/drm/clients/drm_client_internal.h index e11a5614f127..23258934956a 100644 --- a/include/drm/drm_fbdev_client.h +++ b/drivers/gpu/drm/clients/drm_client_internal.h @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: MIT */ -#ifndef DRM_FBDEV_CLIENT_H -#define DRM_FBDEV_CLIENT_H +#ifndef DRM_CLIENT_INTERNAL_H +#define DRM_CLIENT_INTERNAL_H struct drm_device; struct drm_format_info; diff --git a/drivers/gpu/drm/clients/drm_client_setup.c b/drivers/gpu/drm/clients/drm_client_setup.c index c6a295d5de50..4b211a4812b5 100644 --- a/drivers/gpu/drm/clients/drm_client_setup.c +++ b/drivers/gpu/drm/clients/drm_client_setup.c @@ -2,10 +2,11 @@ #include <drm/clients/drm_client_setup.h> #include <drm/drm_device.h> -#include <drm/drm_fbdev_client.h> #include <drm/drm_fourcc.h> #include <drm/drm_print.h> +#include "drm_client_internal.h" + /** * drm_client_setup() - Setup in-kernel DRM clients * @dev: DRM device diff --git a/drivers/gpu/drm/clients/drm_fbdev_client.c b/drivers/gpu/drm/clients/drm_fbdev_client.c index 246fb63ab250..f894ba52bdb5 100644 --- a/drivers/gpu/drm/clients/drm_fbdev_client.c +++ b/drivers/gpu/drm/clients/drm_fbdev_client.c @@ -3,11 +3,12 @@ #include <drm/drm_client.h> #include <drm/drm_crtc_helper.h> #include <drm/drm_drv.h> -#include <drm/drm_fbdev_client.h> #include <drm/drm_fb_helper.h> #include <drm/drm_fourcc.h> #include <drm/drm_print.h> +#include "drm_client_internal.h" + /* * struct drm_client_funcs */ @@ -164,4 +165,3 @@ int drm_fbdev_client_setup(struct drm_device *dev, const struct drm_format_info kfree(fb_helper); return ret; } -EXPORT_SYMBOL(drm_fbdev_client_setup);
DRM drivers invoke drm_client_setup() to set up in-kernel clients. No driver should call drm_fbdev_client_setup() directly. Therefore, unexport the symbol and move the declaration to the internal header drm_client_internal.h. Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> --- .../gpu/drm/clients/drm_client_internal.h | 4 ++-- drivers/gpu/drm/clients/drm_client_setup.c | 3 ++- drivers/gpu/drm/clients/drm_fbdev_client.c | 4 ++-- 3 files changed, 6 insertions(+), 5 deletions(-) rename include/drm/drm_fbdev_client.h => drivers/gpu/drm/clients/drm_client_internal.h (85%)