From patchwork Fri Nov 29 23:56:32 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cristian Ciocaltea X-Patchwork-Id: 13889009 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8A9E4D735E4 for ; Sat, 30 Nov 2024 00:00:33 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B79F010E04D; Sat, 30 Nov 2024 00:00:32 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=collabora.com header.i=@collabora.com header.b="GkX25JLP"; dkim-atps=neutral Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1FD8710E04D for ; Sat, 30 Nov 2024 00:00:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1732924830; bh=W1HibQ9xsma1KDzi+AGd4o9sDlBpPQXYOQNxed481Qo=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=GkX25JLPmMRvOOprAk5gVhykgnZzKZD3+xks198uHojL70Ut6HT0ykC8Fzm4kpZeF LwoflTJVZKgPJRlFtpO8ouQ0gtKBbP1JAkd/g9reidbcl9qJRHj3Plb+O2zalZYNGM XixodShsOK4IV6fOjpSDi/oQ5QscigeNthP2+XC+RjCKuE90lTPctVDSyP15ums0eU ThX0CwYjklQxEvrDTYEmKtf605A2kBZtRVO6v4N5kTNhNaDCrJSXcKs4Lwq+wOCVak xJSqoffdXYFii5o1s/YRAYqfkfgtUnD/emOJJNW/ri1dB9+yVrHsQdMb13/V1jSb+4 mP5FiS9Y97t8w== Received: from localhost (unknown [86.120.21.57]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by bali.collaboradmins.com (Postfix) with ESMTPSA id 8436E17E0E6C; Sat, 30 Nov 2024 01:00:30 +0100 (CET) From: Cristian Ciocaltea Date: Sat, 30 Nov 2024 01:56:32 +0200 Subject: [PATCH 1/3] drm/connector: hdmi: Evaluate limited range after computing format MIME-Version: 1.0 Message-Id: <20241130-hdmi-conn-yuv-v1-1-254279a08671@collabora.com> References: <20241130-hdmi-conn-yuv-v1-0-254279a08671@collabora.com> In-Reply-To: <20241130-hdmi-conn-yuv-v1-0-254279a08671@collabora.com> To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: kernel@collabora.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.2 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Evaluating the requirement to use a limited RGB quantization range involves a verification of the output format, among others, but this is currently performed before actually computing the format, hence relying on the old connector state. Move the call to hdmi_is_limited_range() after hdmi_compute_config() to ensure the verification is done on the updated output format. Signed-off-by: Cristian Ciocaltea --- drivers/gpu/drm/display/drm_hdmi_state_helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/display/drm_hdmi_state_helper.c b/drivers/gpu/drm/display/drm_hdmi_state_helper.c index feb7a3a759811aed70c679be8704072093e2a79b..0cbcee7e77cd8dff387044487ce28ee5748f5587 100644 --- a/drivers/gpu/drm/display/drm_hdmi_state_helper.c +++ b/drivers/gpu/drm/display/drm_hdmi_state_helper.c @@ -494,12 +494,12 @@ int drm_atomic_helper_connector_hdmi_check(struct drm_connector *connector, connector_state_get_mode(new_conn_state); int ret; - new_conn_state->hdmi.is_limited_range = hdmi_is_limited_range(connector, new_conn_state); - ret = hdmi_compute_config(connector, new_conn_state, mode); if (ret) return ret; + new_conn_state->hdmi.is_limited_range = hdmi_is_limited_range(connector, new_conn_state); + ret = hdmi_generate_infoframes(connector, new_conn_state); if (ret) return ret;