| Message ID | 20241204-topic-misc-sm8350-mdss-bindings-fix-v1-1-aa492a306bdb@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | dt-bindings: display: msm: sm8350-mdss: document the third interconnect path | expand |
On Wed, Dec 04, 2024 at 11:36:37AM +0100, Neil Armstrong wrote: > Document the missing third "cpu-cfg" interconnect path for the MDSS hardware > found on the Qualcomm SM8350 platform. > > This fixes: > display-subsystem@ae00000: interconnects: [[121, 7, 0, 77, 1, 0], [121, 8, 0, 77, 1, 0], [78, 2, 3, 79, 16, 3]] is too long > from schema $id: http://devicetree.org/schemas/display/msm/qcom,sm8350-mdss.yaml# > display-subsystem@ae00000: interconnect-names: ['mdp0-mem', 'mdp1-mem', 'cpu-cfg'] is too long > from schema $id: http://devicetree.org/schemas/display/msm/qcom,sm8350-mdss.yaml# > > Fixes: 430e11f42bff ("dt-bindings: display: msm: Add qcom, sm8350-mdss binding") > Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> > --- > Documentation/devicetree/bindings/display/msm/qcom,sm8350-mdss.yaml | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
On Wed, 04 Dec 2024 11:36:37 +0100, Neil Armstrong wrote: > Document the missing third "cpu-cfg" interconnect path for the MDSS hardware > found on the Qualcomm SM8350 platform. > > This fixes: > display-subsystem@ae00000: interconnects: [[121, 7, 0, 77, 1, 0], [121, 8, 0, 77, 1, 0], [78, 2, 3, 79, 16, 3]] is too long > from schema $id: http://devicetree.org/schemas/display/msm/qcom,sm8350-mdss.yaml# > display-subsystem@ae00000: interconnect-names: ['mdp0-mem', 'mdp1-mem', 'cpu-cfg'] is too long > from schema $id: http://devicetree.org/schemas/display/msm/qcom,sm8350-mdss.yaml# > > Fixes: 430e11f42bff ("dt-bindings: display: msm: Add qcom, sm8350-mdss binding") > Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> > --- > Documentation/devicetree/bindings/display/msm/qcom,sm8350-mdss.yaml | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/msm/qcom,sm8350-mdss.example.dtb: display-subsystem@ae00000: interconnects: [[4294967295, 7, 0, 4294967295, 1, 0], [4294967295, 8, 0, 4294967295, 1, 0]] is too short from schema $id: http://devicetree.org/schemas/display/msm/qcom,sm8350-mdss.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/msm/qcom,sm8350-mdss.example.dtb: display-subsystem@ae00000: interconnect-names: ['mdp0-mem', 'mdp1-mem'] is too short from schema $id: http://devicetree.org/schemas/display/msm/qcom,sm8350-mdss.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241204-topic-misc-sm8350-mdss-bindings-fix-v1-1-aa492a306bdb@linaro.org The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On 04/12/2024 12:29, Rob Herring (Arm) wrote: > > On Wed, 04 Dec 2024 11:36:37 +0100, Neil Armstrong wrote: >> Document the missing third "cpu-cfg" interconnect path for the MDSS hardware >> found on the Qualcomm SM8350 platform. >> >> This fixes: >> display-subsystem@ae00000: interconnects: [[121, 7, 0, 77, 1, 0], [121, 8, 0, 77, 1, 0], [78, 2, 3, 79, 16, 3]] is too long >> from schema $id: http://devicetree.org/schemas/display/msm/qcom,sm8350-mdss.yaml# >> display-subsystem@ae00000: interconnect-names: ['mdp0-mem', 'mdp1-mem', 'cpu-cfg'] is too long >> from schema $id: http://devicetree.org/schemas/display/msm/qcom,sm8350-mdss.yaml# >> >> Fixes: 430e11f42bff ("dt-bindings: display: msm: Add qcom, sm8350-mdss binding") >> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> >> --- >> Documentation/devicetree/bindings/display/msm/qcom,sm8350-mdss.yaml | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> > > My bot found errors running 'make dt_binding_check' on your patch: > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/msm/qcom,sm8350-mdss.example.dtb: display-subsystem@ae00000: interconnects: [[4294967295, 7, 0, 4294967295, 1, 0], [4294967295, 8, 0, 4294967295, 1, 0]] is too short > from schema $id: http://devicetree.org/schemas/display/msm/qcom,sm8350-mdss.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/msm/qcom,sm8350-mdss.example.dtb: display-subsystem@ae00000: interconnect-names: ['mdp0-mem', 'mdp1-mem'] is too short > from schema $id: http://devicetree.org/schemas/display/msm/qcom,sm8350-mdss.yaml# Oh, indeed, will fix in v2 Thanks, Neil > > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241204-topic-misc-sm8350-mdss-bindings-fix-v1-1-aa492a306bdb@linaro.org > > The base for the series is generally the latest rc1. A different dependency > should be noted in *this* patch. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit after running the above command yourself. Note > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > your schema. However, it must be unset to test all examples with your schema. >
diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm8350-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm8350-mdss.yaml index 163fc83c1e80cf07383f9aef510f2f58a26e1ecc..cd9c6c78413f887c984b522f83cc7e437ce97d25 100644 --- a/Documentation/devicetree/bindings/display/msm/qcom,sm8350-mdss.yaml +++ b/Documentation/devicetree/bindings/display/msm/qcom,sm8350-mdss.yaml @@ -38,12 +38,13 @@ properties: maxItems: 1 interconnects: - maxItems: 2 + maxItems: 3 interconnect-names: items: - const: mdp0-mem - const: mdp1-mem + - const: cpu-cfg patternProperties: "^display-controller@[0-9a-f]+$":
Document the missing third "cpu-cfg" interconnect path for the MDSS hardware found on the Qualcomm SM8350 platform. This fixes: display-subsystem@ae00000: interconnects: [[121, 7, 0, 77, 1, 0], [121, 8, 0, 77, 1, 0], [78, 2, 3, 79, 16, 3]] is too long from schema $id: http://devicetree.org/schemas/display/msm/qcom,sm8350-mdss.yaml# display-subsystem@ae00000: interconnect-names: ['mdp0-mem', 'mdp1-mem', 'cpu-cfg'] is too long from schema $id: http://devicetree.org/schemas/display/msm/qcom,sm8350-mdss.yaml# Fixes: 430e11f42bff ("dt-bindings: display: msm: Add qcom, sm8350-mdss binding") Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> --- Documentation/devicetree/bindings/display/msm/qcom,sm8350-mdss.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- base-commit: 667ff2368867af7000ce32a8b3fc025c2b3226b3 change-id: 20241204-topic-misc-sm8350-mdss-bindings-fix-1701baffc1aa Best regards,