| Message ID | 20241205163002.1804784-1-dario.binacchi@amarulasolutions.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [RESEND,v2] drm/panel: synaptics-r63353: Fix regulator unbalance | expand |
On 12/5/2024 8:29 AM, Dario Binacchi wrote: > From: Michael Trimarchi <michael@amarulasolutions.com> > > The shutdown function can be called when the display is already > unprepared. For example during reboot this trigger a kernel > backlog. Calling the drm_panel_unprepare, allow us to avoid > to trigger the kernel warning. > > Fixes: 2e87bad7cd33 ("drm/panel: Add Synaptics R63353 panel driver") > Tested-by: Dario Binacchi <dario.binacchi@amarulasolutions.com> > Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com> > Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com> > Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org> Reviewed-by: Jessica Zhang <quic_jesszhan@quicinc.com> > > --- > > Changes in v2: > - Add 'Fixes' tag. > - Add 'Reviewed-by' tag of Neil Armstrong. > > drivers/gpu/drm/panel/panel-synaptics-r63353.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/panel/panel-synaptics-r63353.c b/drivers/gpu/drm/panel/panel-synaptics-r63353.c > index 169c629746c7..17349825543f 100644 > --- a/drivers/gpu/drm/panel/panel-synaptics-r63353.c > +++ b/drivers/gpu/drm/panel/panel-synaptics-r63353.c > @@ -325,7 +325,7 @@ static void r63353_panel_shutdown(struct mipi_dsi_device *dsi) > { > struct r63353_panel *rpanel = mipi_dsi_get_drvdata(dsi); > > - r63353_panel_unprepare(&rpanel->base); > + drm_panel_unprepare(&rpanel->base); > } > > static const struct r63353_desc sharp_ls068b3sx02_data = { > -- > 2.43.0 >
Hi, On Thu, 05 Dec 2024 17:29:58 +0100, Dario Binacchi wrote: > The shutdown function can be called when the display is already > unprepared. For example during reboot this trigger a kernel > backlog. Calling the drm_panel_unprepare, allow us to avoid > to trigger the kernel warning. > > Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-fixes) [1/1] drm/panel: synaptics-r63353: Fix regulator unbalance https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/d2bd3fcb825725a59c8880070b1206b1710922bd
diff --git a/drivers/gpu/drm/panel/panel-synaptics-r63353.c b/drivers/gpu/drm/panel/panel-synaptics-r63353.c index 169c629746c7..17349825543f 100644 --- a/drivers/gpu/drm/panel/panel-synaptics-r63353.c +++ b/drivers/gpu/drm/panel/panel-synaptics-r63353.c @@ -325,7 +325,7 @@ static void r63353_panel_shutdown(struct mipi_dsi_device *dsi) { struct r63353_panel *rpanel = mipi_dsi_get_drvdata(dsi); - r63353_panel_unprepare(&rpanel->base); + drm_panel_unprepare(&rpanel->base); } static const struct r63353_desc sharp_ls068b3sx02_data = {