| Message ID | 20241206220001.164049-9-lizhi.hou@amd.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | AMD NPU driver improvements | expand |
On 12/6/2024 16:00, Lizhi Hou wrote: > For amdxdna_mailbox.c, linux/interrupt.h is indirectly included by > trace/events/amdxdna.h. So if TRACING is disabled, driver compiling will > fail. > > Fixes: b87f920b9344 ("accel/amdxdna: Support hardware mailbox") > Reported-by: Mike Lothian <mike@fireburn.co.uk> > Closes: https://lore.kernel.org/dri-devel/CAHbf0-E+Z2O7rW-x+-EKNQ-nLbf=_ohaNzXxE7WD2cj9kFJERQ@mail.gmail.com/ > Signed-off-by: Mike Lothian <mike@fireburn.co.uk> > Signed-off-by: Lizhi Hou <lizhi.hou@amd.com> Reviewed-by: Mario Limonciello <mario.limonciello@amd.com> > --- > drivers/accel/amdxdna/amdxdna_mailbox.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/accel/amdxdna/amdxdna_mailbox.c b/drivers/accel/amdxdna/amdxdna_mailbox.c > index fe684f463b94..79b9801935e7 100644 > --- a/drivers/accel/amdxdna/amdxdna_mailbox.c > +++ b/drivers/accel/amdxdna/amdxdna_mailbox.c > @@ -6,6 +6,7 @@ > #include <drm/drm_device.h> > #include <drm/drm_managed.h> > #include <linux/bitfield.h> > +#include <linux/interrupt.h> > #include <linux/iopoll.h> > > #define CREATE_TRACE_POINTS
On 12/6/2024 3:00 PM, Lizhi Hou wrote: > For amdxdna_mailbox.c, linux/interrupt.h is indirectly included by > trace/events/amdxdna.h. So if TRACING is disabled, driver compiling will > fail. > > Fixes: b87f920b9344 ("accel/amdxdna: Support hardware mailbox") > Reported-by: Mike Lothian <mike@fireburn.co.uk> > Closes: https://lore.kernel.org/dri-devel/CAHbf0-E+Z2O7rW-x+-EKNQ-nLbf=_ohaNzXxE7WD2cj9kFJERQ@mail.gmail.com/ > Signed-off-by: Mike Lothian <mike@fireburn.co.uk> > Signed-off-by: Lizhi Hou <lizhi.hou@amd.com> Slight problem with the SOB chain which prevents me from applying this. Mike comes first, which indicates he authored this patch. Then you, which says you took Mike's patch and are moving it forward. However, since you sent it and it doesn't have "From: Mike", you get listed as author. Either Mike needs to be the listed author, or a Co-developed-by tag for Mike needs to be listed immediately before his SOB. With either of those: Reviewed-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
On 12/13/24 08:20, Jeffrey Hugo wrote: > On 12/6/2024 3:00 PM, Lizhi Hou wrote: >> For amdxdna_mailbox.c, linux/interrupt.h is indirectly included by >> trace/events/amdxdna.h. So if TRACING is disabled, driver compiling will >> fail. >> >> Fixes: b87f920b9344 ("accel/amdxdna: Support hardware mailbox") >> Reported-by: Mike Lothian <mike@fireburn.co.uk> >> Closes: >> https://lore.kernel.org/dri-devel/CAHbf0-E+Z2O7rW-x+-EKNQ-nLbf=_ohaNzXxE7WD2cj9kFJERQ@mail.gmail.com/ >> Signed-off-by: Mike Lothian <mike@fireburn.co.uk> >> Signed-off-by: Lizhi Hou <lizhi.hou@amd.com> > > Slight problem with the SOB chain which prevents me from applying this. > > Mike comes first, which indicates he authored this patch. Then you, > which says you took Mike's patch and are moving it forward. However, > since you sent it and it doesn't have "From: Mike", you get listed as > author. > > Either Mike needs to be the listed author, or a Co-developed-by tag > for Mike needs to be listed immediately before his SOB. > > With either of those: > > Reviewed-by: Jeffrey Hugo <quic_jhugo@quicinc.com> Got it. I added "From: Mike" and created a standalone patch for this fix. https://lore.kernel.org/dri-devel/20241213163856.1472207-1-lizhi.hou@amd.com/ Thanks, Lizhi
diff --git a/drivers/accel/amdxdna/amdxdna_mailbox.c b/drivers/accel/amdxdna/amdxdna_mailbox.c index fe684f463b94..79b9801935e7 100644 --- a/drivers/accel/amdxdna/amdxdna_mailbox.c +++ b/drivers/accel/amdxdna/amdxdna_mailbox.c @@ -6,6 +6,7 @@ #include <drm/drm_device.h> #include <drm/drm_managed.h> #include <linux/bitfield.h> +#include <linux/interrupt.h> #include <linux/iopoll.h> #define CREATE_TRACE_POINTS
For amdxdna_mailbox.c, linux/interrupt.h is indirectly included by trace/events/amdxdna.h. So if TRACING is disabled, driver compiling will fail. Fixes: b87f920b9344 ("accel/amdxdna: Support hardware mailbox") Reported-by: Mike Lothian <mike@fireburn.co.uk> Closes: https://lore.kernel.org/dri-devel/CAHbf0-E+Z2O7rW-x+-EKNQ-nLbf=_ohaNzXxE7WD2cj9kFJERQ@mail.gmail.com/ Signed-off-by: Mike Lothian <mike@fireburn.co.uk> Signed-off-by: Lizhi Hou <lizhi.hou@amd.com> --- drivers/accel/amdxdna/amdxdna_mailbox.c | 1 + 1 file changed, 1 insertion(+)