| Message ID | 20241210134254.2967524-2-olivier.moysan@foss.st.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm: bridge: adv7511: refine actual capabilities | expand |
On Tue, Dec 10, 2024 at 02:42:52PM +0100, Olivier Moysan wrote: > Set no_i2s_capture flag in hdmi_codec_pdata structure to report > that the ADV7511 HDMI bridge does not support i2s audio capture. > > Signed-off-by: Olivier Moysan <olivier.moysan@foss.st.com> > --- > drivers/gpu/drm/bridge/adv7511/adv7511_audio.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c b/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c > index 61f4a38e7d2b..28ae81ca3651 100644 > --- a/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c > +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c > @@ -234,6 +234,7 @@ static const struct hdmi_codec_pdata codec_data = { > .ops = &adv7511_codec_ops, > .max_i2s_channels = 2, > .i2s = 1, > + .no_i2s_capture = 1, Does it support spdif capture? > .spdif = 1, > }; > > -- > 2.25.1 >
Hi Dmitry, On 12/11/24 23:52, Dmitry Baryshkov wrote: > On Tue, Dec 10, 2024 at 02:42:52PM +0100, Olivier Moysan wrote: >> Set no_i2s_capture flag in hdmi_codec_pdata structure to report >> that the ADV7511 HDMI bridge does not support i2s audio capture. >> >> Signed-off-by: Olivier Moysan <olivier.moysan@foss.st.com> >> --- >> drivers/gpu/drm/bridge/adv7511/adv7511_audio.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c b/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c >> index 61f4a38e7d2b..28ae81ca3651 100644 >> --- a/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c >> +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c >> @@ -234,6 +234,7 @@ static const struct hdmi_codec_pdata codec_data = { >> .ops = &adv7511_codec_ops, >> .max_i2s_channels = 2, >> .i2s = 1, >> + .no_i2s_capture = 1, > > Does it support spdif capture? > "no_i2s_spdif = 1" is relevant also for adv7511 bridge. I can add it in this serie. >> .spdif = 1, >> }; >> >> -- >> 2.25.1 >> > BRs Olivier
On Thu, Dec 19, 2024 at 03:49:45PM +0100, Olivier MOYSAN wrote: > Hi Dmitry, > > On 12/11/24 23:52, Dmitry Baryshkov wrote: > > On Tue, Dec 10, 2024 at 02:42:52PM +0100, Olivier Moysan wrote: > > > Set no_i2s_capture flag in hdmi_codec_pdata structure to report > > > that the ADV7511 HDMI bridge does not support i2s audio capture. > > > > > > Signed-off-by: Olivier Moysan <olivier.moysan@foss.st.com> > > > --- > > > drivers/gpu/drm/bridge/adv7511/adv7511_audio.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c b/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c > > > index 61f4a38e7d2b..28ae81ca3651 100644 > > > --- a/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c > > > +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c > > > @@ -234,6 +234,7 @@ static const struct hdmi_codec_pdata codec_data = { > > > .ops = &adv7511_codec_ops, > > > .max_i2s_channels = 2, > > > .i2s = 1, > > > + .no_i2s_capture = 1, > > > > Does it support spdif capture? > > > > "no_i2s_spdif = 1" is relevant also for adv7511 bridge. > I can add it in this serie. I think you mean no_spdif_playback / no_spdif_capture. Yes, please. > > > > .spdif = 1, > > > }; > > > -- > > > 2.25.1 > > > > > > > BRs > Olivier
diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c b/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c index 61f4a38e7d2b..28ae81ca3651 100644 --- a/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c @@ -234,6 +234,7 @@ static const struct hdmi_codec_pdata codec_data = { .ops = &adv7511_codec_ops, .max_i2s_channels = 2, .i2s = 1, + .no_i2s_capture = 1, .spdif = 1, };
Set no_i2s_capture flag in hdmi_codec_pdata structure to report that the ADV7511 HDMI bridge does not support i2s audio capture. Signed-off-by: Olivier Moysan <olivier.moysan@foss.st.com> --- drivers/gpu/drm/bridge/adv7511/adv7511_audio.c | 1 + 1 file changed, 1 insertion(+)