| Message ID | 20241211032256.28494-3-jason-jh.lin@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add GCE support for MT8196 | expand |
On Wed, Dec 11, 2024 at 11:22:50AM +0800, Jason-JH.Lin wrote: > Add compatible name and iommus property for MT8196. > > Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com> > --- > .../devicetree/bindings/mailbox/mediatek,gce-mailbox.yaml | 4 ++++ > 1 file changed, 4 insertions(+) Headers are never separate from the bindings patch... And you reveived exactly the same comments before which you just ignored. NAK. Best regards, Krzysztof
Hi Krzysztof, Thanks for the reviews. On Wed, 2024-12-11 at 10:39 +0100, Krzysztof Kozlowski wrote: > External email : Please do not click links or open attachments until > you have verified the sender or the content. > > > On Wed, Dec 11, 2024 at 11:22:50AM +0800, Jason-JH.Lin wrote: > > Add compatible name and iommus property for MT8196. > > > > Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com> > > --- > > .../devicetree/bindings/mailbox/mediatek,gce-mailbox.yaml | 4 > > ++++ > > 1 file changed, 4 insertions(+) > > Headers are never separate from the bindings patch... Do you mean I need to merge [PATCH 1/8] and [PATCH 2/8] into 1 patch? > > And you reveived exactly the same comments before which you just > ignored. > I checked the dt_binding_check history and checkpatch history, but I didn't see the WARNING like `header is separated from bindings`. But I did see the WARNING of maintainers updating that appeared every time when I added the new file. Here is my history of dt_binding_check: make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/mailbox/mediatek,gce- mailbox.yaml O=/tmp/src_kernel/kernel/out -C kernel/linux-next -k make[1]: Entering directory '/tmp/src_kernel/kernel/kernel/linux-next' make[2]: Entering directory '/tmp/src_kernel/kernel/out' HOSTCC scripts/basic/fixdep HOSTCC scripts/dtc/dtc.o HOSTCC scripts/dtc/data.o HOSTCC scripts/dtc/srcpos.o HOSTCC scripts/dtc/flattree.o HOSTCC scripts/dtc/fstree.o HOSTCC scripts/dtc/livetree.o HOSTCC scripts/dtc/checks.o HOSTCC scripts/dtc/util.o HOSTCC scripts/dtc/treesource.o LEX scripts/dtc/dtc-lexer.lex.c YACC scripts/dtc/dtc-parser.tab.[ch] HOSTCC scripts/dtc/dtc-lexer.lex.o HOSTCC scripts/dtc/dtc-parser.tab.o SCHEMA Documentation/devicetree/bindings/processed-schema.json HOSTLD scripts/dtc/dtc CHKDT /tmp/src_kernel/kernel/kernel/linux- next/Documentation/devicetree/bindings LINT /tmp/src_kernel/kernel/kernel/linux- next/Documentation/devicetree/bindings DTEX Documentation/devicetree/bindings/mailbox/mediatek,gce- mailbox.example.dts DTC [C] Documentation/devicetree/bindings/mailbox/mediatek,gce- mailbox.example.dtb make[2]: Leaving directory '/tmp/src_kernel/kernel/out' make[1]: Leaving directory '/tmp/src_kernel/kernel/kernel/linux-next' [09:53:30] - - - - - - - - - -> [ OK ] KERN_DIR=kernel/linux-next make -k -j32 dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/mailbox/mediatek,gce- mailbox.yaml Here is my history of checkpatch: ~/linux$ ./scripts/checkpatch.pl --strict --ignore=GERRIT_CHANGE_ID -- show-types 000* ----------------------- 0000-cover-letter.patch ----------------------- total: 0 errors, 0 warnings, 0 checks, 0 lines checked 0000-cover-letter.patch has no obvious style problems and is ready for submission. --------------------------------------------------------------- 0001-dt-bindings-mailbox-mediatek-Add-GCE-header-file-for.patch --------------------------------------------------------------- Traceback (most recent call last): File "scripts/spdxcheck.py", line 6, in <module> from ply import lex, yacc ModuleNotFoundError: No module named 'ply' WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #17: new file mode 100644 total: 0 errors, 1 warnings, 0 checks, 1439 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix- inplace. 0001-dt-bindings-mailbox-mediatek-Add-GCE-header-file-for.patch has style problems, please review. --------------------------------------------------------------- 0002-dt-bindings-mailbox-mediatek-Add-MT8196-support-for-.patch --------------------------------------------------------------- total: 0 errors, 0 warnings, 0 checks, 16 lines checked 0002-dt-bindings-mailbox-mediatek-Add-MT8196-support-for-.patch has no obvious style problems and is ready for submission. --------------------------------------------------------------- Did I miss some configuration? Regards, Jason-JH.Lin > NAK. > > Best regards, > Krzysztof >
On 12/12/2024 04:41, Jason-JH Lin (林睿祥) wrote: > Hi Krzysztof, > > Thanks for the reviews. > > On Wed, 2024-12-11 at 10:39 +0100, Krzysztof Kozlowski wrote: >> External email : Please do not click links or open attachments until >> you have verified the sender or the content. >> >> >> On Wed, Dec 11, 2024 at 11:22:50AM +0800, Jason-JH.Lin wrote: >>> Add compatible name and iommus property for MT8196. >>> >>> Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com> >>> --- >>> .../devicetree/bindings/mailbox/mediatek,gce-mailbox.yaml | 4 >>> ++++ >>> 1 file changed, 4 insertions(+) >> >> Headers are never separate from the bindings patch... > > Do you mean I need to merge [PATCH 1/8] and [PATCH 2/8] into 1 patch? I asked this last time. Best regards, Krzysztof
On Thu, 2024-12-12 at 08:20 +0100, Krzysztof Kozlowski wrote: > External email : Please do not click links or open attachments until > you have verified the sender or the content. > > > On 12/12/2024 04:41, Jason-JH Lin (林睿祥) wrote: > > Hi Krzysztof, > > > > Thanks for the reviews. > > > > On Wed, 2024-12-11 at 10:39 +0100, Krzysztof Kozlowski wrote: > > > External email : Please do not click links or open attachments > > > until > > > you have verified the sender or the content. > > > > > > > > > On Wed, Dec 11, 2024 at 11:22:50AM +0800, Jason-JH.Lin wrote: > > > > Add compatible name and iommus property for MT8196. > > > > > > > > Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com> > > > > --- > > > > .../devicetree/bindings/mailbox/mediatek,gce- > > > > mailbox.yaml | 4 > > > > ++++ > > > > 1 file changed, 4 insertions(+) > > > > > > Headers are never separate from the bindings patch... > > > > Do you mean I need to merge [PATCH 1/8] and [PATCH 2/8] into 1 > > patch? > > I asked this last time. > Oh, you're right. Sorry, I missed the last sentence in [PATCH v1 1/8]: This goes with binding. I'll merge them at the next version. Regards, Jason-JH.Lin > Best regards, > Krzysztof
diff --git a/Documentation/devicetree/bindings/mailbox/mediatek,gce-mailbox.yaml b/Documentation/devicetree/bindings/mailbox/mediatek,gce-mailbox.yaml index cef9d7601398..73d6db34d64a 100644 --- a/Documentation/devicetree/bindings/mailbox/mediatek,gce-mailbox.yaml +++ b/Documentation/devicetree/bindings/mailbox/mediatek,gce-mailbox.yaml @@ -25,6 +25,7 @@ properties: - mediatek,mt8188-gce - mediatek,mt8192-gce - mediatek,mt8195-gce + - mediatek,mt8196-gce - items: - const: mediatek,mt6795-gce - const: mediatek,mt8173-gce @@ -49,6 +50,9 @@ properties: items: - const: gce + iommus: + maxItems: 1 + required: - compatible - "#mbox-cells"
Add compatible name and iommus property for MT8196. Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com> --- .../devicetree/bindings/mailbox/mediatek,gce-mailbox.yaml | 4 ++++ 1 file changed, 4 insertions(+)