| Message ID | 20241212014717.14286-1-jiapeng.chong@linux.alibaba.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [-next] drm/amd/display: use swap() in update_phy_id_mapping() | expand |
Applied. Thanks! On Wed, Dec 11, 2024 at 8:47 PM Jiapeng Chong <jiapeng.chong@linux.alibaba.com> wrote: > > Use existing swap() function rather than duplicating its implementation. > > ./drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crc.c:185:47-48: WARNING opportunity for swap(). > ./drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crc.c:125:53-54: WARNING opportunity for swap(). > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=12335 > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> > --- > .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crc.c | 14 ++++---------- > 1 file changed, 4 insertions(+), 10 deletions(-) > > diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crc.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crc.c > index 309c7999faa6..6fdc306a4a86 100644 > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crc.c > +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crc.c > @@ -120,11 +120,8 @@ static void update_phy_id_mapping(struct amdgpu_device *adev) > for (idx = connector_cnt; idx > 1 ; idx--) { > for (idx_2 = 0; idx_2 < (idx - 1); idx_2++) { > if (sort_connector[idx_2]->dc_link->link_enc_hw_inst > > - sort_connector[idx_2 + 1]->dc_link->link_enc_hw_inst) { > - aconnector = sort_connector[idx_2]; > - sort_connector[idx_2] = sort_connector[idx_2 + 1]; > - sort_connector[idx_2 + 1] = aconnector; > - } > + sort_connector[idx_2 + 1]->dc_link->link_enc_hw_inst) > + swap(sort_connector[idx_2], sort_connector[idx_2 + 1]); > } > } > > @@ -180,11 +177,8 @@ static void update_phy_id_mapping(struct amdgpu_device *adev) > } > } > > - if (swap) { > - aconnector = sort_connector[j]; > - sort_connector[j] = sort_connector[j + 1]; > - sort_connector[j + 1] = aconnector; > - } > + if (swap) > + swap(sort_connector[j], sort_connector[j + 1]); > } > } > > -- > 2.32.0.3.g01195cf9f >
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crc.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crc.c index 309c7999faa6..6fdc306a4a86 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crc.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crc.c @@ -120,11 +120,8 @@ static void update_phy_id_mapping(struct amdgpu_device *adev) for (idx = connector_cnt; idx > 1 ; idx--) { for (idx_2 = 0; idx_2 < (idx - 1); idx_2++) { if (sort_connector[idx_2]->dc_link->link_enc_hw_inst > - sort_connector[idx_2 + 1]->dc_link->link_enc_hw_inst) { - aconnector = sort_connector[idx_2]; - sort_connector[idx_2] = sort_connector[idx_2 + 1]; - sort_connector[idx_2 + 1] = aconnector; - } + sort_connector[idx_2 + 1]->dc_link->link_enc_hw_inst) + swap(sort_connector[idx_2], sort_connector[idx_2 + 1]); } } @@ -180,11 +177,8 @@ static void update_phy_id_mapping(struct amdgpu_device *adev) } } - if (swap) { - aconnector = sort_connector[j]; - sort_connector[j] = sort_connector[j + 1]; - sort_connector[j + 1] = aconnector; - } + if (swap) + swap(sort_connector[j], sort_connector[j + 1]); } }
Use existing swap() function rather than duplicating its implementation. ./drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crc.c:185:47-48: WARNING opportunity for swap(). ./drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crc.c:125:53-54: WARNING opportunity for swap(). Reported-by: Abaci Robot <abaci@linux.alibaba.com> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=12335 Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crc.c | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-)