| Message ID | 20241217-rcar-gh-dsi-v5-4-e77421093c05@ideasonboard.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | drm: Add DSI/DP support for Renesas r8a779h0 V4M and grey-hawk board | expand |
On Tue, Dec 17, 2024 at 07:31:38AM +0200, Tomi Valkeinen wrote: > From: Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com> > > Extend the Renesas DU display bindings to support the r8a779h0 V4M. > > Note that we remove the requirement for two ports from the global part > of the bindings, as each conditional part defines the number of required > ports already. This came up with r8a779h0 as it's the first one that has > only one port. > > Signed-off-by: Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com> > Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > Tested-by: Geert Uytterhoeven <geert+renesas@glider.be> TBH, I really dislike tested-by on bindings, because "testing" is essentially "building". You cannot test the binding different way. You can review it, that it matches datasheet. You can test the DTS on the physical hardware, but not the binding. So if this is equal to "building" we do not act like: "I built a kernel, so add my Tested-by tag". Maybe this was added to cover letter, so the tag populated here as well. > --- > .../devicetree/bindings/display/renesas,du.yaml | 52 ++++++++++++++++++++-- > 1 file changed, 48 insertions(+), 4 deletions(-) Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
Hi, On 17/12/2024 08:28, Krzysztof Kozlowski wrote: > On Tue, Dec 17, 2024 at 07:31:38AM +0200, Tomi Valkeinen wrote: >> From: Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com> >> >> Extend the Renesas DU display bindings to support the r8a779h0 V4M. >> >> Note that we remove the requirement for two ports from the global part >> of the bindings, as each conditional part defines the number of required >> ports already. This came up with r8a779h0 as it's the first one that has >> only one port. >> >> Signed-off-by: Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com> >> Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> >> Tested-by: Geert Uytterhoeven <geert+renesas@glider.be> > > TBH, I really dislike tested-by on bindings, because "testing" is > essentially "building". You cannot test the binding different way. You > can review it, that it matches datasheet. You can test the DTS on the > physical hardware, but not the binding. So if this is equal to > "building" we do not act like: "I built a kernel, so add my Tested-by > tag". Maybe this was added to cover letter, so the tag > populated here as well. Yes, Geert gave a tested-by for the series, so b4 applied it to all patches. I'll drop the Tested-by from this and the next patches. Tomi
diff --git a/Documentation/devicetree/bindings/display/renesas,du.yaml b/Documentation/devicetree/bindings/display/renesas,du.yaml index ef4568118e94..3880b4c2ea9a 100644 --- a/Documentation/devicetree/bindings/display/renesas,du.yaml +++ b/Documentation/devicetree/bindings/display/renesas,du.yaml @@ -41,6 +41,7 @@ properties: - renesas,du-r8a77995 # for R-Car D3 compatible DU - renesas,du-r8a779a0 # for R-Car V3U compatible DU - renesas,du-r8a779g0 # for R-Car V4H compatible DU + - renesas,du-r8a779h0 # for R-Car V4M compatible DU reg: maxItems: 1 @@ -69,10 +70,6 @@ properties: $ref: /schemas/graph.yaml#/properties/port unevaluatedProperties: false - required: - - port@0 - - port@1 - unevaluatedProperties: false renesas,cmms: @@ -820,6 +817,53 @@ allOf: - reset-names - renesas,vsps + - if: + properties: + compatible: + contains: + enum: + - renesas,du-r8a779h0 + then: + properties: + clocks: + items: + - description: Functional clock + + clock-names: + items: + - const: du.0 + + interrupts: + maxItems: 1 + + resets: + maxItems: 1 + + reset-names: + items: + - const: du.0 + + ports: + properties: + port@0: + description: DSI 0 + port@1: false + port@2: false + port@3: false + + required: + - port@0 + + renesas,vsps: + maxItems: 1 + + required: + - clock-names + - interrupts + - resets + - reset-names + - renesas,vsps + additionalProperties: false examples: