| Message ID | 20241231-gpu-acd-v3-4-3ba73660e9ca@quicinc.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Support for GPU ACD feature on Adreno X1-85 | expand |
On Tue, 31 Dec 2024 02:41:05 +0530, Akhil P Oommen wrote: > Add a new schema which extends opp-v2 to support a new vendor specific > property required for Adreno GPUs found in Qualcomm's SoCs. The new > property called "qcom,opp-acd-level" carries a u32 value recommended > for each opp needs to be shared to GMU during runtime. > > Also, update MAINTAINERS file include the new opp-v2-qcom-adreno.yaml. > > Cc: Rob Clark <robdclark@gmail.com> > Signed-off-by: Akhil P Oommen <quic_akhilpo@quicinc.com> > --- > .../bindings/opp/opp-v2-qcom-adreno.yaml | 97 ++++++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 98 insertions(+) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/opp/opp-v2-qcom-adreno.yaml: ignoring, error parsing file Traceback (most recent call last): File "/usr/bin/yamllint", line 33, in <module> sys.exit(load_entry_point('yamllint==1.29.0', 'console_scripts', 'yamllint')()) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/lib/python3/dist-packages/yamllint/cli.py", line 228, in run prob_level = show_problems(problems, file, args_format=args.format, ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/lib/python3/dist-packages/yamllint/cli.py", line 113, in show_problems for problem in problems: File "/usr/lib/python3/dist-packages/yamllint/linter.py", line 200, in _run for problem in get_cosmetic_problems(buffer, conf, filepath): File "/usr/lib/python3/dist-packages/yamllint/linter.py", line 137, in get_cosmetic_problems for problem in rule.check(rule_conf, File "/usr/lib/python3/dist-packages/yamllint/rules/indentation.py", line 583, in check yield from _check(conf, token, prev, next, nextnext, context) File "/usr/lib/python3/dist-packages/yamllint/rules/indentation.py", line 344, in _check if expected < 0: ^^^^^^^^^^^^ TypeError: '<' not supported between instances of 'NoneType' and 'int' ./Documentation/devicetree/bindings/opp/opp-v2-qcom-adreno.yaml:97:1: did not find expected key make[2]: *** Deleting file 'Documentation/devicetree/bindings/opp/opp-v2-qcom-adreno.example.dts' Documentation/devicetree/bindings/opp/opp-v2-qcom-adreno.yaml:97:1: did not find expected key make[2]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/opp/opp-v2-qcom-adreno.example.dts] Error 1 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1506: dt_binding_check] Error 2 make: *** [Makefile:251: __sub-make] Error 2 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241231-gpu-acd-v3-4-3ba73660e9ca@quicinc.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On 30.12.2024 11:25 PM, Rob Herring (Arm) wrote: > > On Tue, 31 Dec 2024 02:41:05 +0530, Akhil P Oommen wrote: >> Add a new schema which extends opp-v2 to support a new vendor specific >> property required for Adreno GPUs found in Qualcomm's SoCs. The new >> property called "qcom,opp-acd-level" carries a u32 value recommended >> for each opp needs to be shared to GMU during runtime. >> >> Also, update MAINTAINERS file include the new opp-v2-qcom-adreno.yaml. >> >> Cc: Rob Clark <robdclark@gmail.com> >> Signed-off-by: Akhil P Oommen <quic_akhilpo@quicinc.com> >> --- >> .../bindings/opp/opp-v2-qcom-adreno.yaml | 97 ++++++++++++++++++++++ >> MAINTAINERS | 1 + >> 2 files changed, 98 insertions(+) >> > > My bot found errors running 'make dt_binding_check' on your patch: > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/opp/opp-v2-qcom-adreno.yaml: ignoring, error parsing file > Traceback (most recent call last): > File "/usr/bin/yamllint", line 33, in <module> > sys.exit(load_entry_point('yamllint==1.29.0', 'console_scripts', 'yamllint')()) > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > File "/usr/lib/python3/dist-packages/yamllint/cli.py", line 228, in run > prob_level = show_problems(problems, file, args_format=args.format, You need to shift the closing '}': diff --git a/Documentation/devicetree/bindings/opp/opp-v2-qcom-adreno.yaml b/Documentation/devicetree/bindings/opp/opp-v2-qcom-adreno.yaml index b7874f43aaf6..46fbffaf0a61 100644 --- a/Documentation/devicetree/bindings/opp/opp-v2-qcom-adreno.yaml +++ b/Documentation/devicetree/bindings/opp/opp-v2-qcom-adreno.yaml @@ -93,5 +93,4 @@ examples: opp-peak-kBps = <2136719>; /* Intentionally left out qcom,opp-acd-level property here */ }; - -}; + }; Konrad
On 12/31/2024 3:09 PM, Konrad Dybcio wrote: > On 30.12.2024 11:25 PM, Rob Herring (Arm) wrote: >> >> On Tue, 31 Dec 2024 02:41:05 +0530, Akhil P Oommen wrote: >>> Add a new schema which extends opp-v2 to support a new vendor specific >>> property required for Adreno GPUs found in Qualcomm's SoCs. The new >>> property called "qcom,opp-acd-level" carries a u32 value recommended >>> for each opp needs to be shared to GMU during runtime. >>> >>> Also, update MAINTAINERS file include the new opp-v2-qcom-adreno.yaml. >>> >>> Cc: Rob Clark <robdclark@gmail.com> >>> Signed-off-by: Akhil P Oommen <quic_akhilpo@quicinc.com> >>> --- >>> .../bindings/opp/opp-v2-qcom-adreno.yaml | 97 ++++++++++++++++++++++ >>> MAINTAINERS | 1 + >>> 2 files changed, 98 insertions(+) >>> >> >> My bot found errors running 'make dt_binding_check' on your patch: >> >> yamllint warnings/errors: >> >> dtschema/dtc warnings/errors: >> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/opp/opp-v2-qcom-adreno.yaml: ignoring, error parsing file >> Traceback (most recent call last): >> File "/usr/bin/yamllint", line 33, in <module> >> sys.exit(load_entry_point('yamllint==1.29.0', 'console_scripts', 'yamllint')()) >> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ >> File "/usr/lib/python3/dist-packages/yamllint/cli.py", line 228, in run >> prob_level = show_problems(problems, file, args_format=args.format, > > You need to shift the closing '}': > > diff --git a/Documentation/devicetree/bindings/opp/opp-v2-qcom-adreno.yaml b/Documentation/devicetree/bindings/opp/opp-v2-qcom-adreno.yaml > index b7874f43aaf6..46fbffaf0a61 100644 > --- a/Documentation/devicetree/bindings/opp/opp-v2-qcom-adreno.yaml > +++ b/Documentation/devicetree/bindings/opp/opp-v2-qcom-adreno.yaml > @@ -93,5 +93,4 @@ examples: > opp-peak-kBps = <2136719>; > /* Intentionally left out qcom,opp-acd-level property here */ > }; > - > -}; > + }; > Thanks. Will update. -Akhil > > Konrad
diff --git a/Documentation/devicetree/bindings/opp/opp-v2-qcom-adreno.yaml b/Documentation/devicetree/bindings/opp/opp-v2-qcom-adreno.yaml new file mode 100644 index 000000000000..b7874f43aaf6 --- /dev/null +++ b/Documentation/devicetree/bindings/opp/opp-v2-qcom-adreno.yaml @@ -0,0 +1,97 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/opp/opp-v2-qcom-adreno.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Qualcomm Adreno compatible OPP supply + +description: + Adreno GPUs present in Qualcomm's Snapdragon chipsets uses an OPP specific + ACD related information tailored for the specific chipset. This binding + provides the information needed to describe such a hardware value. + +maintainers: + - Rob Clark <robdclark@gmail.com> + +allOf: + - $ref: opp-v2-base.yaml# + +properties: + compatible: + items: + - const: operating-points-v2-adreno + - const: operating-points-v2 + +patternProperties: + '^opp-[0-9]+$': + type: object + additionalProperties: false + + properties: + opp-hz: true + + opp-level: true + + opp-peak-kBps: true + + opp-supported-hw: true + + qcom,opp-acd-level: + description: | + A positive value representing the ACD (Adaptive Clock Distribution, + a fancy name for clk throttling during voltage droop) level associated + with this OPP node. This value is shared to a co-processor inside GPU + (called Graphics Management Unit a.k.a GMU) during wake up. It may not + be present for some OPPs and GMU will disable ACD while transitioning + to that OPP. This value encodes a voltage threshold, delay cycles & + calibration margins which are identified by characterization of the + SoC. So, it doesn't have any unit. This data is passed to GMU firmware + via 'HFI_H2F_MSG_ACD' packet. + $ref: /schemas/types.yaml#/definitions/uint32 + + required: + - opp-hz + - opp-level + +required: + - compatible + +additionalProperties: false + +examples: + - | + #include <dt-bindings/power/qcom-rpmpd.h> + + gpu_opp_table: opp-table { + compatible = "operating-points-v2-adreno", "operating-points-v2"; + + opp-687000000 { + opp-hz = /bits/ 64 <687000000>; + opp-level = <RPMH_REGULATOR_LEVEL_SVS_L1>; + opp-peak-kBps = <8171875>; + qcom,opp-acd-level = <0x882e5ffd>; + }; + + opp-550000000 { + opp-hz = /bits/ 64 <550000000>; + opp-level = <RPMH_REGULATOR_LEVEL_SVS>; + opp-peak-kBps = <6074219>; + qcom,opp-acd-level = <0xc0285ffd>; + }; + + opp-390000000 { + opp-hz = /bits/ 64 <390000000>; + opp-level = <RPMH_REGULATOR_LEVEL_LOW_SVS>; + opp-peak-kBps = <3000000>; + qcom,opp-acd-level = <0xc0285ffd>; + }; + + opp-300000000 { + opp-hz = /bits/ 64 <300000000>; + opp-level = <RPMH_REGULATOR_LEVEL_LOW_SVS_D1>; + opp-peak-kBps = <2136719>; + /* Intentionally left out qcom,opp-acd-level property here */ + }; + +}; diff --git a/MAINTAINERS b/MAINTAINERS index 910305c11e8a..f7119623e1f3 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7292,6 +7292,7 @@ S: Maintained B: https://gitlab.freedesktop.org/drm/msm/-/issues T: git https://gitlab.freedesktop.org/drm/msm.git F: Documentation/devicetree/bindings/display/msm/gpu.yaml +F: Documentation/devicetree/bindings/opp/opp-v2-qcom-adreno.yaml F: drivers/gpu/drm/msm/adreno/ F: drivers/gpu/drm/msm/msm_gpu.* F: drivers/gpu/drm/msm/msm_gpu_devfreq.*
Add a new schema which extends opp-v2 to support a new vendor specific property required for Adreno GPUs found in Qualcomm's SoCs. The new property called "qcom,opp-acd-level" carries a u32 value recommended for each opp needs to be shared to GMU during runtime. Also, update MAINTAINERS file include the new opp-v2-qcom-adreno.yaml. Cc: Rob Clark <robdclark@gmail.com> Signed-off-by: Akhil P Oommen <quic_akhilpo@quicinc.com> --- .../bindings/opp/opp-v2-qcom-adreno.yaml | 97 ++++++++++++++++++++++ MAINTAINERS | 1 + 2 files changed, 98 insertions(+)