| Message ID | 20250102212244.1586340-1-lizhi.hou@amd.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [V1,1/7] accel/amdxdna: Declare npu device profile as static variables | expand |
Hi, Thanks for the patches. For the series: Reviewed-by: Mario Limonciello <mario.limonciello@amd.com> I've committed them to drm-misc-next as well: fee7aaee11f52 accel/amdxdna: Declare npu6_dev_priv as static 3b5bcf64a65b3 accel/amdxdna: Add __user to second parameter of aie2_query_status 72e487b47d249 accel/amdxdna: Declare force_cmdlist as static 1f74400529488 accel/amdxdna: Use rcu_access_pointer for __rcu pointer c199310be29a0 accel/amdxdna: Declare aie2_max_col as static 3c8cfec3fcc4f accel/amdxdna: Declare mailbox register base as __iomem pointer 71486e48370e8 accel/amdxdna: Declare npu device profile as static variables On 1/2/2025 15:22, Lizhi Hou wrote: > Declare the variables as static to fix the sparse warnings: > symbol 'npu5_dev_priv' was not declared. Should it be static? > symbol 'npu1_dev_priv' was not declared. Should it be static? > symbol 'npu4_dev_priv' was not declared. Should it be static? > symbol 'npu2_dev_priv' was not declared. Should it be static? > > Fixes: 8c9ff1b181ba ("accel/amdxdna: Add a new driver for AMD AI Engine") > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202412310648.dtMHgGem-lkp@intel.com/ > Signed-off-by: Lizhi Hou <lizhi.hou@amd.com> > --- > drivers/accel/amdxdna/npu1_regs.c | 2 +- > drivers/accel/amdxdna/npu2_regs.c | 2 +- > drivers/accel/amdxdna/npu4_regs.c | 2 +- > drivers/accel/amdxdna/npu5_regs.c | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/accel/amdxdna/npu1_regs.c b/drivers/accel/amdxdna/npu1_regs.c > index e408af57e378..e4f6dac7d00f 100644 > --- a/drivers/accel/amdxdna/npu1_regs.c > +++ b/drivers/accel/amdxdna/npu1_regs.c > @@ -62,7 +62,7 @@ const struct dpm_clk_freq npu1_dpm_clk_table[] = { > { 0 } > }; > > -const struct amdxdna_dev_priv npu1_dev_priv = { > +static const struct amdxdna_dev_priv npu1_dev_priv = { > .fw_path = "amdnpu/1502_00/npu.sbin", > .protocol_major = 0x5, > .protocol_minor = 0x7, > diff --git a/drivers/accel/amdxdna/npu2_regs.c b/drivers/accel/amdxdna/npu2_regs.c > index 286bd0d475e2..a081cac75ee0 100644 > --- a/drivers/accel/amdxdna/npu2_regs.c > +++ b/drivers/accel/amdxdna/npu2_regs.c > @@ -61,7 +61,7 @@ > #define NPU2_SMU_BAR_BASE MMNPU_APERTURE4_BASE > #define NPU2_SRAM_BAR_BASE MMNPU_APERTURE1_BASE > > -const struct amdxdna_dev_priv npu2_dev_priv = { > +static const struct amdxdna_dev_priv npu2_dev_priv = { > .fw_path = "amdnpu/17f0_00/npu.sbin", > .protocol_major = 0x6, > .protocol_minor = 0x6, > diff --git a/drivers/accel/amdxdna/npu4_regs.c b/drivers/accel/amdxdna/npu4_regs.c > index 00c52833ce89..9f2e33182ec6 100644 > --- a/drivers/accel/amdxdna/npu4_regs.c > +++ b/drivers/accel/amdxdna/npu4_regs.c > @@ -82,7 +82,7 @@ const struct dpm_clk_freq npu4_dpm_clk_table[] = { > { 0 } > }; > > -const struct amdxdna_dev_priv npu4_dev_priv = { > +static const struct amdxdna_dev_priv npu4_dev_priv = { > .fw_path = "amdnpu/17f0_10/npu.sbin", > .protocol_major = 0x6, > .protocol_minor = 12, > diff --git a/drivers/accel/amdxdna/npu5_regs.c b/drivers/accel/amdxdna/npu5_regs.c > index 118849272f27..5f1cf83461c4 100644 > --- a/drivers/accel/amdxdna/npu5_regs.c > +++ b/drivers/accel/amdxdna/npu5_regs.c > @@ -61,7 +61,7 @@ > #define NPU5_SMU_BAR_BASE MMNPU_APERTURE4_BASE > #define NPU5_SRAM_BAR_BASE MMNPU_APERTURE1_BASE > > -const struct amdxdna_dev_priv npu5_dev_priv = { > +static const struct amdxdna_dev_priv npu5_dev_priv = { > .fw_path = "amdnpu/17f0_11/npu.sbin", > .protocol_major = 0x6, > .protocol_minor = 12,
diff --git a/drivers/accel/amdxdna/npu1_regs.c b/drivers/accel/amdxdna/npu1_regs.c index e408af57e378..e4f6dac7d00f 100644 --- a/drivers/accel/amdxdna/npu1_regs.c +++ b/drivers/accel/amdxdna/npu1_regs.c @@ -62,7 +62,7 @@ const struct dpm_clk_freq npu1_dpm_clk_table[] = { { 0 } }; -const struct amdxdna_dev_priv npu1_dev_priv = { +static const struct amdxdna_dev_priv npu1_dev_priv = { .fw_path = "amdnpu/1502_00/npu.sbin", .protocol_major = 0x5, .protocol_minor = 0x7, diff --git a/drivers/accel/amdxdna/npu2_regs.c b/drivers/accel/amdxdna/npu2_regs.c index 286bd0d475e2..a081cac75ee0 100644 --- a/drivers/accel/amdxdna/npu2_regs.c +++ b/drivers/accel/amdxdna/npu2_regs.c @@ -61,7 +61,7 @@ #define NPU2_SMU_BAR_BASE MMNPU_APERTURE4_BASE #define NPU2_SRAM_BAR_BASE MMNPU_APERTURE1_BASE -const struct amdxdna_dev_priv npu2_dev_priv = { +static const struct amdxdna_dev_priv npu2_dev_priv = { .fw_path = "amdnpu/17f0_00/npu.sbin", .protocol_major = 0x6, .protocol_minor = 0x6, diff --git a/drivers/accel/amdxdna/npu4_regs.c b/drivers/accel/amdxdna/npu4_regs.c index 00c52833ce89..9f2e33182ec6 100644 --- a/drivers/accel/amdxdna/npu4_regs.c +++ b/drivers/accel/amdxdna/npu4_regs.c @@ -82,7 +82,7 @@ const struct dpm_clk_freq npu4_dpm_clk_table[] = { { 0 } }; -const struct amdxdna_dev_priv npu4_dev_priv = { +static const struct amdxdna_dev_priv npu4_dev_priv = { .fw_path = "amdnpu/17f0_10/npu.sbin", .protocol_major = 0x6, .protocol_minor = 12, diff --git a/drivers/accel/amdxdna/npu5_regs.c b/drivers/accel/amdxdna/npu5_regs.c index 118849272f27..5f1cf83461c4 100644 --- a/drivers/accel/amdxdna/npu5_regs.c +++ b/drivers/accel/amdxdna/npu5_regs.c @@ -61,7 +61,7 @@ #define NPU5_SMU_BAR_BASE MMNPU_APERTURE4_BASE #define NPU5_SRAM_BAR_BASE MMNPU_APERTURE1_BASE -const struct amdxdna_dev_priv npu5_dev_priv = { +static const struct amdxdna_dev_priv npu5_dev_priv = { .fw_path = "amdnpu/17f0_11/npu.sbin", .protocol_major = 0x6, .protocol_minor = 12,
Declare the variables as static to fix the sparse warnings: symbol 'npu5_dev_priv' was not declared. Should it be static? symbol 'npu1_dev_priv' was not declared. Should it be static? symbol 'npu4_dev_priv' was not declared. Should it be static? symbol 'npu2_dev_priv' was not declared. Should it be static? Fixes: 8c9ff1b181ba ("accel/amdxdna: Add a new driver for AMD AI Engine") Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202412310648.dtMHgGem-lkp@intel.com/ Signed-off-by: Lizhi Hou <lizhi.hou@amd.com> --- drivers/accel/amdxdna/npu1_regs.c | 2 +- drivers/accel/amdxdna/npu2_regs.c | 2 +- drivers/accel/amdxdna/npu4_regs.c | 2 +- drivers/accel/amdxdna/npu5_regs.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-)