| Message ID | 20250110123835.2719824-2-paul-pl.chen@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add Mediatek Soc DRM support for mt8196 | expand |
On Fri, Jan 10, 2025 at 8:58 PM Krzysztof Kozlowski <krzk@kernel.org> wrote: > > On 10/01/2025 13:33, paul-pl.chen wrote: > > From: "Paul-pl.Chen" <paul-pl.chen@mediatek.com> > > > > Add compatible for mmsys yaml of MT8196 > > > > Signed-off-by: Paul-pl.Chen <paul-pl.chen@mediatek.com> > > > This is a wide pattern now in Mediatek: login name is used as family > name. Repeating the same comment to every Mediatek employee is a bit > tedious, so maybe you could fix it internally? > > Create some guideline for your colleagues so you won't repeat the same > things over and over? Not a guarantee that this will go away once and for all, but I can ping some MediaTek folks via a separate channel, and hopefully they can amplify this message internally. Regards, Fei > > Best regards, > Krzysztof
On 13/01/2025 12:25, Fei Shao wrote: > On Fri, Jan 10, 2025 at 8:58 PM Krzysztof Kozlowski <krzk@kernel.org> wrote: >> >> On 10/01/2025 13:33, paul-pl.chen wrote: >>> From: "Paul-pl.Chen" <paul-pl.chen@mediatek.com> >>> >>> Add compatible for mmsys yaml of MT8196 >>> >>> Signed-off-by: Paul-pl.Chen <paul-pl.chen@mediatek.com> >> >> >> This is a wide pattern now in Mediatek: login name is used as family >> name. Repeating the same comment to every Mediatek employee is a bit >> tedious, so maybe you could fix it internally? >> >> Create some guideline for your colleagues so you won't repeat the same >> things over and over? > > Not a guarantee that this will go away once and for all, but I can > ping some MediaTek folks via a separate channel, and hopefully they > can amplify this message internally. Thanks. I still expect from Mediatek employees, so Paul and dozen of others who appear on the list, to actually care about their upstreaming process thus incorporate such feedback into some sort of internal guidelines or trainings, so they will not repeat the same mistake. Big companies have responsibilities. Otherwise it is some sort of exploit of community by big company. Best regards, Krzysztof
On Fri, 2025-01-10 at 13:58 +0100, Krzysztof Kozlowski wrote: > > External email : Please do not click links or open attachments until > you have verified the sender or the content. > > > On 10/01/2025 13:33, paul-pl.chen wrote: > > From: "Paul-pl.Chen" <paul-pl.chen@mediatek.com> > > > > Add compatible for mmsys yaml of MT8196 > > > > Signed-off-by: Paul-pl.Chen <paul-pl.chen@mediatek.com> > > > This is a wide pattern now in Mediatek: login name is used as family > name. Repeating the same comment to every Mediatek employee is a bit > tedious, so maybe you could fix it internally? > > Create some guideline for your colleagues so you won't repeat the > same > things over and over? > > Best regards, > Krzysztof Hi, Krzysztof Thank you for bringing this to our attention. We have already addressed this issue internally and have made the necessary corrections. Mediatek has also conducted special internal awareness campaigns regarding this matter. We are going to establish guidelines to ensure that our colleagues do not repeat the same mistakes. Thank you for your understanding and cooperation. Best regards, Paul
diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml index 3f4262e93c78..5f244a8f6a47 100644 --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml @@ -39,6 +39,11 @@ properties: - mediatek,mt8195-vdosys1 - mediatek,mt8195-vppsys0 - mediatek,mt8195-vppsys1 + - mediatek,mt8196-dispsys0 + - mediatek,mt8196-dispsys1 + - mediatek,mt8196-ovlsys0 + - mediatek,mt8196-ovlsys1 + - mediatek,mt8196-vdisp-ao - mediatek,mt8365-mmsys - const: syscon