From patchwork Fri Jan 24 17:00:09 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vitalii Mordan X-Patchwork-Id: 13950727 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 04FFEC0218E for ; Sun, 26 Jan 2025 14:52:36 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4A75310E381; Sun, 26 Jan 2025 14:52:21 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=ispras.ru header.i=@ispras.ru header.b="qxO6VbNG"; dkim-atps=neutral X-Greylist: delayed 538 seconds by postgrey-1.36 at gabe; Fri, 24 Jan 2025 17:09:29 UTC Received: from mail.ispras.ru (mail.ispras.ru [83.149.199.84]) by gabe.freedesktop.org (Postfix) with ESMTPS id 69AF610E9B8 for ; Fri, 24 Jan 2025 17:09:29 +0000 (UTC) Received: from ldvnode.intra.ispras.ru (unknown [10.10.2.153]) by mail.ispras.ru (Postfix) with ESMTPSA id E1DB340B2269; Fri, 24 Jan 2025 17:00:27 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 mail.ispras.ru E1DB340B2269 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ispras.ru; s=default; t=1737738028; bh=Hhj4Iw8Xku/8T4T+5kZ+uaePDuP74yZIrW5ImoLkSiM=; h=From:To:Cc:Subject:Date:From; b=qxO6VbNG+GkHkc0XpeGe3AxKClIKOYbtSG1Ak/6abMAzYLPFojlTTG3R08lwCxf4w HlVpdWgRpcmAK35tk+23HLTspqeTkSXB83OSnE5y0vxm9RMXdtn/t3T7hUcZpPD3lQ VlVtC2PYJZ2XEpXc76g/gaK1bCjXw1obVtnNG77E= From: Vitalii Mordan To: Andrzej Hajda Cc: Vitalii Mordan , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jani Nikula , Sui Jingfeng , Aleksandr Mishin , Tomi Valkeinen , Quentin Schulz , Yuti Amonkar , Jyri Sarha , Swapnil Jakhade , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Fedor Pchelkin , Alexey Khoroshilov , Vadim Mutilin , lvc-project@linuxtesting.org Subject: [PATCH] gpu: cdns-mhdp8546: fix call balance of mhdp->clk handling routines Date: Fri, 24 Jan 2025 20:00:09 +0300 Message-Id: <20250124170009.2075175-1-mordan@ispras.ru> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Mailman-Approved-At: Sun, 26 Jan 2025 14:52:19 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" If the clock mhdp->clk was not enabled in cdns_mhdp_probe(), it should not be disabled in any path. Found by Linux Verification Center (linuxtesting.org) with Klever. Fixes: fb43aa0acdfd ("drm: bridge: Add support for Cadence MHDP8546 DPI/DP bridge") Signed-off-by: Vitalii Mordan --- drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c b/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c index d081850e3c03..3e923bcfb0bf 100644 --- a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c +++ b/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c @@ -2504,7 +2504,11 @@ static int cdns_mhdp_probe(struct platform_device *pdev) mhdp->info = of_device_get_match_data(dev); - clk_prepare_enable(clk); + ret = clk_prepare_enable(clk); + if (ret) { + dev_err(dev, "Failed to enable clk\n"); + return ret; + } pm_runtime_enable(dev); ret = pm_runtime_resume_and_get(dev);